[COMMITTERS] pgsql: Remove old kluge put in to allow Windows regression tests to

2008-05-17 Thread Andrew Dunstan
Log Message: --- Remove old kluge put in to allow Windows regression tests to succeed, and now found to have been made necessary by our skipping tty detection on Windows. Now that we are doing tty detection on Windows the kluge is unnecessary and wrong. Modified Files: -- p

[COMMITTERS] pgsql: okay, looks like ecpg/compatlib needs -lintl too.

2008-05-17 Thread Tom Lane
Log Message: --- okay, looks like ecpg/compatlib needs -lintl too. Per buildfarm results. Modified Files: -- pgsql/src/interfaces/ecpg/compatlib: Makefile (r1.40 -> r1.41) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/compatlib/Makefil

[COMMITTERS] pgsql: Rewrite the warning about non-transaction-safety of TRUNCATE ...

2008-05-17 Thread Tom Lane
Log Message: --- Rewrite the warning about non-transaction-safety of TRUNCATE ... RESTART IDENTITY to be more explicit about the possible hazards. Per gripe from Neil and subsequent discussion. Eventually we may be able to get rid of this warning, but for now it had better be there. Modi

[COMMITTERS] pgsql: Use isatty() test for pager on Win32; not sure why it was

2008-05-17 Thread Bruce Momjian
Log Message: --- Use isatty() test for pager on Win32; not sure why it was disabled for that platform. Modified Files: -- pgsql/src/bin/psql: print.c (r1.105 -> r1.106) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/print.c?r1=1.105&r2=1.106)

[COMMITTERS] pgsql: In psql, test for output to stdout when forcing pager for wide

2008-05-17 Thread Bruce Momjian
Log Message: --- In psql, test for output to stdout when forcing pager for wide output. Modified Files: -- pgsql/src/bin/psql: print.c (r1.104 -> r1.105) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/print.c?r1=1.104&r2=1.105) -- Sent via p

[COMMITTERS] pgsql: Another fix for compiles on an empty 'po' directory.

2008-05-17 Thread Bruce Momjian
Log Message: --- Another fix for compiles on an empty 'po' directory. Modified Files: -- pgsql/src: nls-global.mk (r1.13 -> r1.14) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/nls-global.mk?r1=1.13&r2=1.14) -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Don't call rm with empty file list.

2008-05-17 Thread Peter Eisentraut
Log Message: --- Don't call rm with empty file list. Modified Files: -- pgsql/src: nls-global.mk (r1.12 -> r1.13) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/nls-global.mk?r1=1.12&r2=1.13) -- Sent via pgsql-committers mailing list (pgsql-committer

[COMMITTERS] pgsql: ecpglib needs to link with libintl if it's in use.

2008-05-17 Thread Tom Lane
Log Message: --- ecpglib needs to link with libintl if it's in use. Per buildfarm results. Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: Makefile (r1.59 -> r1.60) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/Makefile?r

[COMMITTERS] pgsql: Improve pg_regress so that it reports the fact if any test

2008-05-17 Thread Tom Lane
Log Message: --- Improve pg_regress so that it reports the fact if any test process exits with nonzero status. The Windows part of this is untested ... Modified Files: -- pgsql/src/test/regress: pg_regress.c (r1.44 -> r1.45) (http://anoncvs.postgresql.org/

[COMMITTERS] pgsql: Fix utterly-bogus code for computing row heights.

2008-05-17 Thread Tom Lane
Log Message: --- Fix utterly-bogus code for computing row heights. Per crashes on spoonbill, though one wonders why it didn't misbehave everywhere. In passing remove some unnecessary modulo calculations. Modified Files: -- pgsql/src/bin/psql: print.c (r1.103 -> r1.

[COMMITTERS] pgsql: Fix a subtle bug exposed by recent wal_sync_method

2008-05-17 Thread Tom Lane
Log Message: --- Fix a subtle bug exposed by recent wal_sync_method rearrangements. Formerly, the default value of wal_sync_method was determined inside xlog.c, but now it is determined inside guc.c. guc.c was reading xlogdefs.h without having read , leading to wrong determination of DEFAU

[COMMITTERS] pgsql: Remove DEFAULT_SYNC_FLAGBIT ...

2008-05-17 Thread Tom Lane
Log Message: --- Remove DEFAULT_SYNC_FLAGBIT ... not used anymore. Modified Files: -- pgsql/src/include/access: xlogdefs.h (r1.20 -> r1.21) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/xlogdefs.h?r1=1.20&r2=1.21) -- Sent via pgsql-co

Re: [COMMITTERS] pgsql: Implement error checking for pthreads calls in thread-safe mode.

2008-05-17 Thread Gregory Stark
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Log Message: > --- > Implement error checking for pthreads calls in thread-safe mode. They really > should always succeed, but in the likely event of a failure we would > previously fall through *without locking* - the new code will exit(1).