Re: [COMMITTERS] pgsql: Re-enable the old code in xlog.c that tried to use

2009-01-11 Thread Gregory Stark
uld just be HAVE_POSIX_FADVISE not USE_POSIX_FADVISE. The latter was the define I made if the run check passed. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training! -- Sent via pgsql-committers mailing li

Re: [COMMITTERS] pgsql: Fix an oversight in the 8.2 patch that improved mergejoin

2008-09-06 Thread Gregory Stark
he estimated cost of the mergejoin. Is that right? The materialize is just doing the same writing that the final pass of the sort would have been doing. Did we discount the costs for sort for that skipping writing that final pass when that was done? -- Gregory Stark Enterpris

Re: [COMMITTERS] pginstaller - pginst: Consistently spell "initialize", per complain from

2008-06-30 Thread Gregory Stark
"User Mha" <[EMAIL PROTECTED]> writes: > Log Message: > --- > Consistently spell "initialize", per complain from Stefan. "Initialise" is correct in most of the world. "Initialize" is the US spelling. -- Gregory Stark Enterpris

Re: [COMMITTERS] pgsql: Implement error checking for pthreads calls in thread-safe mode.

2008-05-17 Thread Gregory Stark
rite(2) here instead of fprintf. if pthread is cocked up then fprintf is going to have trouble locking the buffer. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's On-Demand Production Tuning -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing

2008-04-25 Thread Gregory Stark
ing problem where you have to go out and check that there are no records referencing that entry. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services! -- Sent via pgsql-committers mailing list (pgsql-committers@postgre

Re: [COMMITTERS] pgsql: Fix a couple of oversights associated with the "physical tlist"

2008-04-17 Thread Gregory Stark
fact present in the target list? Is it going to force us to do extra work to reconstruct the same data? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services! -- Sent via pgsql-committers mailing list (pgsql-committers@p

Re: [COMMITTERS] pgsql: Add URLs for : * Speed WAL recovery by allowing more than one

2008-03-18 Thread Gregory Stark
be better to reuse infrastructure useful in other cases as well. So I guess that's some kind of consensus... of two. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's 24x7 Postgres support! -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add checks to TRUNCATE, CLUSTER, and REINDEX to prevent

2008-01-31 Thread Gregory Stark
like: Add deadlock detection when a process holding a buffer pin is blocked by a lock held by a process attempting to LockBufferForCleanup() on that buffer or more complex versions thereof. (And without adding unacceptable overhead to pin/unpin.) -- Gregory Stark EnterpriseDB http:/

Re: [COMMITTERS] pgsql: Update TODO list based on 8.3 completed items: < * Allow major

2007-12-29 Thread Gregory Stark
s are nigh one-liners. The diff is shorter and clearer than a message describing the description of the todo item. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training! -

Re: [COMMITTERS] pgsql: The E.

2007-12-09 Thread Gregory Stark
rd to extend copyright terms. http://links.jstor.org/sici?sici=0030-8129%28196109%2976%3A4%3C380%3AWATCAO%3E2.0.CO%3B2-P&size=LARGE&origin=JSTOR-enlargePage -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB

Re: [COMMITTERS] [HACKERS] pgsql: Use strip -x on OS/X-darwinbecause non-"-x" causes link

2007-11-13 Thread Gregory Stark
nt, expr is already intended to be used as the program for an if condition. You can just do: if expr "`uname -a`" : Darwin >/dev/null ; then ... -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's On-Demand Production Tuning ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [COMMITTERS] pgsql: If an index depends on no columns of its table, give it a

2007-11-09 Thread Gregory Stark
tions to the stated problem. If we can there's no reason to make only one of them legal. Actually there is one reason to prefer Simon's solution (which was the only approach I've seen before) -- it's standard SQL and should work on any database with check constraints and unique con

Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> FWIW I found another issue with this variable when I was experimenting with >> small block sizes. If you set the target <= the tuple header the toaster >> breaks.

Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Gregory Stark
with the maximum number of columns (1600) the null bitmap can't be as large as 2kB (the most it can get to is 200 bytes). -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's PostGIS support! ---(end of broadcast

Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

2007-10-01 Thread Gregory Stark
ce to `ERR_pop_to_mark' collect2: ld returned 1 exit status -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [COMMITTERS] pgsql: Some small tuptoaster improvements from Greg Stark.

2007-09-27 Thread Gregory Stark
too short for compression; and > annotate various lines that are currently unreachable. There were some further changes you suggested involving rethinking the way the compression strategy works. Should I put that on my todo list for early in 8.4? -- Gregory Stark EnterpriseDB

Re: [COMMITTERS] pgsql: Parenthesize macro arguments safely.

2007-09-26 Thread Gregory Stark
pen it should probably be backported. Otherwise a future bug fix could introduce a call to it and then be backportted fix without anyone catching that the macro was defined differently previously. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com

Re: [COMMITTERS] pgsql: Fix a portability bug (ye olde not casting a argument

2007-09-17 Thread Gregory Stark
Should we add buildfarm animals which compile with -fsigned-chars and -funsigned-chars in addition to the per-architecture defaults? Does that guarantee that we'll trigger this warning or does it not help? -- Gregory Stark EnterpriseDB http://www.enterprisedb.com

Re: [COMMITTERS] pgsql: Set the correct context (PGC_SIGHUP) for log_autovacuum, per

2007-09-11 Thread Gregory Stark
which 0 means "on" and 1 means "on sometimes" is surprising. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [COMMITTERS] pgsql: Clarify some error messages about duplicate things.

2007-06-04 Thread Gregory Stark
eue? They cause lots of bitrot and it's a pain when a large hunk of a complex patch fails because of some one-line cosmetic change. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 9: In v

Re: [COMMITTERS] pgsql: Teach tuplestore.c to throw away data before the "mark" point

2007-05-22 Thread Gregory Stark
tzing from Tom Lane. Fwiw most of this code -- and by the sounds of it, all the code actually committed -- came from Simon Riggs. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 3: Have you che

Re: [COMMITTERS] pgsql: Fix a bunch of bad grammar in the docs:", which see for

2007-05-16 Thread Gregory Stark
#x27;s used heavily in the TeX book. It's probably not a bad idea to avoid it though given that many readers will indeed be surprised by it. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)-

Re: [COMMITTERS] pgsql: Teach tuplesort.c about "top N" sorting, in which only the first

2007-05-04 Thread Gregory Stark
use (a) none of this information > is exposed outside tuplesort.c, and (b) the tuplesortstate object > is probably gone by the time EXPLAIN ANALYZE runs, anyway. It would be positively wonderful to see whether the sort spilled to disk in the explain analyze. Could we make putting more feedba