Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Tom Lane
Josh Kupershmidt writes: > I think you left an extra > > > in the description for pg_stat_get_backend_start(integer), around line > 1712 of monitoring.sgml. Other than that, I liked the changes. Wups, you're right. Will fix in my next set of changes. Thanks for catching that.

Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Josh Kupershmidt
On Sun, Apr 29, 2012 at 2:06 PM, Tom Lane wrote: > Josh Kupershmidt writes: >> Yeah, that sounds fine. The paragraph I think you're talking about >> claims "These functions are listed in Table 27-13", but Table 27-13 >> only has a few functions (e.g. pg_stat_get_db_block_time_read() is >> missing

Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Tom Lane
Josh Kupershmidt writes: > Yeah, that sounds fine. The paragraph I think you're talking about > claims "These functions are listed in Table 27-13", but Table 27-13 > only has a few functions (e.g. pg_stat_get_db_block_time_read() is > missing). Maybe that paragraph could clarify that it's talking

Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Josh Kupershmidt
On Sun, Apr 29, 2012 at 8:03 AM, Tom Lane wrote: > Josh Kupershmidt writes: >> I did find it marginally useful to see clarifications of milliseconds >> vs. microseconds  (e.g. "block_write_time" column). Yeah, you could >> figure out that based on the " / 1000" in the view description, but >> it'

Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Tom Lane
Josh Kupershmidt writes: > On Sat, Apr 28, 2012 at 2:24 PM, Tom Lane wrote: >> Currently, some of the per-column entries in monitoring.sgml mention the >> underlying stats function; but the coverage is incomplete, and it seems >> very cluttering anyway. I propose that we remove all that and inst

Re: [DOCS] Documentation of underlying functions for statistics views

2012-04-29 Thread Magnus Hagander
On Sat, Apr 28, 2012 at 23:24, Tom Lane wrote: > Currently, some of the per-column entries in monitoring.sgml mention the > underlying stats function; but the coverage is incomplete, and it seems > very cluttering anyway.  I propose that we remove all that and instead > just suggest that people ex