Re: [HACKERS] Block level parallel vacuum

2018-11-24 Thread Amit Kapila
On Sat, Nov 24, 2018 at 5:47 PM Amit Kapila wrote: > On Tue, Oct 30, 2018 at 2:04 PM Masahiko Sawada wrote: > > > > I could see that you have put a lot of effort on this patch and still > we are not able to make much progress mainly I guess because of > relation extension lock problem. I think w

Re: POC for a function trust mechanism

2018-11-24 Thread Noah Misch
On Sun, Aug 12, 2018 at 10:40:30PM -0400, Robert Haas wrote: > On Wed, Aug 8, 2018 at 1:15 PM, Tom Lane wrote: > > If we had, say, a catalog that provided the desired list of trusted roles > > for every role, then we could imagine implementing that context change > > automatically. Likewise, stuf

Re: tab-completion debug print

2018-11-24 Thread David Fetter
On Fri, Nov 23, 2018 at 04:32:31PM -0500, Tom Lane wrote: > Kyotaro HORIGUCHI writes: > > I was reminded that I was often annoyed with identifying the code > > that made a word-completion, by hearing the same complaint from a > > collegue of mine just now. > > Something like the attached that twea

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

2018-11-24 Thread Thomas Munro
On Sun, Nov 25, 2018 at 3:38 AM Christoph Berg wrote: > Re: Thomas Munro 2018-11-23 > > Add WL_EXIT_ON_PM_DEATH pseudo-event. > > I think this broke something: > > TRAP: FailedAssertion(»!(!IsUnderPostmaster || (wakeEvents & (1 << 5)) || > (wakeEvents & (1 << 4)))«, Datei: > »/build/postgresql-

Re: Centralize use of PG_INTXX_MIN/MAX for integer limits

2018-11-24 Thread Andrew Gierth
> "Michael" == Michael Paquier writes: Michael> Hi all, Michael> A couple of years ago, 62e2a8dc has introduced in c.h a set of Michael> limits (to fix some portability issues from 83ff1618) to make Michael> the code more system-independent. Those are for example Michael> PG_INT32_MIN,

Re: Desirability of client-side expressions in psql?

2018-11-24 Thread Corey Huinker
> > >>psql> \if :i >= 5 > >> > > I think we're ok with that so long as none of the operators or values > has a > > \ in it. > > What barriers do you see to re-using the pgbench grammar? > > The pgbench expression grammar mimics SQL expression grammar, > on integers, floats, booleans & NULL. > >

Re: RHEL 8.0 build

2018-11-24 Thread Tom Lane
Jeremy Harris writes: > Trying to set up a buildfarm animal on a RHEL 8.0 (beta) system, > the build fails early: > ... > It appears to be a "configure" script looking for python; and there is > no such. You can have python3 or python2 - but neither package install > provides a symlink of just "

Re: Regarding performance regression on specific query

2018-11-24 Thread Tom Lane
Amit Langote writes: > On 2018/11/20 2:49, Jung, Jinho wrote: >> [ assorted queries ] > I noticed that these two are fixed by running ANALYZE in the database in > which these queries are run. That didn't help much for me. What did help was increasing join_collapse_limit and from_collapse_limit

RHEL 8.0 build

2018-11-24 Thread Jeremy Harris
Hi, Trying to set up a buildfarm animal on a RHEL 8.0 (beta) system, the build fails early: $ ./run_build.pl --nosend --nostatus --verbose Sat Nov 24 20:09:28 2018: buildfarm run for CHANGEME:HEAD starting CHANGEME:HEAD [20:09:28] checking out source ... CHANGEME:HEAD [20:09:33

Re: jsonpath

2018-11-24 Thread Tomas Vondra
Hi, I've done another round of reviews on v20, assuming the patch is almost ready to commit, but unfortunately I ran into a bunch of issues that need to be resolved. None of this is a huge issue, but it's also above the threshold of what could be tweaked by a committer IMHO. (Which brings the que

Re: [HACKERS] pgbench - allow to store select results into variables

2018-11-24 Thread Fabien COELHO
FWIW I think the terminology in this patch is wrong. You use the term "compound" to mean "one query within a string containing multiple queries", but that's not what compound means. Compound is the whole thing, comprised of the multiple queries. Indeed. Compounded query? Maybe "query" is

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)

2018-11-24 Thread Fabien COELHO
Unfortunately, there was no activity over the last few commitfests and the proposed patch pgbench-tap-progress-6 can't be applied anymore without conflicts. Fabien, what are your plans about it, could you please post a rebased version? Here it is. -- Fabien.diff --git a/src/bin/pgbench/pgbenc

Don't wake up to check trigger file if none is configured

2018-11-24 Thread Jeff Janes
A streaming replica waiting on WAL from the master will wake up every 5 seconds to check for a trigger file. This is pointless if no trigger file has been configured. The attached patch suppresses the timeout when there is no trigger file configured. A minor thing to be sure, but there was a cam

Re: Centralize use of PG_INTXX_MIN/MAX for integer limits

2018-11-24 Thread Tom Lane
Michael Paquier writes: > A couple of years ago, 62e2a8dc has introduced in c.h a set of limits > (to fix some portability issues from 83ff1618) to make the code more > system-independent. Those are for example PG_INT32_MIN, etc. The core > code now mixes the internal PG_ limits with the system

Re: [HACKERS] pgbench - allow to store select results into variables

2018-11-24 Thread Alvaro Herrera
FWIW I think the terminology in this patch is wrong. You use the term "compound" to mean "one query within a string containing multiple queries", but that's not what compound means. Compound is the whole thing, comprised of the multiple queries. Maybe "query" is the right word to use there, not

Re: Copy function for logical replication slots

2018-11-24 Thread Petr Jelinek
Hi, On 31/08/2018 07:03, Masahiko Sawada wrote: > > Attached a new version patch incorporated the all comments I got. > This looks pretty reasonable. I am personally not big fan of the C wrappers for overloaded functions, but that's what we need to do for opr_sanity to pass so I guess we'll ha

Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.

2018-11-24 Thread Christoph Berg
Re: Thomas Munro 2018-11-23 > Add WL_EXIT_ON_PM_DEATH pseudo-event. I think this broke something: TRAP: FailedAssertion(»!(!IsUnderPostmaster || (wakeEvents & (1 << 5)) || (wakeEvents & (1 << 4)))«, Datei: »/build/postgresql-12-JElZNq/postgresql-12-12~~devel~20181124.1158/build/../src/backend/

Re: could not connect to server, in order to operate pgAdmin/PostgreSQL

2018-11-24 Thread Malik Rumi
1. What is your operating system? It looks like Windows, but I'm not sure. Also what version number for the OS? 2. Look in the url. You are at 127.0.0.1. That is the same as localhost. But then it says 49194. Postgres uses 5432 by default. That's why you got that part of the error message, but we n

Re: [HACKERS] Block level parallel vacuum

2018-11-24 Thread Amit Kapila
On Tue, Oct 30, 2018 at 2:04 PM Masahiko Sawada wrote: > > Attached rebased version patch to the current HEAD. > > > Please apply this patch with the extension lock patch[1] when testing > > as this patch can try to extend visibility map pages concurrently. > > > > Because the patch leads performa

Centralize use of PG_INTXX_MIN/MAX for integer limits

2018-11-24 Thread Michael Paquier
Hi all, A couple of years ago, 62e2a8dc has introduced in c.h a set of limits (to fix some portability issues from 83ff1618) to make the code more system-independent. Those are for example PG_INT32_MIN, etc. The core code now mixes the internal PG_ limits with the system ones. Would we want to

Re: 64-bit hash function for hstore and citext data type

2018-11-24 Thread Andrew Gierth
> "Tom" == Tom Lane writes: >>> I'm inclined to fix this in hstoreUpgrade rather than complicate >>> hstore_hash with historical trivia. Also there have been no field >>> complaints - I guess it's unlikely that there is much pg 8.4 hstore >>> data in the wild that anyone wants to hash.

Re: FETCH FIRST clause WITH TIES option

2018-11-24 Thread Surafel Temesgen
Attach is rebased patch against the current master regards Surafel On Thu, Nov 1, 2018 at 2:28 PM Surafel Temesgen wrote: > hi, > > The attached patch include all the comment given by Tomas and i check sql > standard about LIMIT and this feature > > it did not say anything about it but I think i

Re: COPY FROM WHEN condition

2018-11-24 Thread Dean Rasheed
On Sat, 24 Nov 2018 at 02:09, Tomas Vondra wrote: > On 11/23/18 12:14 PM, Surafel Temesgen wrote: > > On Sun, Nov 11, 2018 at 11:59 PM Tomas Vondra > > mailto:tomas.von...@2ndquadrant.com>> wrote: > > So, what about using FILTER here? We already use it for aggregates when > > filtering row

Re: pgbench - doCustom cleanup

2018-11-24 Thread Fabien COELHO
Hello Alvaro, I just pushed this. I hope not to have upset you too much with the subroutine thing. Sorry for the feedback delay, my week was kind of overloaded… Thanks for the push. About the patch you committed, a post-commit review: - the state and function renamings are indeed a good