Re: Fix slot synchronization with two_phase decoding enabled

2025-04-27 Thread shveta malik
On Fri, Apr 25, 2025 at 5:53 PM Nisha Moond wrote: > > Please find the attached v8 patch with above comments addressed. > This version includes the documentation updates suggested by > Sawada-san at [1], and incorporates his feedback from [2] as well. > Thanks for the patches. 1) Regarding docu

Re: Cancel problems of query to pg_stat_statements

2025-04-27 Thread Andrey Borodin
> On 24 Apr 2025, at 22:49, Roman Khapov wrote: > > Hi! > Recently we faced a problem in out production psql installation, which was > that we had to cancel all requests to the db, including performance > monitoring requests, that uses ps_stat_statements. But we could not cancel > the requ

Re: using index to speedup add not null constraints to a table

2025-04-27 Thread jian he
On Fri, Apr 18, 2025 at 4:07 PM jian he wrote: > > I don't have any good ideas to do the regress tests. > I use > ereport(NOTICE, > errmsg("all not-null constraints on relation > \"%s\" are validated by index scan", > Relation

domain over virtual generated column

2025-04-27 Thread jian he
hi. I posted $subject at [1], but that thread is already committed, now post it in a separate thread, so CI will test it. While at it, I found some problem when the virtual generated column domain is with a NOT VALID check constraint. -- CREATE DOMAIN d1 AS int; CREATE TABLE t (a

Re: DOCS - create publication (tweak for generated columns)

2025-04-27 Thread Peter Smith
On Wed, Apr 23, 2025 at 10:33 AM David G. Johnston wrote: ... > In the column list I would stick to mentioning what cannot be specified, > since it would be assumed by default that any column on the table is fair > game. I believe that means not mentioning stored generated and instead > mentio

Re: Avoid circular header file dependency

2025-04-27 Thread Michael Paquier
On Sat, Apr 26, 2025 at 08:31:32AM +, Bertrand Drouvot wrote: > On Sat, Apr 26, 2025 at 04:42:56PM +0900, Michael Paquier wrote: >> Splitting the values >> of the wait classes into their own header makes sense, but the header >> name wait_class_constants.h sounds a bit off. Why not a simpler >

Re: RFC: Logging plan of the running query

2025-04-27 Thread Hannu Krosing
Have you also checked out https://github.com/postgrespro/pg_query_state which logs running query plan AND collected counts and timings as a response to a signal? Has this ever been discussed for inclusion in core ? On Thu, Apr 24, 2025 at 2:49 PM torikoshia wrote: > > Hi, > > Attached a rebased

Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment

2025-04-27 Thread Ilia Evdokimov
Sorry for the delayed reply. On 18.04.2025 00:29, David Rowley wrote: I know I did suggest that the hit_ratio should be a percent and it should be multiplied by 100.0. This seems fine for the text format as you can have the % unit there. However, looking at ExplainPropertyFloat(), we don't pri

Re: Avoid circular header file dependency

2025-04-27 Thread Tom Lane
Bertrand Drouvot writes: > On Sat, Apr 26, 2025 at 02:55:51PM -0400, Tom Lane wrote: >> I think the actual problem is that plpython.h >> does this: >> >> /* >> * Used throughout, so it's easier to just include it everywhere. >> */ >> #include "plpy_util.h" > Agree. >> which is exactly the sort

Re: optimize file transfer in pg_upgrade

2025-04-27 Thread Alexander Lakhin
Hello Nathan, 20.03.2025 04:02, Nathan Bossart wrote: On Wed, Mar 19, 2025 at 04:28:23PM -0500, Nathan Bossart wrote: And here is yet another new version of the full patch set. I'm planning to commit 0001 (the new pg_upgrade transfer mode test) tomorrow so that I can deal with any buildfarm ind

Re: Some problems regarding the self-join elimination code

2025-04-27 Thread Alexander Korotkov
On Fri, Apr 11, 2025 at 5:46 PM Andrei Lepikhov wrote: > On 4/10/25 14:39, Andrei Lepikhov wrote: > > On 4/10/25 13:36, Alexander Korotkov wrote: > >> On Wed, Apr 9, 2025 at 10:39 AM Andrei Lepikhov > >> wrote: > >>> It seems we are coming to the conclusion that join removal optimisation > >>> ma

Re: Avoid circular header file dependency

2025-04-27 Thread Bertrand Drouvot
Hi, On Sat, Apr 26, 2025 at 02:55:51PM -0400, Tom Lane wrote: > Bertrand Drouvot writes: > > On Sat, Apr 26, 2025 at 01:20:56AM -0400, Tom Lane wrote: > >> Whatever it contains, we need to kill it with fire before the problem > >> metastasizes like it did the last time. (yeah, yeah, badly mixed

RE: Fix premature xmin advancement during fast forward decoding

2025-04-27 Thread Zhijie Hou (Fujitsu)
On Sun, Apr 27, 2025 at 2:07 PM Masahiko Sawada wrote: > > On Sat, Apr 26, 2025 at 5:01 AM Amit Kapila > wrote: > > > > On Sat, Apr 26, 2025 at 12:01 AM Masahiko Sawada > wrote: > > > > > > On Fri, Apr 25, 2025 at 4:42 AM Amit Kapila > wrote: > > > > > > > > Can you think of any better ideas? >