Hi,
Thank you for looking into this!
On Mon, 24 Nov 2025 at 09:51, 邱宇航 wrote:
>
> I suggest using a conditional lock on the buffer, which would be more
> appropriate here.
Could you please explain that a bit more? AFAIU, conditional locks are
mainly used to escape from deadlock situations and w
Hi,
On Mon, 24 Nov 2025 at 08:46, Michael Paquier wrote:
>
> On Fri, Aug 08, 2025 at 01:16:57PM +0300, Nazir Bilal Yavuz wrote:
> > Thank you for looking into this! And sorry for the late reply.
>
> Could you rebase, please? This has not applied for some time, but
> I've made the situation worse
On Fri, Nov 21, 2025 at 5:55 PM Peter Smith wrote:
>
> Hi Shlok.
>
> Here are some review comments for your patch v28-0003 (EXCEPT TABLE ...).
>
> The review of this patch is a WIP. In this post I only looked at the test
> code.
>
Here are my remaining review comments for patch v28-0003 (EXCEPT
Hi!
Partial hash index is not used if qual is an implied qual
since this qual is not added to indrestrictinfo and we cannot
get the keys needed to make hash index scan possible.
Suggested fix is to add implied qual for the indexes
which requires the presence of a key to scan the index.
How to re
Hi!
It seems my previous email was sent only to Andrey directly and didn't pass
moderation
because it had a patch attached. I've now resent it from another email address.
In GetNewMultiXactId() this code may lead to error
---
ExtendMultiXactOffset(MultiXactState->nextMXact + 1);
---
If Mul
I suggest using a conditional lock on the buffer, which would be more
appropriate here. Additionally, the function should return whether
the buffer is marked as dirty, the number of buffers marked as dirty.
This change would also make pg_buffercache_mark_dirty_{relation, all}
behave more consisten
Hi Chao,
>> On Nov 21, 2025, at 13:25, Chao Li wrote:
>>
>>
>> Okay, I’d stop here and continue to review 0006 next week.
>>
>
> I just finished reviewing 0006, and see some problems:
>
> 15 - 0006 - select.sgml
> ```
> +[ row_pattern_common_syntax ]
> ```
>
> row_pattern_common_syntax does
On Fri, Nov 21, 2025 at 8:10 PM shveta malik wrote:
>
> On Fri, Nov 21, 2025 at 9:14 AM Ajin Cherian wrote:
> >
> >
> > Attaching patch v24, addressing the above comments.
> >
>
> Thanks for the patch. Please find a few comments:
>
>
> 1)
> Instead of passing an argument to slotsync_reread_config
On Thu, Nov 20, 2025 at 5:38 PM Dilip Kumar wrote:
>
I was working on these pending items, there is something where I got
stuck, I am exploring this more but would like to share the problem.
> 2) Need to add replica identity tuple instead of full tuple - reported by
> Shveta
I have worked on fix
On Mon, Nov 24, 2025 at 1:00 PM Ashutosh Bapat
wrote:
>
> Hi Junwang,
>
> On Mon, Nov 24, 2025 at 8:01 AM Junwang Zhao wrote:
> >
> > Hi Ashutosh,
> >
> > On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat
> > wrote:
> > >
> > > Hi Junwang,
> > >
> > > On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao
On Fri, Nov 21, 2025, 00:47 Fujii Masao wrote:
> On Thu, Nov 20, 2025 at 3:54 PM Chao Li wrote:
> > Before this patch, all user specified options are silently discarded,
>
> The GUC settings in CREATE SUBSCRIPTION were honored up through v14;
> the behavior changed in commit f3d4019da5d, so some
On Fri, Nov 21, 2025 at 6:21 PM Shlok Kyal wrote:
>
> The Cbot complained that it was not able to build the docs. I have
> fixed it and attached the latest patch.
>
Few comments on 001:
1)
In pgstat_report_replslotsync_skip(), shall we have a sanity check to
ensure that slot is logical and funct
On Fri, Nov 21, 2025 at 6:21 PM Shlok Kyal wrote:
>
> The Cbot complained that it was not able to build the docs. I have
> fixed it and attached the latest patch.
>
Few comments on 0001:
1.
+
+slotsync_last_skip_attimestamp
with time zone
+
+
+Time at which las
On Fri, Aug 08, 2025 at 01:16:57PM +0300, Nazir Bilal Yavuz wrote:
> Thank you for looking into this! And sorry for the late reply.
Could you rebase, please? This has not applied for some time, but
I've made the situation worse with 4b203d499c61. No need to bump
again the module for this release
On Sun, Nov 23, 2025 at 09:15:31AM +, Bertrand Drouvot wrote:
> Attached a rebase due to 7d9043aee80. Also 0003 has a minor change (as
> compared
> to v8-0004) to avoid this error when creating the 1.6 version with the new
> code:
Yes, sorry, I forgot to mention that part. I have played wit
Hi Junwang,
On Mon, Nov 24, 2025 at 8:01 AM Junwang Zhao wrote:
>
> Hi Ashutosh,
>
> On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat
> wrote:
> >
> > Hi Junwang,
> >
> > On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao wrote:
> > >
> > >
> > > I have some review comments, and hope some of them are
Hi Chao,
Thank you for the review!
>> On Nov 20, 2025, at 15:33, Chao Li wrote:
>>
>>
>> I’d stop here, and continue 0005 tomorrow.
>>
>
> I reviewed 0005 today. I'm still not very familiar with the executor code, so
> going through 0005 has also been a valuable learning process for me.
>
> > It just occurred to me that the documentation [0] should be
> > updated to describe the callbacks. I will do that in the next
> > revision.
> >
> > [0]
> > https://www.postgresql.org/docs/current/xfunc-c.html#XFUNC-ADDIN-CUSTOM-CUMULATIVE-STATISTICS
>
> Hmm. Based on what I can read from the
On Tue, Sep 16, 2025 at 3:03 PM Amit Kapila wrote:
>
> On Sat, Sep 6, 2025 at 10:33 AM Dilip Kumar wrote:
> > I suspect this might not be the most performant default strategy and
> > could frequently cause a performance dip. In general, we utilize
> > parallel apply workers, considering that the
On Mon, 24 Nov 2025 at 14:57, Junwang Zhao wrote:
>
> On Mon, Nov 24, 2025 at 6:52 AM David Rowley wrote:
> >
> > On Sun, 23 Nov 2025 at 01:44, Junwang Zhao wrote:
> > Thanks. I agree with the patch. We should probably mention
> > canreturn[] too. I can take care of this.
>
> Agreed. Thanks for
> On Nov 22, 2025, at 22:14, Fujii Masao wrote:
>
> On Sat, Nov 22, 2025 at 10:31 AM Chao Li wrote:
>>
>>
>>
>>> On Nov 22, 2025, at 00:14, Fujii Masao wrote:
>>>
>>> On Fri, Nov 21, 2025 at 6:24 PM Chao Li wrote:
No, what I was thinking is that, we could combine the three set stat
On Fri, Nov 21, 2025 at 2:11 PM jian he wrote:
>
> On Mon, Nov 17, 2025 at 9:43 PM Amul Sul wrote:
> >
> > 10-0004:
> >
> > +/* error safe version of textToQualifiedNameList */
> > +List *
> > +textToQualifiedNameListSafe(text *textval, Node *escontext)
> >
> > If I am not mistaken, it looks like
Hi, Amit,
Locking only surviving partitions sounds a good optimization. I started to
review this patch, but I cannot finish reviewing in one day. I will post my
comments as long as I finished some commits.
> On Nov 20, 2025, at 15:30, Amit Langote wrote:
>
>
0001 splits creations of es_par
Hi,
I attach a small patch for this.
Looking forward to your review.
--
Regards,
ChangAo Chen
v1-0001-Use-ROLERECURSE_PRIVS-in-is_admin_of_role.patch
Description: Binary data
Hi Ashutosh,
On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat
wrote:
>
> Hi Junwang,
>
> On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao wrote:
> >
> >
> > I have some review comments, and hope some of them are helpful.
> >
> > 1.
> >
> > doc/src/sgml/ddl.sgml
> >
> > +
> > +CREATE PROPERTY GRAPH my
On Mon, Nov 24, 2025 at 6:52 AM David Rowley wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> On Nov 21, 2025, at 13:25, Chao Li wrote:
>
>
> Okay, I’d stop here and continue to review 0006 next week.
>
I just finished reviewing 0006, and see some problems:
15 - 0006 - select.sgml
```
+[ row_pattern_common_syntax ]
```
row_pattern_common_syntax doesn’t look like a good name. I s
On Wed, Nov 19, 2025 at 08:10:43PM -0600, Sami Imseih wrote:
> It just occurred to me that the documentation [0] should be
> updated to describe the callbacks. I will do that in the next
> revision.
>
> [0]
> https://www.postgresql.org/docs/current/xfunc-c.html#XFUNC-ADDIN-CUSTOM-CUMULATIVE-STATI
On Fri, Nov 21, 2025 at 6:31 PM Andres Freund wrote:
> On 2025-11-21 18:14:56 -0500, Peter Geoghegan wrote:
> > On Fri, Nov 21, 2025 at 5:38 PM Andres Freund wrote:
> > > Another benfit is that it helps even more when there multiple queries
> > > running
> > > concurrently - the high rate of loc
Since this thread discussed possibly bringing back Cygwin buildfarm
coverage, you might be interested in this proposed change:
https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BBpW%3DKhGHTWGMe0cSETMYZsSygv5jFWD1Y6wcbAn2ecQ%40mail.gmail.com#dad6afc6b54306c6f2a47f7a31f0bb24
On Sun, Nov 23, 2025 at 01:14:37PM +0100, Alvaro Herrera wrote:
> Yes, exactly that ... but can this be used by the SQL injection points
> functionality? The test is an isolation .spec file, and I didn't find a
> way to say "make me sleep when I hit this injection point, but only if
> conflict is
Hi,
Andres pointed out this possible optimization on Discord so I hacked up
a quick patch which avoids taking a lock when reading the LSN from a
page on architectures where we can be sure to not get a torn value. It
is always nice to remove a lock from a reasonably hot code path.
I thought a
On Sun, Nov 23, 2025 at 4:25 PM Tom Lane wrote:
> Thomas Munro writes:
> > That'd leave only Cygwin with HAVE BUGGY_STRTOF. Perhaps they have
> > fixed their implementation[1]? Here's an experimental patch to drop
> > all remnants, which could be used to find out. No Windows/Cygwin
> > here.
On Sun, 23 Nov 2025 at 01:44, Junwang Zhao wrote:
> Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> struct comments fail to express this, it says:
>
> indexkeys[], indexcollations[] each have ncolumns entries.
>
> So we should polish this description. trivial patch attached.
T
On Nov 23 2025, at 4:08 pm, Thomas Munro wrote:
> On Mon, Nov 24, 2025 at 4:23 AM Greg Burd wrote:
>> As mentioned on a separate thread about fixing ARM64 support when
>> building with MSVC on Win11 [1] I tried out this patch. The reply on
>> that thread had an issue with _mm_pause() in spin_
On Mon, Nov 24, 2025 at 4:23 AM Greg Burd wrote:
> As mentioned on a separate thread about fixing ARM64 support when building
> with MSVC on Win11 [1] I tried out this patch. The reply on that thread had
> an issue with _mm_pause() in spin_delay(), it turns out we need to use
> __yield() [2].
On Sun, Nov 23, 2025, at 16:49, Joel Jacobson wrote:
> On Sat, Nov 22, 2025, at 22:30, Joel Jacobson wrote:
>> On Thu, Nov 20, 2025, at 21:26, Tom Lane wrote:
>>> I took a brief look through the v28 patch, and I'm fairly distressed
>>> at how much new logic has been stuffed into what's effectively
On Nov 23 2025, at 3:32 pm, Thomas Munro wrote:
> On Mon, Nov 24, 2025 at 4:55 AM Andres Freund wrote:
>> > - if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and
>> __crc32cd without -march=armv8-a+crc',
>> > + if cc.get_id() == 'msvc'
>> > +cdata.set('USE_ARMV8_CRC32C', 1)
>>
On Nov 23 2025, at 10:55 am, Andres Freund wrote:
> Hi,
>
> On 2025-11-22 16:43:30 -0500, Greg Burd wrote:
>> With the new MSVC compiler flag Andres mentioned (/arch:armv9.4) I only
>> had to update the S_UNLOCK() macro, the compiler did the rest correctly
>> AFAICT.
>
> Just to be clear - th
On Mon, Nov 24, 2025 at 4:55 AM Andres Freund wrote:
> > - if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd
> > without -march=armv8-a+crc',
> > + if cc.get_id() == 'msvc'
> > +cdata.set('USE_ARMV8_CRC32C', 1)
> > +have_optimized_crc = true
>
> Should have a comme
Jim Jones writes:
> v8 attached.
Pushed with some more editing; for instance there were a bunch
of comments still oriented toward throwing an error. I also
still thought the tests were pretty duplicative.
One note is that I took out
+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
an
On Mon, Nov 24, 2025 at 6:02 AM Tom Lane wrote:
> "Greg Burd" writes:
> > I have another Illumos animal in the works, but if the plan is to deprecate
> > that platform I can set that aside. As an old Sun engineer I hate to see
> > it disappear, but it is basically EOL at this point.
>
> I thin
> On 22 Nov 2025, at 14:00, Álvaro Herrera wrote:
>
> On 2025-Nov-21, Daniel Gustafsson wrote:
>
>> The attached v2 adds a GUC debug_exec_backend which can be used to get the
>> state of the running cluster,
>
> Nice idea.
>
> I think the parallel to debug_assertions is not perfect, because yo
> On 22 Nov 2025, at 10:30, Chao Li wrote:
> I just reviewed the patch and got a few comments.
Thanks! An updated version will come downthread.
> The GUC is added like a mirror of debug_assertions. However, I think a small
> difference is that, assertions will impact everything at runtime, whi
On 2025-Nov-23, Tom Lane wrote:
> "Greg Burd" writes:
> > I have another Illumos animal in the works, but if the plan is to deprecate
> > that platform I can set that aside. As an old Sun engineer I hate to see
> > it disappear, but it is basically EOL at this point.
>
> I think we can keep i
"Greg Burd" writes:
> I have another Illumos animal in the works, but if the plan is to deprecate
> that platform I can set that aside. As an old Sun engineer I hate to see it
> disappear, but it is basically EOL at this point.
I think we can keep it going as long as there are people intereste
Hi,
On 2025-11-22 16:43:30 -0500, Greg Burd wrote:
> With the new MSVC compiler flag Andres mentioned (/arch:armv9.4) I only
> had to update the S_UNLOCK() macro, the compiler did the rest correctly
> AFAICT.
Just to be clear - the flag shouldn't be necessary for things to work
correctly. I was o
On Sat, Nov 22, 2025, at 22:30, Joel Jacobson wrote:
> On Thu, Nov 20, 2025, at 21:26, Tom Lane wrote:
>> I took a brief look through the v28 patch, and I'm fairly distressed
>> at how much new logic has been stuffed into what's effectively a
>> critical section. It's totally not okay for AtCommit
On Mon, Nov 10, 2025, at 8:17 AM, Thomas Munro wrote:
> Hi,
>
> Here is an experimental patch to try out standard C (and C++) atomics
> to implement port/atomics.h, and also add more types and operations.
> It's mostly just redirecting our names to the standard ones, except
> for our barriers and
On Mon, Nov 10, 2025, at 10:19 AM, Tom Lane wrote:
> Heikki Linnakangas writes:
>> The patch removes 'src/template/solaris'. Is that on purpose? Is that an
>> independent cleanup that could be committed immediately?
>
> Our four Solaris+illumos buildfarm animals would be sad.
>
>
Hi,
On Sun, Nov 23, 2025 at 5:51 AM Sami Imseih wrote:
>
> > > nworkers has a double meaning. The return value of
> > > AutoVacuumReserveParallelWorkers
> > > is nreserved. I think this should be
> > >
> > > ```
> > > nreserved = AutoVacuumReserveParallelWorkers(nworkers);
> > > ```
> > >
> > > a
On 11/21/25 21:47, Bruce Momjian wrote:
> On Fri, Nov 21, 2025 at 03:14:15PM -0500, Tom Lane wrote:
>> I spent a little time staring at the v5 patches. Obviously there
>> are a bunch of minor details to be verified, which you've carefully
>> provided XXX comments about, and I didn't really go thro
Hi hackers,
This patch addresses this comment in async.c's SignalBackends:
* XXX in principle these pallocs could fail, which would be bad.
* Maybe preallocate the arrays? They're not that large, though.
This is unsafe, since AtCommit_Notify effectively runs in a critical
section, so an
On Thu, Nov 20, 2025 at 4:05 PM Andrey Silitskiy
wrote:
>
> On Wed, Nov 19, 2025 at 8:46 PM Fujii Masao
> wrote:
> > How about using PGC_USERSET instead of PGC_SIGHUP, similar to
> > wal_sender_timeout?
>
> Dear Fujii, thanks for the review!
>
> Current version of the patch suggests changing th
On 11/21/25 21:14, Tom Lane wrote:
> I spent a little time staring at the v5 patches. Obviously there
> are a bunch of minor details to be verified, which you've carefully
> provided XXX comments about, and I didn't really go through those
> yet. There are two big-picture questions that are bo
On Fri, Nov 21, 2025 at 3:33 PM Fujii Masao wrote:
>
> On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa wrote:
> >
> > > Should we suggest "MERGE INTO" instead of just "MERGE",
> > > since INTO always follows MERGE?
> > >
> > > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > > simila
On Thu, Nov 20, 2025, at 7:08 PM, Thomas Munro wrote:
> If you have an environment set up so it's easy to test, I would also
> be very interested to know if my patch set[3] that nukes all this
> stuff and includes instead, which is green on
> Windows/x86 CI, will just work™ there too.
>
> [3]
>
Amit Langote 于2025年11月20日周四 15:30写道：
> On Mon, Nov 17, 2025 at 9:50 PM Amit Langote
> wrote:
> > On Wed, Nov 12, 2025 at 11:17 PM Amit Langote
> wrote:
> > > * Enable pruning-aware locking in cached / generic plan reuse (0004):
> > > extends GetCachedPlan() and CheckCachedPlan() to call Executo
On 2025-Nov-23, Michael Paquier wrote:
> On Sat, Nov 22, 2025 at 03:16:44PM +0100, Alvaro Herrera wrote:
> > ExecDropSingleTupleTableSlot(existing_slot);
> > + INJECTION_POINT("check-exclusion-or-unique-constraint-no-conflict",
> > &conflict);
> >
> > However, I don't see that the
Hello,
On Sat, Nov 22, 2025 at 4:43 AM Nikolay Samokhvalov wrote:
> Hi hi
>
> Many tools that implement wait event analysis, when visualizing samples
> with "wait_event is null" use green color and "CPU" (perhaps, it started
> with RDS Performance Insights and PASH Viewer and, I suppose, origina
On Sun, Nov 23, 2025 at 1:51 PM Christoph Berg wrote:
> Re: Darafei "Komяpa" Praliaskouski
> > For the sake of simpler dictation over voice media when debugging over
> > phone can we please have no underscore in the command, it adds an extra
> > word to say.
>
> Simpler as in "oh no extra undersc
On Sun, 23 Nov 2025 at 07:35, Robert Haas wrote:
>
> On Sat, Nov 22, 2025 at 12:28 PM Sami Imseih wrote:
> > What I have not been able to prove from my tests is that the processing
> > order of tables by autovacuum will actually make things any better or any
> > worse. My tests have been short 30
Re: Darafei "Komяpa" Praliaskouski
> For the sake of simpler dictation over voice media when debugging over
> phone can we please have no underscore in the command, it adds an extra
> word to say.
Simpler as in "oh no extra underscore after pg in this one, all the
other commands like pg_ctl, pg_ba
On Fri, Nov 21, 2025 at 4:42 AM Andreas Karlsson wrote:
> On 11/20/25 10:31 AM, Christoph Berg wrote:
> > Re: Andreas Karlsson
> >>> Perhaps pg_util? ("pg" is taken by that classic pager thingy.)
> >>
> >> I like the name pg_util. In the MySQL world it is called mysqladmin,
> which
> >> is a does
Hi,
On Fri, Nov 21, 2025 at 11:53:52AM +, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Nov 20, 2025 at 04:59:07PM +, Bertrand Drouvot wrote:
> > On Wed, Nov 19, 2025 at 10:49:49PM +0900, Michael Paquier wrote:
> > >
> > > Hmm. I can think about an option 3 here: pg_buffercache outlines the
Hi Haiyang,
> v6-0004 only skip the transaction commited during START state and precedeing
> next_phase_at
> (set when changing to BUILDING_SNAPSHOT state) during BUILDING_SNAPSHOT.
> Those transactions
> are always useless no matter in fast forward or not. Plaese recheck v6-0004
> again.
Yeah
66 matches
Mail list logo
