Hi Chao-san,
Thank you very much for your testing and review!
> 1. Major concern: In this patch, you only increase
vacrel->total_dead_items_bytes in dead_items_reset(), however,
dead_items_reset() is not always called, that way I often see usage is 0.
We should also increate the counter in heap_
Hi Tatsuya-san,
I just reviewed and tested v6, and got a major concern and a few small comments.
> On Nov 27, 2025, at 22:59, 河田達也 wrote:
>
> Hi Sawada-san,
> I rebased and applied the changes you suggested.
> The updated v6 is attached.
> Best regards,
> Tatsuya Kawata
>
1. Major concern: In
Hi Sawada-san,
I rebased and applied the changes you suggested.
The updated v6 is attached.
Best regards,
Tatsuya Kawata
>
v6-0001-Add-memory-usage-reporting-to-VACUUM-VERBOSE.patch
Description: Binary data
Hi Sawada-san,
Thank you very much for reviewing v5 patch!
I have reviewed the changes you made, and everything looks good to me.
Your revisions, especially the cleanup of redundant comments and the
improved
wording, make the patch clearer and more consistent with the existing
codebase.
Thank yo
On Fri, Nov 21, 2025 at 8:26 AM 河田達也 wrote:
>
> Hi Sawada-san,
>
> Thank you for your additional feedback on v4!
>
> >We can initialize dead_items_max_bytes when declared.
> Thank you. I fixed it as you mentioned.
>
> >Does it need to check if vacrel->dead_items is non-NULL?
> Thank you. I fixed i
Hi Sawada-san,
Thank you for your additional feedback on v4!
>We can initialize dead_items_max_bytes when declared.
Thank you. I fixed it as you mentioned.
>Does it need to check if vacrel->dead_items is non-NULL?
Thank you. I fixed it as you mentioned.
>I think we should not use "index scans"
On Thu, Nov 20, 2025 at 6:16 AM 河田達也 wrote:
>
> Hi Sawada-san, Chao-san,
>
> Thank you very much for your helpful feedback and testing.
>
> > We can use vacrel->dead_items_info->max_bytes instead of calculating it
> > again.
> I fixed it as you mentioned.
>
>
> > I meant (1) actually. I don't thi
Hi Sawada-san, Chao-san,
Thank you very much for your helpful feedback and testing.
> We can use vacrel->dead_items_info->max_bytes instead of calculating it
again.
I fixed it as you mentioned.
> I meant (1) actually. I don't think the number of indexes attached to
> the target relation is not
Hi Tatsuya,
I just ran a test against v3.
> On Nov 20, 2025, at 01:30, 河田達也 wrote:
>
>
> I also removed the unintended blank lines and ran pgindent as you suggested.
> I appreciate your continued feedback, and I would be grateful for another
> review of the v3 patch.
>
> Best regards,
> Tats
On Wed, Nov 19, 2025 at 9:31 AM 河田達也 wrote:
>
> Hi Sawada-san,
>
> Thank you very much for your detailed review and suggestions for the v2 patch.
> Also, thank you for pointing out the top-posting issue. I'll follow the
> mailing list style from now on.
+1
>
> ---
> >+ /* Report memor
Hi Sawada-san,
Thank you very much for your detailed review and suggestions for the v2
patch.
Also, thank you for pointing out the top-posting issue. I'll follow the
mailing list style from now on.
---
>+ /* Report memory usage for dead_items tracking */
>+ vac_work_mem = AmAu
(please avoid top-posting[1] on this mailing list)
On Tue, Nov 18, 2025 at 7:15 AM 河田達也 wrote:
>
> Hi Sawada-san,
>
> Thank you very much for your review and helpful comments on my previous patch.
> I have revised the patch following your suggestions:
>
> ・Report total memory usage rather than pe
Hi Sawada-san,
Thank you very much for your review and helpful comments on my previous
patch.
I have revised the patch following your suggestions:
・Report total memory usage rather than peak memory, which is more
meaningful for users.
・Removed the reset counter, since index scan counts already re
Hi,
On Sun, Nov 16, 2025 at 8:01 AM 河田達也 wrote:
>
> Hi,
>
> I would like to propose a patch that adds memory usage reporting to
> VACUUM VERBOSE output. This helps users understand how much memory
> is being used for dead tuple tracking and whether memory limits are
> being hit during vacuum oper
Hi,
I would like to propose a patch that adds memory usage reporting to
VACUUM VERBOSE output. This helps users understand how much memory
is being used for dead tuple tracking and whether memory limits are
being hit during vacuum operations.
I have tested this patch with both serial and paralle
15 matches
Mail list logo
