Re: [PATCH] Support for basic ALTER TABLE progress reporting.

hi. within ATRewriteTable we have: pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS, RelationGetNumberOfBlocks(oldrel)); pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS, heapScan->rs_nblocks); PROGRESS_CLUSTER_TOTAL_HE

Re: [PATCH] Support for basic ALTER TABLE progress reporting.

Hi, thank you for the review! On Fri, Jun 6, 2025 at 10:37 AM jian he wrote: > On Mon, Jun 2, 2025 at 3:35 PM Jiří Kavalík wrote: > > What I changed: > > > > `commands/tablecmds.c` > > - start and end reporting inside `ATRewriteTables()` > > - report blocks total, blocks and tuples scanned and

Re: [PATCH] Support for basic ALTER TABLE progress reporting.

On Mon, Jun 2, 2025 at 3:35 PM Jiří Kavalík wrote: > What I changed: > > `commands/tablecmds.c` > - start and end reporting inside `ATRewriteTables()` > - report blocks total, blocks and tuples scanned and possibly tuples written > in `ATRewriteTable` > - add at least phase info in `validateForei

[PATCH] Support for basic ALTER TABLE progress reporting.

Hi, while testing int->bigint migrations for our db at work I really missed ALTER TABLE progress reporting and during the waits I checked the code. It seems to me that ALTERs can be mostly categorized as 1) trivial ones - metadata rewrites, fast adding/removing columns, trying to change column type