Re: 10% drop in code line count in PG 17

2025-11-22 Thread Bruce Momjian
On Fri, Nov 21, 2025 at 01:13:50PM +0100, Peter Eisentraut wrote: > On 21.11.25 01:49, Bruce Momjian wrote: > > Actually, another discussion would be why we have src/tools/codelines in > > the git tree at all. I added it in 2005 to use in counting code lines, > > and I thought we could consider it

Re: 10% drop in code line count in PG 17

2025-11-21 Thread Peter Eisentraut
On 21.11.25 01:49, Bruce Momjian wrote: Actually, another discussion would be why we have src/tools/codelines in the git tree at all. I added it in 2005 to use in counting code lines, and I thought we could consider it our standard method, but I am not sure anyone aside from me even uses it, and

Re: 10% drop in code line count in PG 17

2025-11-21 Thread Aleksander Alekseev
Hi Bruce, > Actually, another discussion would be why we have src/tools/codelines in > the git tree at all. I added it in 2005 to use in counting code lines, > and I thought we could consider it our standard method, but I am not > sure anyone aside from me even uses it, and it is clear there are

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Thu, Nov 20, 2025 at 03:30:15PM -0500, Bruce Momjian wrote: > On Thu, Nov 20, 2025 at 10:38:49AM +0100, Daniel Gustafsson wrote: > > > On 19 Nov 2025, at 20:59, Bruce Momjian wrote: > > > > > While working on a talk, I studied the number of code line changes in > > > each major release, > > >

Re: 10% drop in code line count in PG 17

2025-11-20 Thread David Rowley
On Fri, 21 Nov 2025 at 10:26, Bruce Momjian wrote: > > On Fri, Nov 21, 2025 at 10:16:56AM +1300, David Rowley wrote: > > I think you need to keep the "top of the Git tree" comment as git > > ls-files is context-based. > > Uh, the current file has this comment: Oh. I misread the patch. Mistakenly

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Fri, Nov 21, 2025 at 10:16:56AM +1300, David Rowley wrote: > On Fri, 21 Nov 2025 at 09:27, Bruce Momjian wrote: > > # This script is used to compute the total number of "C" lines in the > > release > > -# This should be run from the top of the Git tree after a 'make distclean' > > -find . -nam

Re: 10% drop in code line count in PG 17

2025-11-20 Thread David Rowley
On Fri, 21 Nov 2025 at 09:27, Bruce Momjian wrote: > # This script is used to compute the total number of "C" lines in the release > -# This should be run from the top of the Git tree after a 'make distclean' > -find . -name '*.[chyl]' | xargs cat| wc -l > +# This should be run from the top of the

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Daniel Gustafsson
> On 20 Nov 2025, at 21:30, Bruce Momjian wrote: > Yeah, that's part of a larger discussion. In an email I just sent I > suggested we are trying to count files that are part of a cluster > install, rather than testing files, but again, needs discussion. Right, but that was sort of my point, yo

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Thu, Nov 20, 2025 at 04:49:51PM +0300, Aleksander Alekseev wrote: > Hi, > > > > While working on a talk, I studied the number of code line changes in > > > each major release, and found PG 17 surprisingly reduced code line count > > > by 10%. To get the code line count, I used /pgtop/src/tools/

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Thu, Nov 20, 2025 at 10:38:49AM +0100, Daniel Gustafsson wrote: > > On 19 Nov 2025, at 20:59, Bruce Momjian wrote: > > > While working on a talk, I studied the number of code line changes in > > each major release, > > This script will only pick up C, but will pick up C in src/test but not an

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Thu, Nov 20, 2025 at 11:42:39AM +0100, Álvaro Herrera wrote: > On 2025-Nov-20, David Rowley wrote: > > > Maybe you'd be better with git ls-files if you only want just what's > > in the repo. Something like: > > > > for b in "REL8_0_0" "REL8_1_0" "REL8_2_0" "REL8_3_0" "REL8_4_0" > > "REL9_0_0"

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Bruce Momjian
On Thu, Nov 20, 2025 at 12:23:25PM +1300, David Rowley wrote: > On Thu, 20 Nov 2025 at 10:58, Bruce Momjian wrote: > > I think you are right. Attached is the difference between the output > > for 16 & 17. Let me do some more research and run all the versions > > again and report back, thanks. >

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Aleksander Alekseev
Hi, > > While working on a talk, I studied the number of code line changes in > > each major release, and found PG 17 surprisingly reduced code line count > > by 10%. To get the code line count, I used /pgtop/src/tools/codelines, > > which runs: > > [..] > Overall, there is a 4% increase according

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Aleksander Alekseev
Hi Bruce, > While working on a talk, I studied the number of code line changes in > each major release, and found PG 17 surprisingly reduced code line count > by 10%. To get the code line count, I used /pgtop/src/tools/codelines, > which runs: > > find . -name '*.[chyl]' | xargs cat| wc -l

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Álvaro Herrera
On 2025-Nov-20, David Rowley wrote: > Maybe you'd be better with git ls-files if you only want just what's > in the repo. Something like: > > for b in "REL8_0_0" "REL8_1_0" "REL8_2_0" "REL8_3_0" "REL8_4_0" > "REL9_0_0" "REL9_1_0" "REL9_2_0" "REL9_3_0" "REL9_4_0" "REL9_5_0" > "REL9_6_0" "REL_10_0"

Re: 10% drop in code line count in PG 17

2025-11-20 Thread Daniel Gustafsson
> On 19 Nov 2025, at 20:59, Bruce Momjian wrote: > While working on a talk, I studied the number of code line changes in > each major release, This script will only pick up C, but will pick up C in src/test but not any Perl code using the C modules in src/test etc. These days we also have C++ a

Re: 10% drop in code line count in PG 17

2025-11-19 Thread David Rowley
On Thu, 20 Nov 2025 at 10:58, Bruce Momjian wrote: > I think you are right. Attached is the difference between the output > for 16 & 17. Let me do some more research and run all the versions > again and report back, thanks. Maybe you'd be better with git ls-files if you only want just what's in

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Álvaro Herrera
On 2025-Nov-19, Tom Lane wrote: > > No, I just followed the shell comment I wrote above the 'find' command > > shown above: > > > # This script is used to compute the total number of "C" lines in the > > # release This should be run from the top of the Git tree after a 'make > > # dis

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
On Wed, Nov 19, 2025 at 04:22:37PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: > >> Also ... are you in fact counting only what is in git? Because > >> I get different answers: > > > No, I just followed the shell comment I wrote ab

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Tom Lane
Bruce Momjian writes: > On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: >> Also ... are you in fact counting only what is in git? Because >> I get different answers: > No, I just followed the shell comment I wrote above the 'find' command > shown above: > # This script is used t

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
On Wed, Nov 19, 2025 at 03:21:33PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > While working on a talk, I studied the number of code line changes in > > each major release, and found PG 17 surprisingly reduced code line count > > by 10%. To get the code line count, I used /pgtop/src/tools/c

Re: 10% drop in code line count in PG 17

2025-11-19 Thread Tom Lane
Bruce Momjian writes: > While working on a talk, I studied the number of code line changes in > each major release, and found PG 17 surprisingly reduced code line count > by 10%. To get the code line count, I used /pgtop/src/tools/codelines, > which runs: > find . -name '*.[chyl]' | xargs c

10% drop in code line count in PG 17

2025-11-19 Thread Bruce Momjian
While working on a talk, I studied the number of code line changes in each major release, and found PG 17 surprisingly reduced code line count by 10%. To get the code line count, I used /pgtop/src/tools/codelines, which runs: find . -name '*.[chyl]' | xargs cat| wc -l Any ideas on the cau