Re: Explicitly enable meson features in CI

2025-07-17 Thread Nazir Bilal Yavuz
Hi, On Wed, 16 Jul 2025 at 18:24, Jacob Champion wrote: > > On Wed, Jul 16, 2025 at 4:12 AM Nazir Bilal Yavuz wrote: > > > For me it looks like 'Meson Auto' can be confused with 'Autoconf'. We > > > can rename it as a 'Meson Auto Feature Detection' but that is a bit > > > longer. Do you have any

Re: Explicitly enable meson features in CI

2025-07-17 Thread Nazir Bilal Yavuz
Hi, On Wed, 16 Jul 2025 at 19:02, Andres Freund wrote: > > Hi, > > On 2025-07-16 14:12:22 +0300, Nazir Bilal Yavuz wrote: > > On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz wrote: > > > On Thu, 10 Jul 2025 at 20:12, Jacob Champion > > > wrote: > > > > > > > > On Thu, Jul 10, 2025 at 2:59 AM Na

Re: Explicitly enable meson features in CI

2025-07-16 Thread Andres Freund
Hi, On 2025-07-16 14:12:22 +0300, Nazir Bilal Yavuz wrote: > On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz wrote: > > On Thu, 10 Jul 2025 at 20:12, Jacob Champion > > wrote: > > > > > > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz > > > wrote: > > > > Andres off-list mentioned that if w

Re: Explicitly enable meson features in CI

2025-07-16 Thread Jacob Champion
On Wed, Jul 16, 2025 at 4:12 AM Nazir Bilal Yavuz wrote: > > For me it looks like 'Meson Auto' can be confused with 'Autoconf'. We > > can rename it as a 'Meson Auto Feature Detection' but that is a bit > > longer. Do you have any ideas? If you think 'Meson Auto' is good > > enough, we can continu

Re: Explicitly enable meson features in CI

2025-07-16 Thread Nazir Bilal Yavuz
Hi, On Fri, 11 Jul 2025 at 14:00, Nazir Bilal Yavuz wrote: > > Hi, > > On Thu, 10 Jul 2025 at 20:12, Jacob Champion > wrote: > > > > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz > > wrote: > > > Andres off-list mentioned that if we explicitly enable features for > > > *all* of the tasks,

Re: Explicitly enable meson features in CI

2025-07-11 Thread Nazir Bilal Yavuz
Hi, On Thu, 10 Jul 2025 at 20:12, Jacob Champion wrote: > > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz wrote: > > Andres off-list mentioned that if we explicitly enable features for > > *all* of the tasks, then none of the tasks will be testing the auto > > feature option and I agree with

Re: Explicitly enable meson features in CI

2025-07-10 Thread Daniel Gustafsson
> On 10 Jul 2025, at 19:12, Jacob Champion > wrote: > On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz wrote: >> so it would be easier to catch if >> one of the features is disabled without anyone noticing. > > Seems reasonable. Agreed. > If we do this, can we rename the job with a "- Meson

Re: Explicitly enable meson features in CI

2025-07-10 Thread Jacob Champion
On Thu, Jul 10, 2025 at 2:59 AM Nazir Bilal Yavuz wrote: > Andres off-list mentioned that if we explicitly enable features for > *all* of the tasks, then none of the tasks will be testing the auto > feature option and I agree with Andres. My suggestion is setting > features to auto for Debian - Me

Re: Explicitly enable meson features in CI

2025-07-10 Thread Nazir Bilal Yavuz
Hi, On Tue, 8 Jul 2025 at 12:10, Nazir Bilal Yavuz wrote: > > Hi, > > On Wed, 2 Jul 2025 at 10:22, Nazir Bilal Yavuz wrote: > > > > Also, libcurl is disabled in the OpenBSD CI task until the fix in this > > thread [1] is committed. > > This fix is committed in 7376e60854 so libcurl is enabled fo

Re: Explicitly enable meson features in CI

2025-07-08 Thread Nazir Bilal Yavuz
Hi, On Wed, 2 Jul 2025 at 10:22, Nazir Bilal Yavuz wrote: > > Also, libcurl is disabled in the OpenBSD CI task until the fix in this > thread [1] is committed. This fix is committed in 7376e60854 so libcurl is enabled for OpenBSD in v4. -- Regards, Nazir Bilal Yavuz Microsoft From 4cbdc65f0f47

Re: Explicitly enable meson features in CI

2025-07-04 Thread Daniel Gustafsson
> On 4 Jul 2025, at 09:33, Nazir Bilal Yavuz wrote: > On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson wrote: >> An alternative approach would be to instead of having opt-in's for >> non-Windows >> have opt-outs for Windows, ie a MESON_WINDOWS_EXCLUDES which does =disabled >> on >> the specific

Re: Explicitly enable meson features in CI

2025-07-04 Thread Nazir Bilal Yavuz
Hi, On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson wrote: > > > On 3 Jul 2025, at 15:50, Nazir Bilal Yavuz wrote: > > On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote: > > >> + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS' task > >> too > >> + MESON_NON_VS_FEATURES: >

Re: Explicitly enable meson features in CI

2025-07-03 Thread Daniel Gustafsson
> On 3 Jul 2025, at 15:50, Nazir Bilal Yavuz wrote: > On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote: >> + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS' task too >> + MESON_NON_VS_FEATURES: >- >> >> I'm not a fan of this name, it feel a bit unintuitive to describe wh

Re: Explicitly enable meson features in CI

2025-07-03 Thread Nazir Bilal Yavuz
Hi, Thank you for looking into this! On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote: > > > On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz wrote: > > On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote: > > >> Here is a sketch of what I mean: > >> > >> env: > >> ... > >> PG_TEST_EXTRA: ..

Re: Explicitly enable meson features in CI

2025-07-03 Thread Daniel Gustafsson
> On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz wrote: > On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote: >> Here is a sketch of what I mean: >> >> env: >> ... >> PG_TEST_EXTRA: ... >> MESON_COMMON_ARGS: -Dauto_features=disabled -Ddocs=enabled ... >> CONFIGURE_COMMON_ARGS: --with-gssap

Re: Explicitly enable meson features in CI

2025-07-03 Thread Nazir Bilal Yavuz
Hi, Thank you for looking into this! On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote: > > On 02.07.25 09:22, Nazir Bilal Yavuz wrote: > > One thing I’m unsure about the patch is that all these features are > > stored in the MESON_FEATURES environment variable in each task. I > > wonder if it

Re: Explicitly enable meson features in CI

2025-07-02 Thread Peter Eisentraut
On 02.07.25 09:22, Nazir Bilal Yavuz wrote: One thing I’m unsure about the patch is that all these features are stored in the MESON_FEATURES environment variable in each task. I wonder if it might be clearer to rename these variables to ${TASK_NAME}_MESON_FEATURES to avoid confusion. I would ho

Re: Explicitly enable meson features in CI

2025-07-02 Thread Daniel Gustafsson
> On 2 Jul 2025, at 09:22, Nazir Bilal Yavuz wrote: > Right now, many features are set to auto in Meson builds in CI. This > means Meson tries to detect these features automatically but does not > report an error if it fails to find them. Jacob stated [1] that this > behavior can lead to issues,

Explicitly enable meson features in CI

2025-07-02 Thread Nazir Bilal Yavuz
Hi, Right now, many features are set to auto in Meson builds in CI. This means Meson tries to detect these features automatically but does not report an error if it fails to find them. Jacob stated [1] that this behavior can lead to issues, such as missing problems in the build system. Additionall