Re: Making CallContext and InlineCodeBlock less special-case-y

2022-07-12 Thread Peter Eisentraut
On 12.07.22 01:01, Tom Lane wrote: I wrote: Peter Eisentraut writes: On 10.07.22 01:50, Tom Lane wrote: As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock from getting unneeded support functions via some very ad-hoc code. Couldn't we just enable those support functi

Re: Making CallContext and InlineCodeBlock less special-case-y

2022-07-11 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> On 10.07.22 01:50, Tom Lane wrote: >>> As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock >>> from getting unneeded support functions via some very ad-hoc code. >> Couldn't we just enable those support functions? I think they were ju

Re: Making CallContext and InlineCodeBlock less special-case-y

2022-07-11 Thread Tom Lane
Peter Eisentraut writes: > On 10.07.22 01:50, Tom Lane wrote: >> As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock >> from getting unneeded support functions via some very ad-hoc code. > Couldn't we just enable those support functions? I think they were just > excluded

Re: Making CallContext and InlineCodeBlock less special-case-y

2022-07-11 Thread Peter Eisentraut
On 10.07.22 01:50, Tom Lane wrote: As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock from getting unneeded support functions via some very ad-hoc code. Couldn't we just enable those support functions? I think they were just excluded because they didn't have any before

Re: Making CallContext and InlineCodeBlock less special-case-y

2022-07-09 Thread Tom Lane
I wrote: > As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock > from getting unneeded support functions via some very ad-hoc code. > (Right now, there are some other node types that are handled similarly, > but I'm looking to drive that set to empty.) After looking at the >

Making CallContext and InlineCodeBlock less special-case-y

2022-07-09 Thread Tom Lane
As committed, gen_node_support.pl excludes CallContext and InlineCodeBlock from getting unneeded support functions via some very ad-hoc code. (Right now, there are some other node types that are handled similarly, but I'm looking to drive that set to empty.) After looking at the situation a bit, I