Re: DropRelFileLocatorBuffers

2022-07-12 Thread Kyotaro Horiguchi
At Tue, 12 Jul 2022 10:30:20 -0400, Robert Haas wrote in > On Tue, Jul 12, 2022 at 12:07 AM Dilip Kumar wrote: > > I think the naming used in your patch looks better to me. So +1 for the > > change. > > Committed. Thank you, Robert and Dilip. regards. -- Kyotaro Horiguchi NTT Open Source

Re: DropRelFileLocatorBuffers

2022-07-12 Thread Robert Haas
On Tue, Jul 12, 2022 at 12:07 AM Dilip Kumar wrote: > I think the naming used in your patch looks better to me. So +1 for the > change. Committed. -- Robert Haas EDB: http://www.enterprisedb.com

Re: DropRelFileLocatorBuffers

2022-07-11 Thread Dilip Kumar
On Tue, Jul 12, 2022 at 7:55 AM Kyotaro Horiguchi wrote: > > At Mon, 11 Jul 2022 13:51:12 -0400, Robert Haas wrote > in > > On Fri, Jul 8, 2022 at 1:59 AM Kyotaro Horiguchi > > wrote: > > > The function CreateAndCopyRelationData exists since before b0a55e4329 > > > but renamed since it takes Re

Re: DropRelFileLocatorBuffers

2022-07-11 Thread Kyotaro Horiguchi
At Mon, 11 Jul 2022 13:51:12 -0400, Robert Haas wrote in > On Fri, Jul 8, 2022 at 1:59 AM Kyotaro Horiguchi > wrote: > > The function CreateAndCopyRelationData exists since before b0a55e4329 > > but renamed since it takes RelFileLocators. > > I'm not very sold on this. I think that the places

Re: DropRelFileLocatorBuffers

2022-07-11 Thread Robert Haas
On Fri, Jul 8, 2022 at 1:59 AM Kyotaro Horiguchi wrote: > I thought for a moment that "Relation" sounded better but that naming > is confusing in bufmgr.c, where functions take Relation and those take > RelFileLocator exist together. So the (second) attached introduces > "RelFile" to represent Rel

Re: DropRelFileLocatorBuffers

2022-07-07 Thread Kyotaro Horiguchi
At Fri, 08 Jul 2022 11:52:45 +0900 (JST), Kyotaro Horiguchi wrote in > > I wouldn't mind if we took "Locator" out of the name of that function > > and just called it DropRelFileBuffers or DropRelationBuffers or > > something. That would be shorter, and maybe more intuitive. > > Thanks. Will pro

Re: DropRelFileLocatorBuffers

2022-07-07 Thread Kyotaro Horiguchi
At Thu, 7 Jul 2022 21:13:59 -0400, Robert Haas wrote in > On Thu, Jul 7, 2022 at 8:22 PM Kyotaro Horiguchi > wrote: > > Thanks for the reply. > > > > Yes if it is "RelFileLocator when we're talking about all the things > > that are needed to locate a relation's files on disk,". I read this as >

Re: DropRelFileLocatorBuffers

2022-07-07 Thread Robert Haas
On Thu, Jul 7, 2022 at 8:22 PM Kyotaro Horiguchi wrote: > Thanks for the reply. > > Yes if it is "RelFileLocator when we're talking about all the things > that are needed to locate a relation's files on disk,". I read this as > RelFileLocator is a kind of pointer to files. I thought RelFileNode >

Re: DropRelFileLocatorBuffers

2022-07-07 Thread Kyotaro Horiguchi
At Thu, 7 Jul 2022 08:36:14 -0400, Robert Haas wrote in > On Thu, Jul 7, 2022 at 4:44 AM Kyotaro Horiguchi > wrote: > > While working on a patch, I met a function with the signature of: > > > > > DropRelFileLocatorBuffers(SMgrRelation smgr_reln, ForkNumber *forkNum, > > >

Re: DropRelFileLocatorBuffers

2022-07-07 Thread Robert Haas
On Thu, Jul 7, 2022 at 4:44 AM Kyotaro Horiguchi wrote: > While working on a patch, I met a function with the signature of: > > > DropRelFileLocatorBuffers(SMgrRelation smgr_reln, ForkNumber *forkNum, > > int nforks, BlockNumber > > *firstDelBlock)