Re: Safer hash table initialization macro

2025-12-01 Thread Jelte Fennema-Nio
On Mon, 1 Dec 2025 at 14:45, Bertrand Drouvot wrote: > Thoughts? I think the hashtable creation API in postgres is so terrible that it actively discourages usage. At Citus we definitely had the problem that we would use Lists for cases where a hashtable was preferable perf wise, just because the

Safer hash table initialization macro

2025-12-01 Thread Bertrand Drouvot
Hi hackers, Currently to create a hash table we do things like: A) create a struct, say: typedef struct SeenRelsEntry { Oid rel_id; int list_index; } SeenRelsEntry; where the first member is the hash key, and then later: B) ctl.keysize = sizeof(Oid); ctl.entrysize = sizeof(Se