Re: Timeout control within tests

2022-04-17 Thread Noah Misch
(I pushed the main patch as f2698ea, on 2022-03-04.) On Fri, Feb 18, 2022 at 06:41:36PM -0800, Noah Misch wrote: > On Fri, Feb 18, 2022 at 10:26:52AM -0500, Tom Lane wrote: > > Noah Misch writes: > > > On Thu, Feb 17, 2022 at 09:48:25PM -0800, Andres Freund wrote: > > >> Meson's test runner has t

Re: Timeout control within tests

2022-02-18 Thread Noah Misch
On Fri, Feb 18, 2022 at 10:26:52AM -0500, Tom Lane wrote: > Noah Misch writes: > > On Thu, Feb 17, 2022 at 09:48:25PM -0800, Andres Freund wrote: > >> Meson's test runner has the concept of a "timeout multiplier" for ways of > >> running tests. Meson's stuff is about entire tests (i.e. one tap tes

Re: Timeout control within tests

2022-02-18 Thread Tom Lane
Noah Misch writes: > On Thu, Feb 17, 2022 at 09:48:25PM -0800, Andres Freund wrote: >> Meson's test runner has the concept of a "timeout multiplier" for ways of >> running tests. Meson's stuff is about entire tests (i.e. one tap test), so >> doesn't apply here, but I wonder if we shouldn't do some

Re: Timeout control within tests

2022-02-17 Thread Noah Misch
On Thu, Feb 17, 2022 at 09:48:25PM -0800, Andres Freund wrote: > On 2022-02-17 21:28:42 -0800, Noah Misch wrote: > > I propose to have environment variable PG_TEST_TIMEOUT_DEFAULT control the > > timeout used in the places that currently hard-code 180s. > > Meson's test runner has the concept of a

Re: Timeout control within tests

2022-02-17 Thread Andres Freund
Hi, On 2022-02-17 21:28:42 -0800, Noah Misch wrote: > I propose to have environment variable PG_TEST_TIMEOUT_DEFAULT control the > timeout used in the places that currently hard-code 180s. Meson's test runner has the concept of a "timeout multiplier" for ways of running tests. Meson's stuff is ab

Timeout control within tests

2022-02-17 Thread Noah Misch
On Fri, Feb 05, 2021 at 03:55:20PM -0500, Tom Lane wrote: > We have, almost invariably, regretted it when we tried to use short > timeouts in test cases. > More generally, sometimes people want to do things like run a test > under valgrind. So it's not just "underpowered machines" that may > need