Re: injection points for hash aggregation

2025-02-17 Thread Michael Paquier
On Tue, Feb 11, 2025 at 11:48:03AM -0800, Jeff Davis wrote: > I committed just the injection points part. It seemed simple and low- > risk. This has been committed and there was a CF entry: https://commitfest.postgresql.org/patch/5560/ Switched it as committed now. -- Michael signature.asc Desc

Re: injection points for hash aggregation

2025-02-11 Thread Jeff Davis
On Mon, 2025-02-03 at 15:54 -0800, Jeff Davis wrote: > Attaching > v2. I committed just the injection points part. It seemed simple and low- risk. Regards, Jeff Davis

Re: injection points for hash aggregation

2025-02-03 Thread Jeff Davis
On Tue, 2025-02-04 at 12:50 +0900, Michael Paquier wrote: > On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote: > > Being able to pass down some runtime states to a callback is > > something > > I've drafted a patch for, as of: > > https://www.postgresql.org/message-id/z23zce4w1djuk...

Re: injection points for hash aggregation

2025-02-03 Thread Michael Paquier
On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote: > Being able to pass down some runtime states to a callback is something > I've drafted a patch for, as of: > https://www.postgresql.org/message-id/z23zce4w1djuk...@paquier.xyz Oops. I've posted an incorrect link here, I meant this

Re: injection points for hash aggregation

2025-02-03 Thread Michael Paquier
On Mon, Feb 03, 2025 at 12:45:24PM -0800, Jeff Davis wrote: > A couple questions on the injection points framework: > > * The patch allows forcing the partition fan-out to one. I could > imagine forcing it to a specific value, is there a way to do that? > > * The injection_points extension offers

Re: injection points for hash aggregation

2025-02-03 Thread Jeff Davis
t: [PATCH v2 1/2] Add injection points for hash aggregation. --- src/backend/executor/nodeAgg.c| 62 ++--- src/test/modules/injection_points/Makefile| 2 +- .../injection_points/expected/hashagg.out | 68 +++ src/test/modules/injection_points/

injection points for hash aggregation

2025-02-03 Thread Jeff Davis
Attached is a patch that adds a few injection points for hash aggregation. A couple questions on the injection points framework: * The patch allows forcing the partition fan-out to one. I could imagine forcing it to a specific value, is there a way to do that? * The injection_points extension