Re: problems with toast.* reloptions

2025-07-15 Thread Shayon Mukherjee
On Wed, Jul 2, 2025 at 10:44 AM shihao zhong wrote: > >> Actually, I think there's a problem with this approach... > > You're right. I forgot we can reset the table options. While we could > use a placeholder and resolve it on-demand, that seems like too much > work. > > Hi all, I started a conv

Re: problems with toast.* reloptions

2025-07-02 Thread shihao zhong
>> Actually, I think there's a problem with this approach... You're right. I forgot we can reset the table options. While we could use a placeholder and resolve it on-demand, that seems like too much work.

Re: problems with toast.* reloptions

2025-06-25 Thread Nathan Bossart
On Mon, Jun 23, 2025 at 10:59:51AM -0500, Nathan Bossart wrote: > On Sat, Jun 21, 2025 at 11:45:25PM -0400, shihao zhong wrote: >> 2) When updating a table's relopt, also update the relopt of its >> associated TOAST table if it's not already set. Similarly, when >> creating a new TOAST table, it wo

Re: problems with toast.* reloptions

2025-06-24 Thread Nathan Bossart
On Tue, Jun 24, 2025 at 02:10:55PM +0900, Michael Paquier wrote: > On Mon, Jun 23, 2025 at 03:59:56PM -0500, Nathan Bossart wrote: >> Here is a very rough proof-of-concept patch set for this. AFAICT there are >> a few options we cannot fix on the back-branches because there is no way to >> tell wh

Re: problems with toast.* reloptions

2025-06-23 Thread Michael Paquier
On Mon, Jun 23, 2025 at 03:59:56PM -0500, Nathan Bossart wrote: > Here is a very rough proof-of-concept patch set for this. AFAICT there are > a few options we cannot fix on the back-branches because there is no way to > tell whether it is set or has just picked up the default. On v18 and > newer

Re: problems with toast.* reloptions

2025-06-23 Thread Nathan Bossart
On Fri, Jun 20, 2025 at 11:05:37AM +0900, Michael Paquier wrote: > On Thu, Jun 19, 2025 at 03:20:27PM -0500, Nathan Bossart wrote: >> I think we need to do something like the following to fix this: >> >> * Teach autovacuum to combine the TOAST reloptions with the main relation's >> when processi

Re: problems with toast.* reloptions

2025-06-23 Thread Nathan Bossart
On Sat, Jun 21, 2025 at 11:45:25PM -0400, shihao zhong wrote: > 2) When updating a table's relopt, also update the relopt of its > associated TOAST table if it's not already set. Similarly, when > creating a new TOAST table, it would inherit the parent's relopt. > > Option 2 seems more reasonable

Re: problems with toast.* reloptions

2025-06-21 Thread shihao zhong
> I think we need to do something like the following to fix this: > > * Teach autovacuum to combine the TOAST reloptions with the main relation's > when processing TOAST tables (with the toast.* ones winning if both are > set). > > * Teach autovacuum to resolve reloptions for parameters like >

Re: problems with toast.* reloptions

2025-06-20 Thread Nathan Bossart
On Fri, Jun 20, 2025 at 11:05:37AM +0900, Michael Paquier wrote: > On Thu, Jun 19, 2025 at 03:20:27PM -0500, Nathan Bossart wrote: >> * vacuum_rel() does not look up the main relation's reloptions when >> processing a TOAST table, which is a problem for manual VACUUMs. The >> aforementioned bu

Re: problems with toast.* reloptions

2025-06-19 Thread Michael Paquier
On Thu, Jun 19, 2025 at 03:20:27PM -0500, Nathan Bossart wrote: > While investigating problems caused by vacuum_rel() scribbling on its > VacuumParams argument [0], I noticed some other interesting bugs with the > toast.* reloption code. Note that the documentation for the reloptions has > the fol

problems with toast.* reloptions

2025-06-19 Thread Nathan Bossart
While investigating problems caused by vacuum_rel() scribbling on its VacuumParams argument [0], I noticed some other interesting bugs with the toast.* reloption code. Note that the documentation for the reloptions has the following line: If a table parameter value is set and the equivale