Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-04 Thread Simon Riggs
On Fri, 2009-09-04 at 09:26 -0400, Robert Haas wrote: > Hopefully you're planning to keep that part, as it > would be a shame if I had done it for nothing. Not promising anything in that regard, but I appreciate your efforts to assist. I doubt it was wasted effort in any sense. It will certainl

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-04 Thread Simon Riggs
On Fri, 2009-09-04 at 09:26 -0400, Robert Haas wrote: > On Thu, Sep 3, 2009 at 5:50 PM, Simon Riggs wrote: > > > > On Thu, 2009-09-03 at 22:22 +0300, Heikki Linnakangas wrote: > >> Simon Riggs wrote: > >> > I propose we just accept that both max_connections and > >> > max_prepared_transactions nee

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-04 Thread Robert Haas
On Thu, Sep 3, 2009 at 5:50 PM, Simon Riggs wrote: > > On Thu, 2009-09-03 at 22:22 +0300, Heikki Linnakangas wrote: >> Simon Riggs wrote: >> > I propose we just accept that both max_connections and >> > max_prepared_transactions need to be set correctly for recovery to work. >> > This will make the

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-03 Thread Simon Riggs
On Fri, 2009-09-04 at 01:25 -0400, Tom Lane wrote: > Simon Riggs writes: > > On Thu, 2009-09-03 at 22:22 +0300, Heikki Linnakangas wrote: > >> Simon Riggs wrote: > >>> I propose we just accept that both max_connections and > >>> max_prepared_transactions need to be set correctly for recovery to w

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-03 Thread Tom Lane
Simon Riggs writes: > On Thu, 2009-09-03 at 22:22 +0300, Heikki Linnakangas wrote: >> Simon Riggs wrote: >>> I propose we just accept that both max_connections and >>> max_prepared_transactions need to be set correctly for recovery to work. >>> This will make the state transitions more robust and

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-03 Thread Simon Riggs
On Thu, 2009-09-03 at 22:22 +0300, Heikki Linnakangas wrote: > Simon Riggs wrote: > > I propose we just accept that both max_connections and > > max_prepared_transactions need to be set correctly for recovery to work. > > This will make the state transitions more robust and it will avoid > > spuri

Re: [HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-03 Thread Heikki Linnakangas
Simon Riggs wrote: > I propose we just accept that both max_connections and > max_prepared_transactions need to be set correctly for recovery to work. > This will make the state transitions more robust and it will avoid > spurious and hard to test error messages. > > Any objections to me removing

[HACKERS] Hot Standby, max_connections and max_prepared_transactions

2009-09-03 Thread Simon Riggs
We discussed earlier that HS should continue to work even if max_connections was set differently on the primary and the standby. This now gives a situation where snapshots can be allowed, then disallowed for a while, then allowed again. Complication is that this will cause some connections to fai