Re: [Pixman] [PATCH v14 12/22] pixman-filter: fix subsample_bits == 0

2016-04-09 Thread Søren Sandmann
On Sat, Apr 9, 2016 at 3:45 PM, Bill Spitzak wrote: > On 04/03/2016 11:17 AM, Søren Sandmann wrote: > >> I don't believe this patch is correct. >> >> As an example, consider an image with an identity transformation and a >> cubic filter (which has width 4) with subsample_bits = 0. The current >>

Re: [Pixman] [PATCH v14 12/22] pixman-filter: fix subsample_bits == 0

2016-04-09 Thread Bill Spitzak
On 04/03/2016 11:17 AM, Søren Sandmann wrote: I don't believe this patch is correct. As an example, consider an image with an identity transformation and a cubic filter (which has width 4) with subsample_bits = 0. The current code will compute a matrix [ cubic(-2), cubic(-1), cubic(0), cub

Re: [Pixman] [PATCH] pixman: Add support for aarch64 neon optimization (ver.3)

2016-04-09 Thread Mizuki Asakura
I'm sorry that I've failed again to add correct copyright chars at the top of sources. It could be caused by my environment, but I cannot figure out the reason. If the patch is correct, could you please modify the (C) char on the sources before commiting ? > diff --git a/pixman/pixman-arma64-neon