Re: [Pixman] Strange looking text in 'dither_factor_bayer_8'

2019-06-06 Thread Maarten Lankhorst
Op 06-06-2019 om 16:41 schreef John Emmas: > MSVC is complaining about a new function called 'dither_factor_bayer_8' (in > pixman/pixman-bits-image.c).  The relevant code looks like this:- > >     m = ((y & 0b001) << 5) | ((x & 0b001) << 4) | >     ((y & 0b010) << 2) | ((x & 0b010) << 1) | >     (

Re: [Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image, v2.

2019-02-11 Thread Maarten Lankhorst
Op 09-02-2019 om 13:01 schreef Basile Clement: > On 1/8/19 11:42 AM, Maarten Lankhorst wrote: > >> pixman-bits-image's wide helpers first obtains the 8-bits image, >> then converts it to float. This destroys all the precision that >> the wide path was offering. >&

[Pixman] [ANNOUNCE] pixman release 0.38.0 now available

2019-02-11 Thread Maarten Lankhorst
[ultimate] Maarten Lankhorst [ultimate] Maarten Lankhorst ) Git: https://gitlab.freedesktop.org/pixman/pixman.git tag: pixman-0.38.0 Log: Basile Clement (1): Implement floating point gradient computation, v2. Dylan Baker (5): Add

[Pixman] [PATCH 1/2] Implement floating point gradient computation, v2.

2019-01-14 Thread Maarten Lankhorst
prototypes in pixman-private.h Signed-off-by: Maarten Lankhorst --- diff --git a/pixman/pixman-conical-gradient.c b/pixman/pixman-conical-gradient.c index 8bb46aecdcab..a39e20c4eb68 100644 --- a/pixman/pixman-conical-gradient.c +++ b/pixman/pixman-conical-gradient.c @@ -51,7 +51,10

[Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image, v2.

2019-01-08 Thread Maarten Lankhorst
igned-off-by: Maarten Lankhorst --- pixman/pixman-bits-image.c | 414 +++-- pixman/pixman-inlines.h| 25 +++ 2 files changed, 328 insertions(+), 111 deletions(-) diff --git a/pixman/pixman-bits-image.c b/pixman/pixman-bits-image.c index 9fb91ff5831d..564789e

Re: [Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image

2019-01-07 Thread Maarten Lankhorst
0, +pixman_image_get_width(image), pixman_image_get_height(image)); + +app = app_new (tmp); window = get_widget (app, "main"); ------- Didn't notice anything wrong, so all looks correct with at least simple convolution. > - Basile &g

Re: [Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image

2019-01-03 Thread Maarten Lankhorst
ll in a argb_t, while the 8-bits path will fill a 32-bits ARGB value. This also requires writing a floating point bilinear interpolator. With this change pixman can use the full floating point precision internally in all paths. Op 03-01-2019 om 12:18 schreef Maarten Lankhorst: > Signed-off-by:

[Pixman] [PATCH 1/2] Implement floating point gradient computation

2019-01-03 Thread Maarten Lankhorst
and then expanding to floating point as they were doing previously. Signed-off-by: Maarten Lankhorst --- pixman/pixman-conical-gradient.c | 36 ++ pixman/pixman-gradient-walker.c | 92 ++--- pixman/pixman-linear-gradient.c | 49 -- pixman/pixman

[Pixman] [PATCH 2/2] pixman: Use maximum precision for pixman-bits-image

2019-01-03 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- pixman/pixman-bits-image.c | 478 ++--- pixman/pixman-inlines.h| 25 ++ 2 files changed, 418 insertions(+), 85 deletions(-) diff --git a/pixman/pixman-bits-image.c b/pixman/pixman-bits-image.c index 9fb91ff5831d

[Pixman] [PATCH] pixman: Use maximum precision for pixman-bits-image

2018-12-07 Thread Maarten Lankhorst
Op 06-12-2018 om 15:46 schreef Maarten Lankhorst: > Op 06-12-2018 om 12:03 schreef Maarten Lankhorst: >> Op 05-12-2018 om 11:24 schreef Basile Clement: >>> Hi, >>> >>> On 12/5/18 9:08 AM, Pekka Paalanen wrote: >>>> On Tue, 4 Dec 2018 17:36:18 +0100 &

Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-06 Thread Maarten Lankhorst
Op 06-12-2018 om 12:03 schreef Maarten Lankhorst: > Op 05-12-2018 om 11:24 schreef Basile Clement: >> Hi, >> >> On 12/5/18 9:08 AM, Pekka Paalanen wrote: >>> On Tue, 4 Dec 2018 17:36:18 +0100 >>> Maarten Lankhorst wrote: >>>> Series looks sane,

Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-06 Thread Maarten Lankhorst
Op 05-12-2018 om 11:24 schreef Basile Clement: > Hi, > > On 12/5/18 9:08 AM, Pekka Paalanen wrote: >> On Tue, 4 Dec 2018 17:36:18 +0100 >> Maarten Lankhorst wrote: >>> Series looks sane, 1/4 is cleaner than my version. I would change Bpp >>> to cpp, or mult

Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-04 Thread Maarten Lankhorst
Hey, Op 03-12-2018 om 16:01 schreef Basile Clement: > > This is essentially a duplicate of the recent patch by Maarten Lankhorst > (which spurred me into finally posting these, which laid on my laptop for a > couple months), with a slightly different approach.  It is mostly included

[Pixman] [PATCH] pixman: Use maximum precision for gradients

2018-12-03 Thread Maarten Lankhorst
The high precision gradient path was falling back to the 8-bit path, then expanding it to float. This removed any advantage of the high precision path, so make sure our gradients are computed as floats by adding a separate path. Signed-off-by: Maarten Lankhorst --- pixman/pixman-conical

[Pixman] [ANNOUNCE] pixman release 0.36.0 now available

2018-11-21 Thread Maarten Lankhorst
: 10d85590beee287a508a148297808a66d1ce11cd pixman-0.36.0.tar.bz2 GPG signature: http://cairographics.org/releases/pixman-0.36.0.tar.gz.sha1.asc (signed by Maarten Lankhorst ) Git: https://gitlab.freedesktop.org/pixman/pixman.git tag: pixman-0.36.0 Log: Adam Jackson (1): ci: Add

[Pixman] Pixman release?

2018-11-15 Thread Maarten Lankhorst
Hey, To get the floating point support in hands of users, I want to make a pixman release. Since pixman appears to be in a bit of a limbo, is there anyone still being a maintainer, or should I simply make a release according to the guidelines at RELEASING? ~Maarten __

Re: [Pixman] [PATCH 2/2] pixman: Add tests for xrgb/argb formats.

2018-11-06 Thread Maarten Lankhorst
Op 26-10-18 om 12:37 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-08-01 13:41:34) >> Signed-off-by: Maarten Lankhorst > Reviewed-by: Chris Wilson > -Chris Thanks, pushed. I added a mention in patch 1/2 of how adding the floating point format doesn't make it i

Re: [Pixman] pixman: Add support for argb/xrgb float formats, v5.

2018-11-01 Thread Maarten Lankhorst
Op 31-10-18 om 20:04 schreef Bill Spitzak: > I don't like the fact that the design which allows the rgba to be different > sizes cannot make them vary between float and decimal. The main reason is so > that an integer for Alpha can be supported. I think maybe there should be a > bit that changes

[Pixman] pixman: Add support for argb/xrgb float formats, v5.

2018-10-31 Thread Maarten Lankhorst
- Define 32bpc as PIXMAN_FORMAT_PACKED_C32 - Rename pixman accessors from rgb*_float_float to rgb*f_float Changes since v4: - Create a new PIXMAN_FORMAT_BYTE for fitting up to 64 bits per component. (based on Siarhei Siamashka's suggestion) - Use new format type PIXMAN_TYPE_RGBA_FLOAT Signed-off-by: Maarten

Re: [Pixman] [PATCH 1/2] pixman: Add support for argb/xrgb float formats, v3.

2018-10-29 Thread Maarten Lankhorst
Op 29-10-18 om 09:16 schreef Siarhei Siamashka: > On Wed, 03 Oct 2018 10:11:46 +0100 > Chris Wilson wrote: > >> Quoting Maarten Lankhorst (2018-08-01 13:41:33) >>> diff --git a/pixman/pixman.h b/pixman/pixman.h >>> index 509ba5e534a8..c9bf4faa80d4 100644 >>&

[Pixman] [PATCH 1/2] pixman: Add support for argb/xrgb float formats, v4.

2018-10-25 Thread Maarten Lankhorst
Op 03-10-18 om 11:11 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-08-01 13:41:33) >> diff --git a/pixman/pixman.h b/pixman/pixman.h >> index 509ba5e534a8..c9bf4faa80d4 100644 >> --- a/pixman/pixman.h >> +++ b/pixman/pixman.h >> @@ -647,19 +647,24 @@ st

Re: [Pixman] [PATCH 2/2] pixman: Add tests for xrgb/argb formats.

2018-09-10 Thread Maarten Lankhorst
Op 03-09-18 om 06:40 schreef Siarhei Siamashka: > On Mon, 27 Aug 2018 14:39:24 +0200 > Maarten Lankhorst wrote: > >> There hasn't been any movement on reviewing this series since i posted this. > Sorry for the delay, I'll review it later today or tomorrow. Thanks, woul

Re: [Pixman] [PATCH 2/2] pixman: Add tests for xrgb/argb formats.

2018-08-27 Thread Maarten Lankhorst
Hey, Op 01-08-18 om 14:41 schreef Maarten Lankhorst: > Signed-off-by: Maarten Lankhorst > --- > test/alphamap.c| 73 +++- > test/stress-test.c | 75 + > test/uti

Re: [Pixman] [PATCH 1/2] pixman: Add support for argb/xrgb float formats, v3.

2018-08-03 Thread Maarten Lankhorst
Op 03-08-18 om 07:01 schreef Bryce Harrington: > On Wed, Aug 01, 2018 at 02:41:33PM +0200, Maarten Lankhorst wrote: >> Pixman is already using the floating point formats internally, expose >> this capability in case someone wants to support higher bit per >> component formats.

[Pixman] [PATCH 0/2] Add float support to pixman

2018-08-01 Thread Maarten Lankhorst
New version, with better checks to pixel accessors and alignment. Also some small tweaks, and making stress-test work with the changes. Hopefully we can move forward and finalize the bitstream format, so we can start exposing it in pixman. Maarten Lankhorst (2): pixman: Add support for argb

[Pixman] [PATCH 1/2] pixman: Add support for argb/xrgb float formats, v3.

2018-08-01 Thread Maarten Lankhorst
or to F16. Changes since v1: - Use RGBA 128 bits and RGB 96 bits memory layouts, to better match the opengl format. Changes since v2: - Add asserts in accessor and for strides to force alignment. - Move test changes to their own commit. Signed-off-by: Maarten Lankhorst --- pixman/pixman-acc

[Pixman] [PATCH 2/2] pixman: Add tests for xrgb/argb formats.

2018-08-01 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- test/alphamap.c| 73 +++- test/stress-test.c | 75 + test/utils.c | 76 ++ test/utils.h | 2 ++ 4 files changed

Re: [Pixman] [PATCH v2] pixman: Add support for argb/xrgb float formats

2018-06-13 Thread Maarten Lankhorst
Op 12-06-18 om 16:24 schreef Siarhei Siamashka: > On Mon, 11 Jun 2018 13:34:50 +0200 > Maarten Lankhorst wrote: > >> Pixman is already using the floating point formats internally, expose >> this capability in case someone wants to support higher bit per >> component for

[Pixman] [PATCH v2] pixman: Add support for argb/xrgb float formats

2018-06-11 Thread Maarten Lankhorst
or to F16. Changes since v1: - Use RGBA 128 bits and RGB 96 bits memory layouts, to better match the opengl format. Signed-off-by: Maarten Lankhorst --- pixman/pixman-access.c | 128 - pixman/pixman.h| 36 test/alphamap.c

[Pixman] [PATCH] pixman: Add support for argb/xrgb float formats

2018-06-08 Thread Maarten Lankhorst
or to F16. Signed-off-by: Maarten Lankhorst --- pixman/pixman-access.c | 115 - pixman/pixman.h| 35 + test/alphamap.c| 71 ++--- test/utils.c | 75 +++ test/ut