Re: [Pixman] Dithering patches, v2

2019-05-28 Thread Bryce Harrington
On Tue, May 28, 2019 at 01:36:40PM -0400, Adam Jackson wrote: > On Sat, 2019-05-25 at 07:50 -0700, Bryce Harrington wrote: > > > Looks like since the move to gitlab.freedesktop.org I no longer have > > commit access on pixman; you'll need to land them for us. > > Apologies for the oversight, I've

Re: [Pixman] Dithering patches, v2

2019-05-28 Thread Adam Jackson
On Sat, 2019-05-25 at 07:50 -0700, Bryce Harrington wrote: > Looks like since the move to gitlab.freedesktop.org I no longer have > commit access on pixman; you'll need to land them for us. Apologies for the oversight, I've added you to the pixman group. - ajax _

Re: [Pixman] Dithering patches, v2

2019-05-25 Thread Bryce Harrington
On Mon, May 13, 2019 at 10:26:00AM -0700, Matt Turner wrote: > On Sat, May 11, 2019 at 7:42 AM Bryce Harrington > wrote: > > > > On Tue, May 07, 2019 at 09:52:39AM -0700, Matt Turner wrote: > > > On Sun, May 5, 2019 at 11:50 AM Bryce Harrington > > > wrote: > > > > > > > > On Mon, Apr 22, 2019 at

Re: [Pixman] Dithering patches, v2

2019-05-13 Thread Matt Turner
On Sat, May 11, 2019 at 7:42 AM Bryce Harrington wrote: > > On Tue, May 07, 2019 at 09:52:39AM -0700, Matt Turner wrote: > > On Sun, May 5, 2019 at 11:50 AM Bryce Harrington > > wrote: > > > > > > On Mon, Apr 22, 2019 at 09:26:48AM -0700, Matt Turner wrote: > > > > On Fri, Apr 19, 2019 at 4:52 PM

Re: [Pixman] Dithering patches, v2

2019-05-11 Thread Bryce Harrington
On Tue, May 07, 2019 at 09:52:39AM -0700, Matt Turner wrote: > On Sun, May 5, 2019 at 11:50 AM Bryce Harrington > wrote: > > > > On Mon, Apr 22, 2019 at 09:26:48AM -0700, Matt Turner wrote: > > > On Fri, Apr 19, 2019 at 4:52 PM Bryce Harrington > > > wrote: > > > > Inkscape would love to see Basi

Re: [Pixman] Dithering patches, v2

2019-05-07 Thread Matt Turner
On Sun, May 5, 2019 at 11:50 AM Bryce Harrington wrote: > > On Mon, Apr 22, 2019 at 09:26:48AM -0700, Matt Turner wrote: > > On Fri, Apr 19, 2019 at 4:52 PM Bryce Harrington > > wrote: > > > Inkscape would love to see Basile's dithering patches included. Our > > > testing shows that they make a

Re: [Pixman] Dithering patches, v2

2019-05-05 Thread Bryce Harrington
On Mon, Apr 22, 2019 at 09:26:48AM -0700, Matt Turner wrote: > On Fri, Apr 19, 2019 at 4:52 PM Bryce Harrington > wrote: > > Inkscape would love to see Basile's dithering patches included. Our > > testing shows that they make a huge quality difference for our users; > > this solves a critical nee

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Basile Clement
There is less calculation, but the noise matrix takes up cache space (about half a modern CPU's L1) and hence increases memory pressure.  The actual performance relationship is probably hardware dependent, but on my laptop doing a quick check with patched lowlevel-blt-bench:  - Bayer is ~8% faster

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Bill Spitzak
Is the "blue noise" version actually slower than the Bayer? Seems to be doing a bit less calculation but it reading the array of weights. The removal of the need for the pattern offset seems like a win. On Mon, Apr 22, 2019 at 9:27 AM Matt Turner wrote: > On Fri, Apr 19, 2019 at 4:52 PM Bryce Ha

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Matt Turner
On Fri, Apr 19, 2019 at 4:52 PM Bryce Harrington wrote: > Inkscape would love to see Basile's dithering patches included. Our > testing shows that they make a huge quality difference for our users; > this solves a critical need. > > Mc and I have done some preliminary investigation into how to pl

Re: [Pixman] Dithering patches, v2

2019-04-19 Thread Bryce Harrington
Hey Matt, Inkscape would love to see Basile's dithering patches included. Our testing shows that they make a huge quality difference for our users; this solves a critical need. Mc and I have done some preliminary investigation into how to plumb this into Cairo, and would love to hear your review

Re: [Pixman] Dithering patches, v2

2019-04-10 Thread Basile Clement
I'm not sure how, but I badly broke the formatting on that email -- my apologies.  Below is the previous email formatted as intended. On 4/10/19 1:04 AM, Bill Spitzak wrote: > How difficult is it to just make the gradients use dithering, so > they produce 8-bit (or whatever) results directly but

Re: [Pixman] Dithering patches, v2

2019-04-10 Thread Basile Clement
On 4/10/19 1:04 AM, Bill Spitzak wrote: > How difficult is it to just make the gradients use dithering, so > they > produce 8-bit (or whatever) results directly but with the > dithering pattern in them? > We don't have the destination bpp when we compute the gradients.  Søren Sandmann explained t

Re: [Pixman] Dithering patches, v2

2019-04-09 Thread Bill Spitzak
How difficult is it to just make the gradients use dithering, so they produce 8-bit (or whatever) results directly but with the dithering pattern in them? What other operations would need dithering (a large blur comes to mind, also zooming way in on an image in bilinear)? I think the blue noise l

Re: [Pixman] Dithering patches, v2

2019-04-09 Thread Basile Clement
I forgot to mention two things:  - Enabling dithering makes processing much slower, since it forces the wide pipeline to be used (and some optimisations are disabled).  This could be solved through the use of fast paths where needed (e.g. when blitting images from an equal or lower bits-per-pixels

[Pixman] Dithering patches, v2

2019-04-09 Thread basile-pixman
I am resubmitting for review and inclusion my series of patches on dithering from October, which I ended up not having the time to finish then. There are only a couple changes to make the patches compatible with the recently added floating point formats, and I have also added a dithering matrix ba