D28172: [applets/digital-clock] Fix date sizing in vertical panel

muesli added a comment. While it's not completely consistent yet, it still's an improvement that reverts the recent regression. As such, I'm tempted to say LGTM. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28172 To: ngraham, #vdg, #plasma Cc: muesli, pl

D28172: [applets/digital-clock] Fix date sizing in vertical panel

muesli added a comment. Your patch indeed makes the date behave like in previous releases again! However I noticed it's still not quite consistent in its behavior: when I start plasmashell freshly, the date is a lot wider than after resizing it to roughly the same width. I've added a new att

D28083: Use methods in KF5-activities to switch to previous/next activity

This revision was automatically updated to reflect the committed changes. Closed by commit R120:805e70bb6e75: Use methods in KF5-activities to switch to previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28083?

D28083: Use methods in KF5-activities to switch to previous/next activity

muesli created this revision. muesli added reviewers: ngraham, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY Since the release of KDE Frameworks 5.68.0 we can now use the methods exposed in KActivities:

D22382: Add global shortcuts for switching to the previous/next activity

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d6b5376eaa7: Add global shortcuts for switching to the previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?v

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. Alright, I think this looks sane again. @ngraham Mind if I land this in its current state? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel

D22382: Add global shortcuts for switching to the previous/next activity

muesli updated this revision to Diff 73412. muesli added a comment. Hopefully fix phabricator getting out of sync with the changeset. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=73354&id=73412 BRANCH shortcut-prevnext-activity (branc

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. Oops, I'm not sure what I've did here was what I intended: I rebased master (>800 commits since my original changeset) into my feature branch because I otherwise couldn't build/test my changes anymore, but obviously I didn't touch/change > 600 files. Is this how pha

D22382: Add global shortcuts for switching to the previous/next activity

muesli updated this revision to Diff 73354. muesli added a comment. - Remove default key-sequence for "Previous/Next Activity" shortcut REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=61521&id=73354 BRANCH shortcut-prevnext-activity (bra

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. While waiting for that separate discussion and decision, does anyone mind if I land this _without_ default shortcuts set? At least it enables people to switch to the previous/next activity when they configure a shortcut manually. Currently that's not possible, as

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. Would love to finish this one up! :) Any suggestions how to move forward? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The

D22381: Add previous-/nextActivity methods

This revision was automatically updated to reflect the committed changes. muesli marked an inline comment as done. Closed by commit R161:e3a7cb2f1b18: Add previous-/nextActivity methods (authored by muesli). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabrica

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 67276. muesli added a comment. Fix typo in 'nameBasedOrdering' REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61590&id=67276 BRANCH prevnext-activity (branched from master) REVISION DETAIL

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. In D22382#541626 , @ivan wrote: > I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is. I'm happy to remove the defaults (even though I consider them fairly cons

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 61590. muesli added a comment. Move nameBaseOrdering to an anonymous namespace and mark it as inline. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61589&id=61590 BRANCH prevnext-activity (

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 61589. muesli added a comment. Addressed @ivan's change requests Summary: - Renamed sorting method to nameBaseOrdering - Remove activity from sorted cache without re-sorting the entire list - Switch to prev/next running activity, skipping other

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 61588. muesli added a comment. Use a QVector instead of a QList to store sorted activities. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61579&id=61588 BRANCH prevnext-activity (branched f

D22396: Fix typo in CREATE_GETTER_AND_SETTER

This revision was automatically updated to reflect the committed changes. Closed by commit R161:d15446776e23: Fix typo in CREATE_GETTER_AND_SETTER (authored by muesli). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22396?vs=61581&id=61586 R

D22396: Fix typo in CREATE_GETTER_AND_SETTER

muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY Fix typo when undefining CREATE_GETTER_AND_SETTER. REPOSITORY R161 KActivity Manager Service BRANCH

D22381: Add previous-/nextActivity methods

muesli updated this revision to Diff 61579. muesli added a comment. Keep an alphabetically sorted list of activities Summary: Instead of re-sorting the activity list every time previous-/nextActivity gets called, maintain a sorted list. REPOSITORY R161 KActivity Manager Service CHA

D22381: Add previous-/nextActivity methods

muesli added inline comments. INLINE COMMENTS > ivan wrote in Activities.cpp:218 > I don't like the fact that it constantly resorts the activities. > > The second problem is that ListActivities returns a list in one order, and > this traverses activities in another order. If this will work by n

D22382: Add global shortcuts for switching to the previous/next activity

muesli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY We currently have a mouse-wheel action to switch to the previous/next desktop, but it wasn't possible to assign a global keyboard sh

D22381: Add previous-/nextActivity methods

muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY These two methods can be used to switch to the previous/next activity in alphabetical order. They are