Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-06-01 Thread Sebastian Kügler
On Saturday 22 May 2010 21:02:25 Chani wrote: > On May 22, 2010 09:03:53 Alessandro Diaferia wrote: > > Hullo, > > it seems reviewboard cannot connect to anonsvn (at least from here) so > > i'm attaching the patch here as it is really small. > > > > > > > > Having a look at https://bugs.kde.org/sh

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-25 Thread Aaron J. Seigo
On May 22, 2010, Alessandro Diaferia wrote: > > hmm. no comment on whether it's a feature.. code looks sensible, > > although wouldn't it be more future-proof to iterate over data->urls() > > instead of only > > taking the first? > > you're just right.. so here comes the updated patch :) looks g

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-23 Thread Alessandro Diaferia
2010/5/23 Asraniel > I'll just trow that randomly in here. > > My gf told me that it would be nice if you could not only mark apps as > favorites in kickoff, but also stuff like shutdown and especialy "lock > computer". But i didn't look at the code to see how easely thats possible. > > Beat Wolf

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-23 Thread Asraniel
I'll just trow that randomly in here. My gf told me that it would be nice if you could not only mark apps as favorites in kickoff, but also stuff like shutdown and especialy "lock computer". But i didn't look at the code to see how easely thats possible. Beat Wolf Am Samstag 22 Mai 2010, um 18

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-22 Thread Alessandro Diaferia
2010/5/22 Chani > On May 22, 2010 09:03:53 Alessandro Diaferia wrote: > > Hullo, > > it seems reviewboard cannot connect to anonsvn (at least from here) so > i'm > > attaching the patch here as it is really small. > > > > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see >

Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-22 Thread Chani
On May 22, 2010 09:03:53 Alessandro Diaferia wrote: > Hullo, > it seems reviewboard cannot connect to anonsvn (at least from here) so i'm > attaching the patch here as it is really small. > > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see > how easy is reproducing the bug

[PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

2010-05-22 Thread Alessandro Diaferia
Hullo, it seems reviewboard cannot connect to anonsvn (at least from here) so i'm attaching the patch here as it is really small. Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see how easy is reproducing the bug. It seems that kickoff does not allow adding favorites via D&D.