totto added inline comments.
INLINE COMMENTS
> desktop.cpp:47
> +: Plasma::ContainmentActions{parent, args}
> +, m_kwinrcRollOverDesktops{readKwinrcRollOverDesktops()}
> {
The m_kwinrcRollOverDesktops variable does not work at runtime because two
instances of SwitchDesktop are created:
totto updated this revision to Diff 42962.
totto marked an inline comment as done.
totto added a comment.
new revision
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14436?vs=38641&id=42962
REVISION DETAIL
https://phabricator.kde.org/D14436
AFF
davidedmundson added inline comments.
INLINE COMMENTS
> desktop.cpp:172
> +namespace {
> +void switchDesktop(bool next, bool rollover, bool invert) {
> const int numDesktops = KWindowSystem::numberOfDesktops();
if you turn this into a method you don't need the rollover/invert args
> totto
totto marked an inline comment as done.
totto added a comment.
> disabled checkbox for rollover
That was partially meant to overcome the shortcoming that changing the kwin
value does not change this value until some settings dialog is opened, but with
your patch this is no longer require
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Showing a disabled checkbox for rollover doesn't make much sense.
IMHO we should either have it as a separate option from kwin and have a
checkbox, or not have a
totto added inline comments.
INLINE COMMENTS
> desktop.cpp:36
> +constexpr const char *cfgKeyProperty = "cfgKey";
> +bool readKwinrcRollOverDesktops() {
> +auto cfg = KSharedConfig::openConfig("kwinrc");
The rollover option is from another kde component (kwin), is there a way to get
notifie
totto created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
totto requested review of this revision.
REVISION SUMMARY
By default the mouse wheel action of switchdesktop always
wraps around/rolls over when switching virtu
