D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. In D17354#372274 , @ngraham wrote: > Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ad34212a8ccd: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham added a comment. In D17354#372270 , @alexde wrote: > Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab: Yes, quite a bit. This current layout st

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indeted by a tab: General [ ] Show week number Available plugins [ ] Plugin A [ ] Plugin B That's would I personally

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham updated this revision to Diff 46967. ngraham added a comment. Align the label to the first child properly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17354?vs=46872&id=46967 BRANCH improve-calendar-settings-layout (branched from maste

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

abetts added a comment. Thank you! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17354 To: ngraham, #plasma, #vdg, mart Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham updated this revision to Diff 46872. ngraham added a comment. - Move General section back to the top, where it belongs - Use a left label for the plugin section (currently bugged pending a Kirigami ptch: D17362 ) REPOSITORY R120 Plasma Workspace

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham added a comment. OK, if I give the ColumnLayout a label, it mostly works, but the label is vertically centered rather than being top-aligned: F6455150: Needs to be top-aligned.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

mvourlakos added a comment. In D17354#371241 , @ngraham wrote: > In D17354#371239 , @zzag wrote: > > > Just wondering, shouldn't it look like > > > > Available plugins: [ ] Astronomical events

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

abetts added a comment. Would you want to move the General section to the top and plugins second? In general, general labels maybe belong to the very top of a KCM? To me, it seems like a more logical progression. From all items to more specific items. REPOSITORY R120 Plasma Workspace

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham added a comment. In D17354#371239 , @zzag wrote: > Just wondering, shouldn't it look like > > Available plugins: [ ] Astronomical events > [ ] Holidays > > > ? That was my first thought too, but t

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

zzag added a comment. Just wondering, shouldn't it look like Available plugins: [ ] Astronomical events [ ] Holidays ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17354 To: ngraham, #plasma, #vdg, mart Cc: zzag, plasma-

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham updated this revision to Diff 46855. ngraham added a comment. Make sure it's centered REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17354?vs=46854&id=46855 BRANCH improve-calendar-settings-layout (branched from master) REVISION DETAIL

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

ngraham created this revision. ngraham added reviewers: Plasma, VDG, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 400663 FIXED-IN: 5.15.0 TEST PLAN Before: After: Everything still wo