Re: [pulseaudio-discuss] [PATCH 12/13] loopback: Validate the rate parameter

2015-12-17 Thread Alexander E. Patrakov
18.12.2015 11:47, Georg Chini wrote: On 18.12.2015 06:49, Tanu Kaskinen wrote: On Wed, 2015-02-25 at 19:43 +0100, Georg Chini wrote: --- src/modules/module-loopback.c | 5 + src/pulse/sample.c| 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/module

Re: [pulseaudio-discuss] [PATCH 12/13] loopback: Validate the rate parameter

2015-12-17 Thread Georg Chini
On 18.12.2015 06:49, Tanu Kaskinen wrote: On Wed, 2015-02-25 at 19:43 +0100, Georg Chini wrote: --- src/modules/module-loopback.c | 5 + src/pulse/sample.c| 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/modules/module-loopback.c b/src/modules/modu

Re: [pulseaudio-discuss] [PATCH 12/13] loopback: Validate the rate parameter

2015-12-17 Thread Tanu Kaskinen
On Wed, 2015-02-25 at 19:43 +0100, Georg Chini wrote: > --- >  src/modules/module-loopback.c | 5 + >  src/pulse/sample.c| 5 - >  2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c > index d22afb5..7474e

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread Andrey Semashev
On 2015-12-17 15:51, Andrey Semashev wrote: On 2015-12-17 15:33, Pali Rohár wrote: On Thursday 17 December 2015 15:10:12 Andrey Semashev wrote: On 2015-12-17 14:50, Andrey Semashev wrote: On 2015-12-17 02:44, Kamil Rytarowski wrote: On 16.12.2015 11:02, Pali Rohár wrote: Hi! There is proba

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread Pali Rohár
On Thursday 17 December 2015 15:10:12 Andrey Semashev wrote: > On 2015-12-17 14:50, Andrey Semashev wrote: > >On 2015-12-17 02:44, Kamil Rytarowski wrote: > >> > >>On 16.12.2015 11:02, Pali Rohár wrote: > >>> > >>>Hi! There is probably no portable way for checking CPU type. But > >>>you do not need

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread Andrey Semashev
On 2015-12-17 14:50, Andrey Semashev wrote: On 2015-12-17 02:44, Kamil Rytarowski wrote: On 16.12.2015 11:02, Pali Rohár wrote: Hi! There is probably no portable way for checking CPU type. But you do not need to know CPU type here. You need to know if CPU has fast 64bit numeric operations (an

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread Kamil Rytarowski
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 17.12.2015 09:56, David Henningsson wrote: > > > On 2015-12-16 10:40, Kamil Rytarowski wrote: >> There is no way to check CPU type in a portable way across ABIs. >> >> Go for pa_mult_s16_volume() version without need for int64_t. >> It's actua

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread David Henningsson
On 2015-12-16 10:40, Kamil Rytarowski wrote: There is no way to check CPU type in a portable way across ABIs. Go for pa_mult_s16_volume() version without need for int64_t. It's actually the same as in src/tests/mult-s16-test.c. This change fixes build on NetBSD. --- src/pulsecore/sample-uti

Re: [pulseaudio-discuss] [PATCH v3] netbsd: Stop depending upon nonstandard __WORDSIZE

2015-12-17 Thread Pali Rohár
On Thursday 17 December 2015 00:44:03 Kamil Rytarowski wrote: > On 16.12.2015 11:02, Pali Rohár wrote: > > On Wednesday 16 December 2015 10:40:05 Kamil Rytarowski wrote: > >> There is no way to check CPU type in a portable way across ABIs. > >> > >> Go for pa_mult_s16_volume() version without need