Re: [pulseaudio-discuss] [PATCH v2] netbsd: Replace nonstandard __WORDSIZE with a more portable solution

2015-12-16 Thread Kamil Rytarowski
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.2015 12:58, Andrey Semashev wrote: > On 2015-12-15 14:47, Kamil Rytarowski wrote: >> There is no way to check CPU type in a portable way across ABIs. >> Checking for sizeof(void*) is reasonable since most platforms >> will report correct va

Re: [pulseaudio-discuss] [PATCH v2] netbsd: Replace nonstandard __WORDSIZE with a more portable solution

2015-12-16 Thread Kamil Rytarowski
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.2015 13:58, Pali Rohár wrote: > Hello! See my review notes below. > > On Tuesday 15 December 2015 12:47:40 Kamil Rytarowski wrote: >> There is no way to check CPU type in a portable way across ABIs. >> Checking for sizeof(void*) is reasona

Re: [pulseaudio-discuss] [PATCH v2] netbsd: Replace nonstandard __WORDSIZE with a more portable solution

2015-12-15 Thread Pali Rohár
Hello! See my review notes below. On Tuesday 15 December 2015 12:47:40 Kamil Rytarowski wrote: > There is no way to check CPU type in a portable way across ABIs. > Checking for sizeof(void*) is reasonable since most platforms will > report correct values. One exception is x32, but since it's halfb

Re: [pulseaudio-discuss] [PATCH v2] netbsd: Replace nonstandard __WORDSIZE with a more portable solution

2015-12-15 Thread Andrey Semashev
On 2015-12-15 14:47, Kamil Rytarowski wrote: There is no way to check CPU type in a portable way across ABIs. Checking for sizeof(void*) is reasonable since most platforms will report correct values. One exception is x32, but since it's halfbaked never finished and almost not needed any more - we

[pulseaudio-discuss] [PATCH v2] netbsd: Replace nonstandard __WORDSIZE with a more portable solution

2015-12-15 Thread Kamil Rytarowski
There is no way to check CPU type in a portable way across ABIs. Checking for sizeof(void*) is reasonable since most platforms will report correct values. One exception is x32, but since it's halfbaked never finished and almost not needed any more - we can ignore it. This change fixes build on Net