Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Michael Knox
+1, To support SLES/SLED/OpenSuSE ... +elsif FileTest.exists?("/etc/SuSE-version") + "suse" Cheers Mike On 9/06/11 6:43 AM, Adrien Thebo wrote: Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- L

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-05-31 Thread Michael Knox
From: Michael Knox Utilising Augeas's SAVE_NEWFILE mode (similar to augtool -n) to determine the changes that will be made be made by Augeas. Output a unified diff to info handle non-default root, and multiple files correctly Adding tests for Augeas diff functionality Add test for non-de

Re: [Puppet-dev] Re: (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-05-19 Thread Michael Knox
ok, hopefully this is done ... the tests now run succesfully on my branch, and with Dominic's help there's some tests for this change. On 19 May 2011 07:51, Dominic Cleal wrote: > On 17/05/11 08:14, Michael Knox wrote: > > Thanks, > > I've updated my branch based

Re: [Puppet-dev] Re: (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-05-17 Thread Michael Knox
Thanks, I've updated my branch based on comments, and it works fine with a dummy manifest that includes a single file change, changes to multiple files and changes to a file with an alternative root. Also cherry-picked Dominic's initial test cases. https://github.com/mikeknox/puppet/tree/feature/m

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-04-13 Thread Michael Knox
I've redone this to incorporate Daniel and Dominic's comments. It should also provide some performance improvement's with the Augeas type as Augeas is only run once now instead of twice per use. Cheers On 21/03/11 10:40 PM, Dominic Cleal wrote: On 21/03/11 04:00, Michael Kno

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-04-05 Thread Michael Knox
Also utilise the *.augnew file so that augeas is only run once if changes are made. Signed-off-by: Mike Knox --- Local-branch: feature/master/2728 lib/puppet/provider/augeas/augeas.rb | 36 +++-- 1 files changed, 29 insertions(+), 7 deletions(-) diff --git a/lib/pu

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Michael Knox
On 21/03/11 2:22 PM, Daniel Pittman wrote: On Sun, Mar 20, 2011 at 15:31, Michael Knox wrote: On 21/03/11 5:56 AM, Daniel Pittman wrote: Am I correct in understanding that we are writing a temporary copy for the diff, then rewriting the change to the real file separately? Yes If so, could we

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Michael Knox
Developer –http://puppetlabs.com Daniel Pittman mailto:dan...@puppetlabs.com>> Contact me via gtalk, email, or phone: +1 (877) 575-9775 Sent from a mobile device. Please forgive me if this is briefer than usual. On Mar 18, 2011 5:11 AM, "Michael Knox" <http://michael.knox.au&

[Puppet-dev] Re: [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-18 Thread Michael Knox
I haven't had a go at writing any tests yet. The changes work for me on the master and 2.6.next branches. Regards On 18/03/11 11:11 PM, Michael Knox wrote: From: Michael Knox Utilising Augeas's SAVE_NEWFILE mode (similar to augtool -n) to determine the changes that will be made be ma

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-18 Thread Michael Knox
From: Michael Knox Utilising Augeas's SAVE_NEWFILE mode (similar to augtool -n) to determine the changes that will be made be made by Augeas. Output a unified diff to info Signed-off-by: Mike Knox --- lib/puppet/provider/augeas/augeas.rb | 12 ++-- 1 files changed, 10 inser

Re: [Puppet-dev] vcsrepo type, svn, & ensure => latest

2010-07-25 Thread Michael Knox
On 22/07/10 9:30 AM, James Turnbull wrote: Michael Knox wrote: Following on from a discussion I started on puppet-users regarding the puppet-vcsrepo module. (https://groups.google.com/group/puppet-users/browse_thread/thread/954f3bb356e9a468?hl=en) Attached is a diff to address 2 issues I

[Puppet-dev] vcsrepo type, svn, & ensure => latest

2010-07-15 Thread Michael Knox
Following on from a discussion I started on puppet-users regarding the puppet-vcsrepo module. (https://groups.google.com/group/puppet-users/browse_thread/thread/954f3bb356e9a468?hl=en) Attached is a diff to address 2 issues I encountered with the puppet-vcsrepo type and svn provider. 1. When