Re: [Puppet-dev] Re: Announcement: Release of Bolt 0.19.1

Check out the hands-on lab: https://github.com/puppetlabs/tasks-hands-on-lab On Tue, May 1, 2018 at 1:14 PM Joaquin Menchaca wrote: > Any good tutorials on tasks/plans, creating tasks/plans, injecting data > into puppetdb or custom facts? Docs very sparse. For command and script, > had to wal

Re: [Puppet-dev] Puppet Provider and Type

On Wed, May 24, 2017 at 10:41 AM ggun wrote: > Writing puppet provider and type : > 1. I am trying to write my module with provider and type and every time I > run the module. I get the error 'Error: Could not find a suitable provider > ssm' > > Please find attached module. Every time I run 'pupp

Re: [Puppet-dev] Ideas for Batch Processing of Packages

On Tuesday, October 15, 2013 at 8:48 AM, Luke Kanies wrote: > That sounds awesome, Kylo. > > If, in the course of implementing this, you happen to find it easy to > implement an easy way to delay resources that might not be "ready", that > would be awesome, too. That is, if there were a hook si

Re: Anchor pattern (was Re: [Puppet-dev] Puppet 4 discussions)

On Friday, August 30, 2013 at 3:58 PM, Luke Kanies wrote: > On Aug 30, 2013, at 10:47 AM, Andy Parker (mailto:a...@puppetlabs.com)> wrote: > > > On Fri, Aug 30, 2013 at 10:24 AM, Luke Kanies > (mailto:l...@puppetlabs.com)> wrote: > > > On Aug 30, 2013, at 9:11 AM, Andy Parker > > (mailto:a...@p

Re: [Puppet-dev] Announce: PuppetDB 1.1.0 Available!

On Fri, Jan 25, 2013 at 1:02 AM, Erik Dalén wrote: > > > On Friday 25 January 2013 at 00:24, Matthaus Owens wrote: > >> Improved catalog storage performance >> >> Some improvements have been made to the way catalog hashes are >> computed for deduplication, resulting in somewhat faster catalog >> s

Re: [Puppet-dev] Re: [pe-users] Announce: PuppetDB 1.1.0 Available!

(same license as Puppet): http://github.com/puppetlabs/puppetdb/ > > >> > > > >> > Available for use with Puppet Enterprise 2.5.3 and later at > > >> > http://yum-enterprise.puppetlabs.com/ and > > >> > http://apt-enterprise.puppetlabs.c

Re: [Puppet-dev] PuppetDB reports API

we think it's more common to query for interesting events across a population rather than a whole report for a node) it seemed like the control it gave us was worth the complexity of having another format. Thanks for the feedback; it's great to see interest before it's even releas

Re: [Puppet-dev] Re: Changes to allowed function calls in Puppet 3.0

On Friday, September 14, 2012 at 1:55 PM, Alessandro Franceschi wrote: > Hi Andrew, > thank you for the notice (and thanks to Ken B. for informing me about it). > In my modules I have tons of calls to custom functions in the *arguments* of > my classes. > Things like: > class apache ( > $my_clas

Re: [Puppet-dev] How does one refer to an existing resource from a custom function?

On Monday, July 23, 2012 at 9:45 AM, Matthew Probst wrote: > Is it possible to do the following? > > Create a function foo that returns a list of references to existing > objects. > > One would call, say > > realize(foo()) > > or > > some_type { "some_name": > . > . > require => foo() > } > >

Re: [Puppet-dev] useradd: manages_passwords gone missing?

On Thursday, June 28, 2012 at 4:57 PM, Nigel Kersten wrote: > On Thu, Jun 28, 2012 at 1:37 AM, David Schmitt (mailto:da...@dasz.at)> wrote: > > > Aha! This and the resulting discussion pointed me in the right direction > > what's wrong with the machines I was looking at: they're missing > > libsh

Re: [Puppet-dev] useradd: manages_passwords gone missing?

On Wednesday, June 27, 2012 at 9:57 AM, David Schmitt wrote: > Hi, > > I just noticed that the useradd provider for the user type no longer > implements the "manages_passwords" feature. Using the Type > Reference[1][2][3][4], I was able to pinpoint that to the timeframe of the > 2.7.1/2.6.9 releas

Re: [Puppet-dev] Trying to isolate performance issues with config retrieval.

AML. So in any case, using PSON as the transmission format definitely seems optimal, and storing as PSON rather than YAML could also significantly reduce the overhead from caching it. > > Trevor > > On Mon, May 14, 2012 at 5:22 PM, Nick Lewis (mailto:n...@puppetlabs.com)> wrot

Re: [Puppet-dev] Trying to isolate performance issues with config retrieval.

On Monday, May 14, 2012 at 2:19 PM, Trevor Vaughan wrote: > Any suggestions on where to benchmark here? I tried to figure out > where to hit it but didn't really get anywhere with it. > > I did try using pure ruby to load the catalog from disk using the > Puppet methods and it took 7 seconds in a

Re: [Puppet-dev] Re: modules, violating puppet principles?

On Fri, May 11, 2012 at 8:06 PM, Philip Brown wrote: > > > On Friday, May 11, 2012 6:40:19 PM UTC-7, Jeff McCune wrote: >> >> And to jump on this... >> >> We absolutely have to make sure synchronizing plugins is fast and >> efficient. If something like stdlib is a performance issue by its nature o

Re: [Puppet-dev] Trying to isolate performance issues with config retrieval.

On Friday, May 11, 2012 at 1:25 PM, Peter Meier wrote: > > On that note: After spending a few hours hunting yesterday, we > > identified the cause of a significant performance regression in > > compilation when using modules with metadata. I've attached a patch > > for anyone who would like to test

Re: [Puppet-dev] Trying to isolate performance issues with config retrieval.

On Thursday, May 10, 2012 at 10:30 AM, Ashley Penney wrote: > On Thu, May 10, 2012 at 1:42 AM, Jeff Weiss (mailto:jeff.we...@puppetlabs.com)> wrote: > > > > Fourth, Peter, Émile, and Trevor (or anyone else experiencing the problem), > > would you be willing to be pre-release testers of improvem

Re: [Puppet-dev] how to register a "respond_to?" ?

On Wednesday, May 9, 2012 at 2:21 PM, Philip Brown wrote: > > ookay.. lots of questions, so you get lots of answers :) > I figured it would save us both time if none of my questions are helpful. :) > > I need a top level validate, not one under a newparam(). I need to ensure > that multiple pa

Re: [Puppet-dev] how to register a "respond_to?" ?

On Wednesday, May 9, 2012 at 1:55 PM, Philip Brown wrote: > I'm interested in the pattern of > > if provider.respond_to?() > > > In particular, > > provider.validate if provider.respond_to?(:validate) > > I have > > def validate > blah blah > > in my provider, but that does not seem to b

Re: [Puppet-dev] How to test functions in 2.7.X

On Tuesday, March 6, 2012 at 11:24 AM, Trevor Vaughan wrote: > Hi Nick, > > Thanks for getting back to me. > > Unfortunately, this doesn't seem to be working for me. > > I tried: > > require 'rubygems' > require 'puppet' > require 'spec' > require 'spec/mocks' > > env = Puppet::Node::Environme

Re: [Puppet-dev] How to test functions in 2.7.X

On Tuesday, March 6, 2012 at 10:03 AM, Trevor Vaughan wrote: > Sorry about the re-post, but I'm not getting much traction in the User's list. > > So, many moons ago, the following used to work: > > require 'puppet' > > Puppet::Parser::Functions::function(:mangle_ip_address) > s = Puppet::Parser:

Re: [Puppet-dev] Getting "Could not evaluate: No ability to determine if module exists" but I have an exists? method

ommand to just "su", it should work, although then you may want to wrap gemcmd in another method that adds the other arguments. > On Thu, Dec 8, 2011 at 9:52 AM, Nick Lewis (mailto:n...@puppetlabs.com)> wrote: > > On Thursday, December 8, 2011 at 9:44 AM, ghellings wrote: &g

Re: [Puppet-dev] Getting "Could not evaluate: No ability to determine if module exists" but I have an exists? method

On Thursday, December 8, 2011 at 9:44 AM, ghellings wrote: > I've been trying to create a custom provider and I keep running into > the same error > err: /Stage[main]/Rvmspokeo::Install/Rvmgem[gearman-ruby]: Could not > evaluate: No ability to determine if rvmgem exists > > My type and provider se

Re: [Puppet-dev] Differing behavior between Ruby DSL & Puppet language. Bug?

On Friday, December 2, 2011 at 10:27 AM, Jacob Helwig wrote: > So, while looking into Dominic Cleal's patch for #8011[0], I ended up > finding out (thanks to his investigation) that there is a rather large > difference in behavior for parameter/property handling between the Ruby > DSL, and the Pupp

Re: [Puppet-dev] Concerns about 0a3469752d1cd7d5b4835732204a48850214fb9d

On Sunday, November 20, 2011 at 11:25 AM, James Turnbull wrote: > Trevor Vaughan wrote: > > This was committed such that all file diffs would go into the logs. > > > > Please be very vocal about announcing this and think about turning file > > diffs off as the default. > > > > I think that most

Re: [Puppet-dev] Searching the inventory service

On Tuesday, November 22, 2011 at 11:05 AM, Carl Caum wrote: > > > On Mon, Nov 21, 2011 at 11:21 PM, Nick Lewis (mailto:n...@puppetlabs.com)> wrote: > > On Mon, Nov 21, 2011 at 9:01 PM, Carl Caum > (mailto:c...@puppetlabs.com)> wrote: > > > I have a question ab

Re: [Puppet-dev] Searching the inventory service

On Mon, Nov 21, 2011 at 9:01 PM, Carl Caum wrote: > I have a question about using the inventory service's REST API.  I have this > code: http://pastie.org/2901445 > It uses the default OpenSSL::SSL::VERIFY_PEER but the peer certificate auth > fails. I believe it's because I'm not using > the pup

Re: [Puppet-dev] (puppetlabs/puppet) New pull request: Ticket/2.7rc/9671 Transaction performance improvements

On Friday, November 11, 2011 at 3:29 PM, James Turnbull wrote: > wearetherob...@puppetlabs.com (mailto:wearetherob...@puppetlabs.com) wrote: > > Please review pull request #209: Ticket/2.7rc/9671 Transaction > > performance improvements > > opened by

Re: [Puppet-dev] [RFC/puppet 1/1] Add config.flay to metrics.rake so that flay results from metric_fu will not be empty.

On Monday, October 24, 2011 at 5:00 PM, Jacob Helwig wrote: > On Mon, 24 Oct 2011 16:47:13 -0700, Nick Lewis wrote: > > > > On Monday, October 24, 2011 at 4:40 PM, Jacob Helwig wrote: > > > While the diff definitely does what you intend to do (configure flay), I > >

Re: [Puppet-dev] [RFC/puppet 1/1] Add config.flay to metrics.rake so that flay results from metric_fu will not be empty.

On Monday, October 24, 2011 at 4:40 PM, Jacob Helwig wrote: > While the diff definitely does what you intend to do (configure flay), I > don't see how it would fix running `rake metrics:all`, since as far as I > can tell there is no such rake task (and never was). > > So, I don't know how metrics:

Re: [Puppet-dev] (puppetlabs/puppet) New pull request: Ticket/2.7.x/8410

anted to do simply for the sake of Windows support and testability. If you want to rework your change to apply to the new version of this code, I would love to get it into master ASAP. Nick Lewis -- You received this message because you are subscribed to the Google Groups "Puppet Dev

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

On Thu, Jul 28, 2011 at 11:34 PM, David Schmitt wrote: > I tried to login to redmine with openid, but just got an "internal error". > > Here's the report: > > When having unresolved parameter collisions in the dashboard, > lib/node_group_graph throws and error: > >> ActionView::TemplateError (unde

[Puppet-dev] [PATCH/puppet 3/4] (#8272) Refactor specs for Windows service provider

These were using fake objects when that's not really necessary, so replace them with real ones. Additionally, many of these specs were doing the same thing (like creating a resource), so that has been extracted to the before block. Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis ---

[Puppet-dev] [PATCH/puppet 2/4] (#8272) Use symbols instead of booleans for enabled property on Windows

in sync or not. Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/master/8272 lib/puppet/provider/service/windows.rb |4 ++-- spec/unit/provider/service/windows_spec.rb |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/puppet

[Puppet-dev] [PATCH/puppet 4/4] (#8272) Allow disabled Windows services to be started

respect that, failing to start. Thus, if the user actually wants a service to be running and disabled, they must explicitly declare that intent. Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/master/8272 lib/puppet/provider/service/windows.rb | 13

[Puppet-dev] [PATCH/puppet 1/4] (#8272) Fixup logging in Windows service provider

: Nick Lewis --- Local-branch: ticket/master/8272 lib/puppet/provider/service/windows.rb | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/puppet/provider/service/windows.rb b/lib/puppet/provider/service/windows.rb index 09754ff..56d56b0 100644 --- a/lib/puppet

[Puppet-dev] [PATCH/puppet 1/1] (#8596) Detect resource alias conflicts when titles do not match

array contained the same string. Now, we flatten the key used in the resource table, so that single element arrays are represented as strings, and will properly conflict with resource titles. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- lib/puppet/resource/catalog.rb |9

Re: [Puppet-dev] [PATCH 04/12] Remove Util::Cacher usage from SSL::CertificateAuthority

On Friday, July 22, 2011 at 10:38 AM, Daniel Pittman wrote: > On Thu, Jul 21, 2011 at 21:38, Nick Lewis (mailto:n...@puppetlabs.com)> wrote: > > Allowing the singleton_instance value to be expirable is unnecessary, > > because > > there will never be a need for a diff

[Puppet-dev] [PATCH 10/12] Remove use of Puppet::Util::Cacher in Puppet::SSL::Host

This class was previously using a cached_attr for its 'localhost' attribute, representing the Puppet::SSL::Host entry corresponding to the cert in Puppet[:certname]. We now no longer expire this attribute. This has the effect that a change to certname during the lifetime of an agent will not be ref

[Puppet-dev] [PATCH 03/12] Remove unused require 'puppet/util/cacher' from Network::HttpPool

The use of Puppet::Util::Cacher in this module was removed previously, and this stray, unnecessary require was left around. Reviewed-By: Jacob Helwig --- lib/puppet/network/http_pool.rb |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/puppet/network/http_pool.rb b/lib

[Puppet-dev] [PATCH 11/12] Rework Puppet::Util::Cacher to only expire using TTLs

We have removed every usage of cached_attr in which the attribute needs to be manually expired. Thus, the only meaningful behavior provided by Puppet::Util::Cacher is expiration based on TTLs. This commit reworks the cacher to only support that behavior. Rather than accepting an options hash, of w

[Puppet-dev] [PATCH 06/12] Remove cached_attrs from Puppet::Type::File

These values needn't be cached_attrs, because they can be managed manually. 'stat' does need to be cached, so that we avoid statting the file for each property we want to check from disk. The 'content' attribute of 'source' also needs to be cached, because it's retrieved from the server, which we c

[Puppet-dev] [PATCH 08/12] Remove Puppet::Util::Cacher use from Puppet::Indirector::Indirection

Previously, indirections were storing their termini in a cached_attr, so that they could be easily cleared for tests. Because this provides no value outside of testing, we instead simply create an attr_reader for termini, and expire them manually in tests. Reviewed-By: Jacob Helwig --- lib/puppe

[Puppet-dev] [PATCH 07/12] Remove caching from the catalog, types, and parameters

Types and parameters were registering their catalog as their expirer, so that the catalog could expire them between uses. However, because catalogs are never reused (and neither are types or parameters), there is no need to expire anything. Thus, we remove the entire cleanup/expire logic from catal

[Puppet-dev] [PATCH 12/12] Don't use non-1.8.5-compatible methods 'Object#tap' and 'Dir.mktmpdir'

These methods aren't available until Ruby 1.8.6 (Dir.mktmpdir) and Ruby 1.8.7 (Object#tap). Reviewed-By: Jacob Helwig --- lib/puppet/ssl/host.rb |9 + spec/unit/application/secret_agent_spec.rb |4 +++- spec/unit/face/secret_agent_spec.rb|4 +++- s

[Puppet-dev] [PATCH 09/12] Remove dead uses of Puppet::Util::Cacher from autoloader

In the past, Puppet::Util::Autoload used a cached_attr for its 'searchpath'. However, it no longer does that, so its references to Puppet::Util::Cacher are unnecessary. Reviewed-By: Jacob Helwig --- lib/puppet/util/autoload.rb |2 -- spec/unit/util/autoload_spec.rb |4 2 files c

[Puppet-dev] [PATCH 05/12] Remove Puppet::Util::Cacher usage from Puppet::Util::Settings

The path attribute was being unnecessarily cached. The value is a LoadedFile instance, which already knows how to check whether it needs to be reloaded. The act of reparsing was being triggered separately from the cacher mechanism. The comment indicated this value was only being cached so it could

[Puppet-dev] [PATCH 01/12] Remove use of Util::Cacher in FileServing::Configuration

This class was using Util::Cacher for its singleton instance, when that was unnecessary. The FileServing::Configuration instance already manages whether or not to reparse its config file, based on whether it has changed. Thus, there is no need for it to be manually expired via the cacher. Reviewed

[Puppet-dev] [PATCH 02/12] Remove use of Util::Cacher from FileServing::Mount::File

Allowing this value to be expirable is superfluous; it is only used on the master, which never expires its cache. Additionally, it was providing partial support for an event we don't fully support already (hostname and domain changing during the lifetime of a master). Reviewed-By: Jacob Helwig --

[Puppet-dev] [PATCH 04/12] Remove Util::Cacher usage from SSL::CertificateAuthority

Allowing the singleton_instance value to be expirable is unnecessary, because there will never be a need for a different CA instance in the lifetime of a master. Additionally, the master never expired its cache anyway. This was only using the cacher so it could be expired for tests, so it can safel

[Puppet-dev] [PATCH/puppet 1/2] Fix order-dependent test failure in certificate_status/file spec

they were also set to :file, breaking that precondition, and causing failures. Reviewed-By: Matt Robinson Signed-off-by: Nick Lewis --- .../indirector/certificate_status/file_spec.rb |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/spec/unit/indirector/certificate_s

[Puppet-dev] [PATCH/puppet 2/2] Replace calls to Array#count with #length

Array#count is not available in Ruby 1.8.5, so we need to use #length in these specs for compatibility. Reviewed-By: Matt Robinson Signed-off-by: Nick Lewis --- spec/unit/face/ca_spec.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/unit/face/ca_spec.rb b

[Puppet-dev] [PATCH/puppet] Remove Puppet::Network::HttpPool keep_alive handling

Keep alive has been disabled since 2008, and seems to have caused problems when it was enabled before then. Since there doesn't seem to be any push to get it working again, just remove it to simplify this code. This also allows us to entirely remove the usage of Puppet::Util::Cacher from HttpPool.

Re: [Puppet-dev] Review for patch on dashboard

On Wednesday, July 13, 2011 at 11:53 AM, Michael Stahnke wrote: > git-format patch was unable to handle my patch as the lines were too long. > > The only suggestion I have is to maybe link to "https://github.com/puppetlabs/puppet-dashboard/blob/v#{APP_VERSION}/README.markdown"; so you will ge

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8199) Move 'failed' resources to the top when viewing report events

controller for the partial it renders, it is a better place for this logic than the view itself. Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/master/8199 app/views/reports/_resource_statuses.html.haml |2 +- lib/core_callbacks.rb |4

Re: [Puppet-dev] [PATCH/puppet-dashboard 2/2] (#7967) Infrastructure for displaying background failures.

On Mon, Jun 20, 2011 at 5:31 PM, Josh Cooper wrote: > diff --git a/app/models/delayed_job_failure.rb > b/app/models/delayed_job_failure.rb > new file mode 100644 > index 000..c046d75 > --- /dev/null > +++ b/app/models/delayed_job_failure.rb > @@ -0,0 +1,5 @@ > +class DelayedJobFailure < Activ

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/1] Aligning node category names in sidebar.

On Monday, June 20, 2011 at 11:59 AM, Pieter van de Bruggen wrote: > This brings us closer to the desired presentation for the data, without > changing the markup in unsightly ways. This has been tested against Chrome, > Safari 5.0.4, and Firefox 4. > What is the "desired" presentation for the d

Re: [Puppet-dev] "Open Source Team" planning meeting summary 2011-06-1

On Wednesday, June 15, 2011 at 6:09 PM, Ian Ward Comfort wrote: > On 15 Jun 2011, at 9:56 AM, Dan Bode wrote: > > I just wanted to clarify something from this email. Although the best way > > to get traction for a ticket in the future will be voting in the ticketing > > system, people are alway

[Puppet-dev] [PATCH/puppet 1/1] (#7224) Add a helper to Puppet::SSL::Certificate to retrieve alternate names

ty list if the extension is absent. This will make it easier to access the entire list of possible names for a certificate, rather than just the common name; this is helpful for generating more detailed SSL error messages. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ti

[Puppet-dev] [PATCH/puppet 2/2] (#7224) Reword 'hostname was not match' error message

stion isn't available at error time, we have to use the Net::HTTP#verify_callback to capture it. Paired-With: Jacob Helwig Reviewed-By: Dominic Maraglia Signed-off-by: Nick Lewis --- Local-branch: ticket/2.7.x/7224 ...e_when_hostname_not_match_server_certificate

[Puppet-dev] Open Source team road map

ws support We'll be sending out our current iteration backlog on Wednesday, as part of our usual updates. The only significant change as of today is that we've replaced the package type v2 entries with items from the top of our road map. Nick Lewis -- You received this message because yo

[Puppet-dev] [PATCH/puppet 1/1] (#650) Allow symlinks for configuration directories

rget. Reviewed-By: Jacob Helwig Reviewed-By: Dominic Maraglia Signed-off-by: Nick Lewis --- .../tests/allow_symlinks_as_config_directories.rb | 27 lib/puppet/util/settings/file_setting.rb |1 + spec/unit/util/settings/file_setting_spec.rb |

[Puppet-dev] [PATCH/puppet 3/4] (#2128) Get facts before retrieving catalog

either the catalog or the report. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- lib/puppet/configurer.rb | 21 ++--- spec/unit/configurer_spec.rb | 24 2 files changed, 22 insertions(+), 23 deletions(-) diff --git a/lib/puppet

[Puppet-dev] [PATCH/puppet 4/4] (#2128) Add support for setting node name based on a fact

-With: Jacob Helwig Signed-off-by: Nick Lewis --- .../allow_arbitrary_node_name_fact_for_agent.rb| 46 .../allow_arbitrary_node_name_fact_for_apply.rb| 30 + lib/puppet/application/apply.rb|5 ++ lib/puppet/configurer

[Puppet-dev] [PATCH/puppet 2/4] (#2128) Add the ability to specify a node name

e certname. This is useful for eg. EC2 nodes whose random hostnames cannot be easily used to classify them. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- .../tests/allow_arbitrary_node_name_for_agent.rb | 29 .../tests/allow_arbitrary_node_name_f

[Puppet-dev] [PATCH/puppet 1/4] maint: Refactor specs in preparation for making node name more flexible

These tests were stubbing when it was unnecessary, so replace much of it with actual objects and files. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- spec/unit/application/apply_spec.rb | 95 ++--- spec/unit/configurer/fact_handler_spec.rb | 61 +-- spec/unit

[Puppet-dev] Re: [Puppet Users] Package type: enable/disable repo vs options (#2247 vs #4113)

On Thursday, June 2, 2011 at 10:16 AM, Jacob Helwig wrote: > We currently have to feature requests to add similar (or at least > overlapping) functionality to the Package type. > > #2247[1] - enablerepo and disablerepo for yum type > > #4113[2] - Provide a generic "options"-style parameter for

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On Tuesday, May 31, 2011 at 4:27 PM, Luke Kanies wrote: > Doesn't the lsbrelease fact rely on the lsb command, rather than the file? > > > Stig has confirmed that the file is always present, but not (that I know of) > the command. > The ubuntu-minimal package depends on lsb-release, which pro

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On Tuesday, May 31, 2011 at 2:24 PM, Ivan Porto Carrero wrote: > > Signed-off-by: Ivan Porto Carrero (mailto:i...@flanders.co.nz)> > --- > lib/facter/operatingsystem.rb | 4 > lib/facter/operatingsystemrelease.rb | 2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a

[Puppet-dev] [PATCH/facter 4/4] (#7670) Add an acceptance test

This test runs only on Ubuntu machines and will reproduce the problem with these steps: * load Facter * request the operatingsystem fact * clear Facter * request the operatingsystem fact and verify it is still correct Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local

[Puppet-dev] [PATCH/facter 1/4] (#7670) Never fail to find a fact that is present

r facts, we are conveniently eagerly loading them. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/master/7670 lib/facter/util/collection.rb |6 +- spec/spec_helper.rb |1 + spec/unit/interfaces_spec.rb |7 ++- spec/unit

[Puppet-dev] [PATCH/facter 3/4] maint: Fix spelling of acceptance directory

Signed-off-by: Nick Lewis --- Local-branch: ticket/master/7670 .../ticket_7039_facter_multiple_facts_one_file.rb |0 1 files changed, 0 insertions(+), 0 deletions(-) rename {accecptance => acceptance}/tests/ticket_7039_facter_multiple_facts_one_file.rb (100%) diff --git a/accecpta

[Puppet-dev] [PATCH/facter 2/4] (#7670) Stop preloading all facts in the application

that, providing results much more quickly in the case where facts do match their filenames. Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/master/7670 lib/facter/application.rb |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/f

[Puppet-dev] [PATCH/puppet 1/2] (#7681) Allow array variables as resource references

that we really do need a flattened array, we have to manually flatten it. ResourceReference expects its list of titles to be a single, flat list of titles, so we have to make it so. Paired-with: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/2.7rc/7681 lib/puppet/parser/ast

[Puppet-dev] [PATCH/puppet 2/2] (#7681) Add an acceptance test for resource refs with array variables

Paired-with: Jacob Helwig Reviewed-by: Dominic Maraglia Signed-off-by: Nick Lewis --- Local-branch: ticket/2.7rc/7681 .../language/resource_refs_with_nested_arrays.rb | 27 1 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 acceptance/tests/language

[Puppet-dev] [PATCH/puppet-dashboard 8/9] (#7007) Stream node CSV download

the entire CSV string in memory before sending it. Paired-with: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/controllers/nodes_controller.rb | 11 ++- spec/controllers/nodes_controller_spec.rb | 14 ++ 2 files changed, 20 insert

[Puppet-dev] [PATCH/puppet-dashboard 6/9] (#7007) Add support for CSV to nodes index

Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/controllers/nodes_controller.rb |1 + spec/controllers/nodes_controller_spec.rb | 76 - 2 files changed, 76 insertions(+), 1 deletions(-) diff --git a/app/controllers

[Puppet-dev] [PATCH/puppet-dashboard 1/9] maint: Make 'compliant node' factory's resource not failed

A compliant node is one without any failed resources. However, because the failed column on resource_statuses is nullable, it defaults to null. Since we weren't specifying it in this factory, the resource status wasn't being considered successful. Paired-With: Ben Hengst Signed-of

[Puppet-dev] [PATCH/puppet-dashboard 4/9] (#7007) Use a custom property list for ResourceStatus.to_csv

ell to CSV. Paired-with: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/models/resource_status.rb |4 spec/factories.rb | 23 +++ spec/models/resource_status_spec.rb | 21 + 3 files changed, 48

[Puppet-dev] [PATCH/puppet-dashboard 3/9] (#7007) Add support for CSV output

d-With: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 config/initializers/requires.rb |1 + lib/csv_extensions.rb | 42 +++ 2 files changed, 43 insertions(+), 0 deletions(-) create mode 100644 lib/csv_extensions.rb

[Puppet-dev] [PATCH/puppet-dashboard 5/9] (#7007) Add custom CSV output for nodes with resources

associated resource_status). If a node has no associated resource statuses, there will be only one line for that node, with blank entries for the resource status fields. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/models/node.rb | 40

[Puppet-dev] [PATCH/puppet-dashboard 9/9] maint: Remove debugging puts from node summary row partial

Paired-with: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/views/pages/_node_summary_row.haml |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/app/views/pages/_node_summary_row.haml b/app/views/pages/_node_summary_row.haml index bf3fb96

[Puppet-dev] [PATCH/puppet-dashboard 2/9] maint: Add resource status scopes for pending/failed

for CSV export support. Paired-With: Ben Hengst Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/models/resource_status.rb | 19 +++ spec/factories.rb | 24 spec/models/resource_status_spec.rb | 42

[Puppet-dev] [PATCH/puppet-dashboard 7/9] (#7007) Add a link to the home page to download nodes in CSV

This is a simple link to NodesController#index, which doesn't attempt to scale to support a large number of nodes, or resource statuses. It will always export the entire node list. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7007 app/views/

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7537) Add reasonable defaults for report tab names.

On Thursday, May 19, 2011 at 3:17 PM, Pieter van de Bruggen wrote: This change implements a simple algorithm to convert "registry names" into > human readable names, allowing plugins to augment the :report_view_widgets > without unnecessary fatalities. > > Reviewed-By: Daniel Pittman > > Signed-o

Re: [Puppet-dev] Should fail early when faces have syntax errors

On Monday, May 16, 2011 at 10:34 AM, Matt Robinson wrote: Contrary to the current code and ticket #7314 I think syntax errors in > Faces should raise errors immediately instead of just warning in the > log. I could be convinced otherwise, but the discussion with the > original coder of the current

[Puppet-dev] [PATCH/puppet 1/1] (#7139) Accept '/' as a valid path in filesets

This was unconditionally removing the trailing file separator ('/'), which is only valid when the file separator isn't the entire path. This fixes 'puppet resource file '. Paired-With: Jacob Helwig Signed-off-by: Nick Lewis --- lib/puppet/file_serving/fileset.rb

Re: [Puppet-dev] [PATCH] (#7269) Better error reporting for bad render formats.

On Thu, Apr 28, 2011 at 8:01 PM, Daniel Pittman wrote: > Previously we would try and send `nil` to a class to render an unsupported > format, which was bad.  Worse, we would only discover this *after* the fact, > when we tried to render, so the entire action had run and the result was lost > to th

[Puppet-dev] [PATCH/puppet 1/1] (#6928) Add a notice to Parser#validate action when using default

It was unclear what the action was validating when no arguments were specified, so now it notifies the user. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/6928 lib/puppet/face/parser.rb |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff

[Puppet-dev] [PATCH/puppet 1/1] (#7103) Fix HEAD requests in the HTTP handler

: Matt Robinson Signed-off-by: Nick Lewis --- Local-branch: ticket/next/7103 lib/puppet/network/http/handler.rb |8 spec/unit/network/http/handler_spec.rb | 18 +++--- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/lib/puppet/network/http

Re: [Puppet-dev] [PATCH/puppet 3/3] (#6928) Removed --ignoreimport

;t think that really seemed like undesirable behavior. However, we reverted this particular patch for other similar reasons (puppetdoc for instance). And reverting it does allow --ignoreimport as an option to 'puppet parser validate' to only validate the files you specify. > On Apr 13, 2011

[Puppet-dev] [PATCH/puppet 1/3] (#6928) Add a Parser face with Validate action

This will accept a number of manifests as arguments and check their syntax. If no filenames are specified, it will check the default 'manifest' setting. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/6928 lib/puppet/application/parser.rb

[Puppet-dev] [PATCH/puppet 3/3] (#6928) Removed --ignoreimport

This was only used with --parseonly, which is gone. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/6928 lib/puppet/application/agent.rb |4 lib/puppet/application/apply.rb |5 + lib/puppet/application/master.rb |5 + lib

[Puppet-dev] [PATCH/puppet 2/3] (#6928) Remove --parseonly

This has been removed in favor of 'puppet parser validate '. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/6928 lib/puppet/application/apply.rb| 23 +++--- lib/puppet/application/master.rb | 17 +++---

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7060) Use absolute paths for cert/private key

: Nick Lewis --- Local-branch: ticket/next/7060 lib/puppet_https.rb | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/puppet_https.rb b/lib/puppet_https.rb index 310af22..3577ae5 100644 --- a/lib/puppet_https.rb +++ b/lib/puppet_https.rb @@ -6,11 +6,13 @@ class

[Puppet-dev] [PATCH/puppet 1/1] (#6117) Add POST support to indirector requests

POST with a singular indirection is turned into a find in the indirector. When making a large find request from a REST terminus, POST is used, and for small requests, GET is used for backward compatibility. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/6117

[Puppet-dev] [PATCH/puppet 1/1] (#775) Don't require command when removing cron entries

Previously, if a cron entry had "ensure => absent" with no command specified and the crontab contained unmanaged entries, the entry would fail to be removed and every other cron entry in the catalog after it would be duplicated. Paired-With: Jesse Wolfe Signed-off-by: Nick Lew

[Puppet-dev] [PATCH/puppet 1/1] (#2150) Add routes file for indirector

"setup", as well as terminus settings, ie. facts_terminus. Paired-With: Jesse Wolfe Signed-off-by: Nick Lewis --- Local-branch: ticket/next/2150 lib/puppet/application.rb | 22 +++ lib/puppet/defaults.rb|1 + lib/puppet/indirector.rb | 16 +++

[Puppet-dev] [PATCH/puppet 02/12] Refactor on the way to #5063 -- removing unused Scope#level

From: Markus Roberts This attribute is apparently no longer set or accessed. Signed-off-by: Nick Lewis --- Local-branch: ticket/next/5027 lib/puppet/parser/scope.rb|4 +--- spec/unit/parser/compiler_spec.rb |4 2 files changed, 1 insertions(+), 7 deletions(-) diff --git

[Puppet-dev] [PATCH/puppet 09/12] Towards 5027 -- add options hash to lookupvar as with setvar

templates, and extends/corrects tests. As presently written it does not gather userful line numbers from inline templates and there are no tests for the template line number generation. Signed-off-by: Nick Lewis --- Local-branch: ticket/next/5027 lib/puppet/parser/ast/leaf.rb|4

[Puppet-dev] [PATCH/puppet 05/12] Refactor on the road to #5027 -- remove unused Scope#strinterp

surrounding code. Signed-off-by: Nick Lewis --- Local-branch: ticket/next/5027 lib/puppet/parser/scope.rb | 59 spec/unit/parser/scope_spec.rb | 143 2 files changed, 0 insertions(+), 202 deletions(-) diff --git a/lib/puppet/parser/scope.rb

  1   2   3   >