Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Alexandre DERUMIER
>>I just wonder where we should put the resources library - maybe >>pve-access-control  >>is the better place than pve-cluster (to avoid pve-cluster restart on >>updates).  I'll test your patches today to see how it's work, I'll keep you in touch ! - Mail original - De: "Dietmar Maure

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Alexandre DERUMIER
>>And what if bridge or vlan changes? Above only works for ip changes. Do you mean, modify bridge configuration ? or change the vm network nic config ? Libvirt do it like this, setup bridges/dhcp/ippool (restart dnsmasq) , and vm get ip through dhcp-config (without restart) I don't have tried

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
> But As you say, I think that client will try to wait around 30s for a dhcp > response, so restart could be ok too. > (Just need to avoid parallel restart, and restart only on config change) Would you like to take over development on that now? I just wonder where we should put the resources lib

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
> >>Also, how does 'dhcp-script' option helps here? > with dhcp script, you don't need to restart dnsmasq deamon to change the > config, as the dhcp-script can do something like: > > #dhcp-script.pl macaddress > parse vm config files > return ip And what if bridge or vlan changes? Above only

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Alexandre DERUMIER
>>Sure, but where to get that settings? I guess we need to extend the IPPool  >>to include that information.  yes, make sense. >>I would like to avoid any additional complexity (restart is quite easy), >>unless we run >>into a real problem. >> >>Also, how does 'dhcp-script' option helps here?

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
> + # fixme: howto pass gateway for that pool > --dhcp-option='option:router,192.168.2.1' > > + # fixme: howto pass additional dhcp options > + > --dhcp-option='option:optionnumber,optionvalue' Sure, but where to get that settings? I guess we need to extend the IPPool to include that information.

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Alexandre DERUMIER
+ # fixme: howto pass gateway for that pool  --dhcp-option='option:router,192.168.2.1' + # fixme: howto pass additional dhcp options  +  --dhcp-option='option:optionnumber,optionvalue' I'm thinking if restarting the dnsmasq daemon at each vm start is good ? (what happen if multiple vm stop/star

Re: [pve-devel] resource library

2013-09-02 Thread Alexandre DERUMIER
>>Resource-Constraints: for example, group @Customers need to use a specific >>IPPool. >> >>What do you think about that? Yes, it's really needed. I was thinking about this too. If think we should also add constraints on vmbrX and vlan. (allow customer to use only specific bridge and vlan) -

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
> Hi Dietmar, I'm a bit busy today, I'll look at it tomorrow. OK, thanks! > (for vlan, I think user need to configure manually bridgevlan vmbrXvY in > /etc/network/interfaces,It shouldn't break the current implementation. Maybe - but wanted to mention that this is not tested so far.

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Alexandre DERUMIER
Hi Dietmar, I'm a bit busy today, I'll look at it tomorrow. (for vlan, I think user need to configure manually bridgevlan vmbrXvY in /etc/network/interfaces,It shouldn't break the current implementation. - Mail original - De: "Dietmar Maurer" À: "Alexandre DERUMIER (aderum...@odis

Re: [pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
This is a naive implementation using one single dnsmasq daemon. This does not work for vlans, and only listens to interfaces with an IP address. Is this what you had in mind? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/c

[pve-devel] resource library

2013-09-02 Thread Dietmar Maurer
We need a way to manage resources like IP-Pools for dhcp. I just sent a first prototype implementation. I future, we can add other resources, or maybe even: Resource-Limits: for example traffic limit, max cpu count, ... (per pool or per VM) Resource-Constraints: for example, group @Customers ne

[pve-devel] [PATCH 2/2] setup DHCP server at vm_start

2013-09-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/DHCP.pm | 170 + PVE/Makefile |1 + PVE/QemuServer.pm |6 ++ 3 files changed, 177 insertions(+) create mode 100755 PVE/DHCP.pm diff --git a/PVE/DHCP.pm b/PVE/DHCP.pm new file mode 1007

[pve-devel] [PATCH 1/2] add ip parameter to network settings

2013-09-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/QemuServer.pm |3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4d90484..2a4f683 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1229,6 +1229,8 @@ sub parse_net { $res->{rate} = $1;

[pve-devel] [PATCH] add resource library

2013-09-02 Thread Dietmar Maurer
For now, IP pool is the only resource we have. Signed-off-by: Dietmar Maurer --- data/PVE/Cluster.pm |1 + data/PVE/Makefile.am|5 +++- data/PVE/Resource.pm| 18 +++ data/PVE/Resource/IPPool.pm | 49 +++ data/PVE