[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Antoine Pitrou added the comment: > I wasn’t sure whether we should document it? No, it should remain "hidden". -- ___ Python tracker ___ __

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Changes by Hynek Schlawack : -- components: +Library (Lib) -None stage: needs patch -> patch review ___ Python tracker ___ ___ Python-

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: And finally against 3.2 -- Added file: http://bugs.python.org/file25384/expand-chflags-catch-3.2.diff ___ Python tracker ___ _

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: This one is against tip. -- Added file: http://bugs.python.org/file25383/expand-chflags-catch-tip.diff ___ Python tracker ___

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: This is a fix for 2.7. As Benjamin said in http://bugs.python.org/issue14682#msg159477 it’s okay to back port ENOTSUP, I did it as part of the patch here. I wasn’t sure whether we should document it? I’m porting the patch to tip right now, reviews/opinions

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Éric Araujo added the comment: Trivial patches don’t require paperwork; non-trivial patches require a simple contributor agreement (print, sign, scan, email). We don’t like that either but it is required. If you have any suggestion to make the process simpler, please share them on python-de

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Fabian Groffen added the comment: I don't want to go through the paperwork nonsense just for a trivial patch, hence I didn't supply one, but instead provided all the information for you guys to make the correct fix. -- ___ Python tracker

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: I had this text ready before ned chimed in, I’ll post it anyway because it was a lot of work ;): You're right, 2.7’s errnos are incomplete compared to 3.2. Antoine added ENOTSUP in c370866f30a7 and it runs as “Solaris-specific”. So it’s currently in 3.2 and

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Ned Deily added the comment: Thanks for the analysis. Yes, it looks like there's a difference between OS X and current FreeBSDs, for example. chflags(2) on the latter is documented as returning EOPNOTSUPP and on the former ENOTSUP. shutil should check for both. A quick search of the source

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Fabian Groffen added the comment: it seems errnomodule.c has no idea of ENOTSUP, and that's not the only missing one. OSX 10.7: $ grep "^#define\sE" /usr/include/sys/errno.h | awk '{print $2}' | while read line ; do grep -q ${line} Modules/errnomodule.c || echo "missing: $line" ; done missing

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Fabian Groffen added the comment: % echo "test" > /var/tmp/testfile % python Python 2.7.3 (default, Apr 26 2012, 19:06:37) [GCC 4.2.1 (Gentoo 4.2.1_p5666, Apple Inc. build 5666) (dot 3)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import shutil >>> shuti

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: Now that’s odd. I just looked into the code at http://hg.python.org/cpython/file/2.7/Lib/shutil.py#l103 and there is a guard against EOPNOTSUPP: try: os.chflags(dst, st.st_flags) except OSError, why: if (not hasattr(errno, 'EOPNOTSUPP') or why.errno

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Fabian Groffen added the comment: > I presume Python 3.2+ have the same behavior? I cannot compile that or get it working normally, so I can't tell for sure. Judging from the code, I'd say yes. -- ___ Python tracker

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

Hynek Schlawack added the comment: I guess a “best effort” approach would be best here. I presume Python 3.2+ have the same behavior? -- nosy: +hynek ___ Python tracker ___ ___

[issue14662] shutil.move broken in 2.7.3 on OSX (chflags fails)

New submission from Fabian Groffen : With current working dir an NFS-mounted ZFS share, and /var/tmp (OSX default) HFS+: % echo "test" > /var/tmp/testfile % python Python 2.7.3 (default, Apr 24 2012, 19:33:45) [GCC 4.2.1 (Gentoo 4.2.1_p5666, Apple Inc. build 5666) (dot 3)] on darwin Type "help