[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Antoine Pitrou added the comment: Ok, should be fixed now. I fixed the proposed patch to avoid warnings when testing under Windows. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Roundup Robot added the comment: New changeset 0a1d7be10946 by Antoine Pitrou in branch 'default': Issue #14693: Under non-Windows platforms, hashlib's fallback modules are always compiled, even if OpenSSL is present at build time. http://hg.python.org/cpython/rev/0a1d7be10946 -- nosy:

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Gregory P. Smith added the comment: regarding the attached patch, rather than changing the test at all, I'd leave it as is. The test as is will do what we want on the buildbots (warning us if they failed to compile when in debug mode). I am not concerned about it testing if they compiled in

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Arfrever Frehtes Taifersar Arahesis added the comment: Python in Gentoo is also patched to always build _sha256, _sha512, _md5 and _sha1 modules. -- nosy: +Arfrever ___ Python tracker

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Changes by Martin v. Löwis : -- versions: -Python 2.6, Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Changes by Israel Fruchter : -- versions: +Python 2.6, Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Israel Fruchter added the comment: I think (2) is very important, and I agree Gregory about the distro responsibility for size. further more, if everything is define using the standard Modules/Setup, or Modules/Setup.local during compile/build time, why having a fallback anyhow in hashlib.py

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Gregory P. Smith added the comment: I don't have a problem with always compiling them. Distro packagers should see that the stand alone versions are not distributed with their package that has a dependency on openssl as they'll just be a waste of space. But that is up to the distro package m

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Martin v. Löwis added the comment: If it's an official feature that these modules are always built, the patch is insufficient: it then also needs to adjust the build environment for Windows, and the packaging. It potentially also affects packaging for OSX and Linux. I still think that users w

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Antoine Pitrou added the comment: > Antoine: why did you reopen it? Leave *at least* an explanation please. Ah, sorry. I think it's a reasonable enhancement request, and furthermore the patch simplifies the setup code. Also, it allows us to test the _md5 (etc.) modules in non-debug mode as wel

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Martin v. Löwis added the comment: Antoine: why did you reopen it? Leave *at least* an explanation please. -- ___ Python tracker ___

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Changes by Antoine Pitrou : -- resolution: works for me -> stage: needs patch -> patch review status: closed -> open ___ Python tracker ___ _

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Martin v. Löwis added the comment: The official way for building certain modules despite auto-configuration is to edit Modules/Setup, or Modules/Setup.local. This already supports the exact use case, so I'm closing this as "works for me". -- nosy: +loewis resolution: -> works for me

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Dov Feldstern added the comment: Thanks for the prompt response! Yes, this looks good, I made a very similar patch myself and it seemed to work correctly (but that was on 2.7, and I didn't know how exactly to fix up the tests...). Thanks again! -- __

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Antoine Pitrou added the comment: Actually, the modules are always compiled when in debug mode. Here is a patch to always compile them. -- keywords: +patch Added file: http://bugs.python.org/file25408/hashlibfallbacks.patch ___ Python tracker

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Changes by Antoine Pitrou : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

Antoine Pitrou added the comment: > that message requests that a bug be opened about this, but I wasn't able to > find it? Probably because no-one opened an issue. > build onto portable or shared storage, and run on multiple machines, > even if openssl happens not to be available on some of t

[issue14693] hashlib fallback modules should be built even if openssl *is* available at build time

New submission from Dov Feldstern : Python has its own implementations of various hash functions, that can be used as fallbacks when openssl is not available. However, if openssl *is* available at build time, then these fallbacks don't get built. It would be nice if they would get built even i