Re: Python guidelines cleanup

2015-08-03 Thread Jason L Tibbitts III
> "ZJ" == Zbigniew Jędrzejewski-Szmek writes: ZJ> There's a dead link in "Example common spec file". Oops, missed a colon. Fixed, thanks. ZJ> I wrote that. I turns out, which I didn't know at the time, that ZJ> this is only true for binary modules (for example python-systemd has ZJ> build/

Re: Python guidelines cleanup

2015-07-30 Thread Thomas Spura
Zbigniew Jędrzejewski-Szmek schrieb am Fr., 31. Juli 2015 um 06:06 Uhr: > On Thu, Jul 30, 2015 at 07:34:48PM -0500, Jason L Tibbitts III wrote: > > After some additional discussion and cleanup, I've gone ahead and moved > > my drafts into place in the main guidelines. Please let me know if I've

Re: Python guidelines cleanup

2015-07-30 Thread Thomas Spura
Jason L Tibbitts III schrieb am Fr., 31. Juli 2015 um 03:51 Uhr: > > "JLT" == Jason L Tibbitts writes: > > JLT> Also, When using the python_provide macro as detailed in the > JLT> guidelines, I can't seem to get fedpkg to generate an srpm: > > OK, I think a question mark somehow got converte

Re: Python guidelines cleanup

2015-07-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 30, 2015 at 07:34:48PM -0500, Jason L Tibbitts III wrote: > After some additional discussion and cleanup, I've gone ahead and moved > my drafts into place in the main guidelines. Please let me know if I've > made any mistakes or typos or left out anything important. There's a dead link

Re: Python guidelines cleanup

2015-07-30 Thread Jason L Tibbitts III
> "JLT" == Jason L Tibbitts writes: JLT> Also, When using the python_provide macro as detailed in the JLT> guidelines, I can't seem to get fedpkg to generate an srpm: OK, I think a question mark somehow got converted to a % in the draft. %{?python_provide:%python_provide python2-%{srcname}}

Re: Python guidelines cleanup

2015-07-30 Thread Jason L Tibbitts III
Also, When using the python_provide macro as detailed in the guidelines, I can't seem to get fedpkg to generate an srpm: > fedpkg srpm error: line 36: Unknown tag: ERROR: not recognized. error: query of specfile /home/tibbs/work/fpkg/python-requests/python-requests.spec failed, can't parse That

Re: Python guidelines cleanup

2015-07-30 Thread Jason L Tibbitts III
After some additional discussion and cleanup, I've gone ahead and moved my drafts into place in the main guidelines. Please let me know if I've made any mistakes or typos or left out anything important. However, there is one thing I'm trying to understand about the new guidelines (which came from

Re: Python guidelines cleanup

2015-07-30 Thread Jason L Tibbitts III
> "MH" == Miro Hrončok writes: MH> * in example spec, you mix srcname and pypi_name macros Yeah, fixed that up. MH> * For example, the python 3 version of "coverage" must ship MH>executables MH> /usr/bin/coverage, /usr/bin/coverage-2 and /usr/bin/coverage-2.7, MH> while the python 3 v

Re: Python guidelines cleanup

2015-07-30 Thread Miro Hrončok
On 28.7.2015 07:02, Jason L Tibbitts III wrote: > As many of you may be aware, FPC has been fielding several tickets > surrounding python packaging lately, and the last one was a sizable > reorganization that unfortunately was based on an older version of the > guidelines. While merging it all tog

Re: Python guidelines cleanup

2015-07-28 Thread Jason L Tibbitts III
> "BK" == Bohuslav Kabrda writes: BK> comments: BK> - I'm not sure what the "%{python_provides:%python_provide BK> python2-%{pypi_name}}" are supposed to do, did you mean to use BK> "%{?python_provide:...}" (i.e. without the "s" and with question BK> mark)? I just pasted those from one of th

Re: Python guidelines cleanup

2015-07-28 Thread Bohuslav Kabrda
- Original Message - > As many of you may be aware, FPC has been fielding several tickets > surrounding python packaging lately, and the last one was a sizable > reorganization that unfortunately was based on an older version of the > guidelines. While merging it all together I just said s