On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote:
> This series adds the support of DISCARD and WRITE_ZEROES commands
> and extends the virtio-blk-test to test WRITE_ZEROES command when
> the feature is enabled.
>
> v3:
> - rebased on master (I removed Based-on tag since the new
Patchew URL:
https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Patchew URL:
https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Patchew URL:
https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Hi Alex,
Can you queue this patch?
On 1/29/19 6:53 PM, Philippe Mathieu-Daudé wrote:
> Depending of the host hardware, copying and extracting VM images can
> take up to few minutes. Add verbosity to avoid the user to worry about
> VMs hanging.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On Thu, Feb 7, 2019 at 8:30 PM Michael S. Tsirkin wrote:
>
> On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote:
> > This series adds the support of DISCARD and WRITE_ZEROES commands
> > and extends the virtio-blk-test to test WRITE_ZEROES command when
> > the feature is enabled.
>
On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote:
> This series adds the support of DISCARD and WRITE_ZEROES commands
> and extends the virtio-blk-test to test WRITE_ZEROES command when
> the feature is enabled.
pls note and fix patchew errors:
https://patchew.org/QEMU/201902061
On 2/7/19 1:05 PM, Peter Maydell wrote:
> On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote:
>> (Someday, it would be
>> nice to turn -Wshadow on, to catch stuff like this sooner)
>
> Yes; unfortunately -Wshadow currently generates a ton of
> warnings in existing code which we'd need to fix to get
>
Patchew URL:
https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote:
> (Someday, it would be
> nice to turn -Wshadow on, to catch stuff like this sooner)
Yes; unfortunately -Wshadow currently generates a ton of
warnings in existing code which we'd need to fix to get
the noise level down...
thanks
-- PMM
lgtm.com pointed out that commit 678ba275 introduced a shadowed
declaration of local variable 'bs'; thankfully, the inner 'bs'
obtained by 'blk_bs(blk)' matches the outer one given that we had
'blk_insert_bs(blk, bs, errp)' a few lines earlier, and there are
no later uses of 'bs' beyond the scope o
On 2/7/19 12:40 PM, Peter Maydell wrote:
>
>> NBDExport *nbd_export_new(BlockDriverState *bs, off_t dev_offset, off_t
>> size,
>>const char *name, const char *description,
>> - uint16_t nbdflags, void (*close)(NBDExport *),
>> -
On 2019-02-07 17:50, Philippe Mathieu-Daudé wrote:
> On 2/5/19 1:18 AM, Philippe Mathieu-Daudé wrote:
>> Since the ahci-test uses qemu-img, add a dependency to build it
>> before using it.
>> This fixes:
>>
>> $ gmake check-qtest V=1
>> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64
>> QT
On Mon, 14 Jan 2019 at 16:47, Eric Blake wrote:
>
> We only have one caller that wants to export a bitmap name,
> which it does right after creation of the export. But there is
> still a brief window of time where an NBD client could see the
> export but not the dirty bitmap, which a robust client
FWIW, Cc'ing qemu-img maintainers.
On 2/7/19 7:00 PM, Cleber Rosa wrote:
> Tests using the avocado.utils.vmimage library make use of qemu-img,
> and because it makes sense to use the version matching the rest of the
> source code, let's make sure it gets built.
>
> Its selection, instead of a pos
Take a VhostUserState* that can be pre-allocated, and initialize it
with the associated chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Tiwei Bie
---
include/hw/virtio/vhost-user-blk.h | 2 +-
include/hw/virtio/vhost-user-scsi.h | 2 +-
include/hw/virtio/vhost-user.h | 2 +-
bac
On 2/5/19 1:18 AM, Philippe Mathieu-Daudé wrote:
> Since the ahci-test uses qemu-img, add a dependency to build it
> before using it.
> This fixes:
>
> $ gmake check-qtest V=1
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
> tests/ahci-test
> Failed to execute
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> @iov is used only to initialize @qiov. Let's use new
> qemu_iovec_init_buf() instead, which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/hw/ide/internal.h | 1 -
> hw/ide/atapi.c| 5 ++---
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> @iov is used only to initialize @qiov. Let's use new
> qemu_iovec_init_buf() instead, which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/hw/ide/internal.h | 1 -
> hw/ide/core.c | 11 +++
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new QEMU_IOVEC_INIT_BUF() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/test-bdrv-drain.c | 29 -
> 1 file changed,
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qemu-img.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> @iov is used only to initialize @qiov. Let's use new
> qemu_iovec_init_buf() instead, which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/hw/ide/internal.h | 1 -
> hw/ide/atapi.c| 9 -
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> migration/block.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 delet
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/vmdk.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qed-table.c | 16 +++-
> block/qed.c | 31 +--
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qcow2.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deleti
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qcow.c | 21 -
> 1 file changed, 4 insertions(+), 1
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new QEMU_IOVEC_INIT_BUF() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/parallels.c | 13 +
> 1 file changed, 5 insertions(+), 8 de
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new QEMU_IOVEC_INIT_BUF() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/stream.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/backup.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new QEMU_IOVEC_INIT_BUF() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/commit.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> While being here, use qemu_try_blockalign0 as well.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/io.c | 89
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new QEMU_IOVEC_INIT_BUF() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/block-backend.c | 13 ++---
> 1 file changed, 2 insertions(+),
On 2/7/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add a possibility of embedded iovec, for cases when we need only one
> local iov.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/qemu/iov.h | 64 --
> 1 file changed, 62 insertio
On 2/7/19 8:01 AM, Eric Blake wrote:
>> I think there is: we could provide for an *optional* default value. If
>> the schema specifies it, that's what 'absent' means. If it doesn't, all
>> bets are off, just like they are now.
>
> And we already have the planned syntax, thanks to our recent wor
On 2/7/19 12:56 AM, Markus Armbruster wrote:
> Max Reitz writes:
>
>> This patch allows specifying a discriminator that is an optional member
>> of the base struct. In such a case, a default value must be provided
>> that is used when no value is given.
>>
>> Signed-off-by: Max Reitz
>> ---
>
Laszlo Ersek writes:
> Hi Markus,
>
> On 02/07/19 10:30, Markus Armbruster wrote:
>> The thread got long, let me try to summarize, and elaborate a few
>> points.
>>
>> * The problem at hand is configuring firmware residing in flash memory
>> (OVMF requires this) without legacy -drive.
>>
>> *
Hi Markus,
On 02/07/19 10:30, Markus Armbruster wrote:
> The thread got long, let me try to summarize, and elaborate a few
> points.
>
> * The problem at hand is configuring firmware residing in flash memory
> (OVMF requires this) without legacy -drive.
>
> * The wider problem is configuring o
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qed-table.c | 16 +++-
block/qed.c | 31 +--
2 files changed, 12 insertions(+), 35 deletions
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/backup.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 435414e964..9988753
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
While being here, use qemu_try_blockalign0 as well.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io.c | 89 --
1 file changed, 20
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/block.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 0e2
@iov is used only to initialize @qiov. Let's use new
qemu_iovec_init_buf() instead, which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/hw/ide/internal.h | 1 -
hw/ide/atapi.c| 9 -
hw/ide/core.c | 8 ++--
3 files changed, 6 inse
Hi all!
Here is a new simple helper for a very often patter
around qemu_iovec_init_external, when we need simple qiov with only
one iov, initialized from external buffer.
v3:
01-02: tiny improvements, described in patch-emails
03-17: new patches
Note: only hw/scsi/scsi-disk.c not updated,
Use new QEMU_IOVEC_INIT_BUF() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/parallels.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 8c91b92865..
Use new QEMU_IOVEC_INIT_BUF() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/test-bdrv-drain.c | 29 -
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/tests/test-bdrv-drain
Add a possibility of embedded iovec, for cases when we need only one
local iov.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/iov.h | 64 --
1 file changed, 62 insertions(+), 2 deletions(-)
diff --git a/include/qemu/iov.h b/include/qemu
@iov is used only to initialize @qiov. Let's use new
qemu_iovec_init_buf() instead, which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/hw/ide/internal.h | 1 -
hw/ide/atapi.c| 5 ++---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/incl
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 0a235b
Use new QEMU_IOVEC_INIT_BUF() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/commit.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 53148e610b..d500a
Use new QEMU_IOVEC_INIT_BUF() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/stream.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index 7a49ac0992..e1457
Use new QEMU_IOVEC_INIT_BUF() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/block/block-backend.c b/block/block-bac
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/vmdk.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 682ad93aa1..4e331832df
@iov is used only to initialize @qiov. Let's use new
qemu_iovec_init_buf() instead, which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/hw/ide/internal.h | 1 -
hw/ide/core.c | 11 ++-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --gi
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qemu-img.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 25288c4d18..7853935049 1
The thread got long, let me try to summarize, and elaborate a few
points.
* The problem at hand is configuring firmware residing in flash memory
(OVMF requires this) without legacy -drive.
* The wider problem is configuring onboard devices. Our general device
configuration interface doesn't
Brad Smith writes:
> On 2/6/2019 3:25 PM, Alex Bennée wrote:
>
>> Brad Smith writes:
>>
>>> On 2/5/2019 8:57 AM, Brad Smith wrote:
>>>
If someone could point me in the right direction as to how the image
is created
I could look at coming up with something newer. I would prefer t
58 matches
Mail list logo
