Re: [Qemu-block] [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Eric Blake
On 2/7/19 1:05 PM, Peter Maydell wrote: > On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote: >> (Someday, it would be >> nice to turn -Wshadow on, to catch stuff like this sooner) > > Yes; unfortunately -Wshadow currently generates a ton of > warnings in existing code which we'd need to fix to get >

Re: [Qemu-block] [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Peter Maydell
On Thu, 7 Feb 2019 at 19:00, Eric Blake wrote: > (Someday, it would be > nice to turn -Wshadow on, to catch stuff like this sooner) Yes; unfortunately -Wshadow currently generates a ton of warnings in existing code which we'd need to fix to get the noise level down... thanks -- PMM

Re: [Qemu-block] [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Eric Blake
On 2/7/19 12:40 PM, Peter Maydell wrote: > >> NBDExport *nbd_export_new(BlockDriverState *bs, off_t dev_offset, off_t >> size, >>const char *name, const char *description, >> - uint16_t nbdflags, void (*close)(NBDExport *), >> -

Re: [Qemu-block] [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-02-07 Thread Peter Maydell
On Mon, 14 Jan 2019 at 16:47, Eric Blake wrote: > > We only have one caller that wants to export a bitmap name, > which it does right after creation of the export. But there is > still a brief window of time where an NBD client could see the > export but not the dirty bitmap, which a robust client