Re: [RFC PATCH 0/2] Pegasos2 emulation

2021-01-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1609973005.git.bala...@eik.bme.hu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1609973005.git.bala...@eik.bme.hu Subject: [RFC PATCH 0/2] Pegasos2 emulation === TEST

Re: [RFC PATCH 0/2] Pegasos2 emulation

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/7/21 2:15 AM, BALATON Zoltan wrote: > On Wed, 6 Jan 2021, BALATON Zoltan wrote: >> Hello, >> >> This is adding a new PPC board called pegasos2 currently posted as RFC >> because it depends on not yet merged VT8231 emulation currently on the >> list: >> >> https://patchew.org/QEMU/cover.1609967

[PATCH] tests/docker: Remove Debian 9 remnant lines

2021-01-06 Thread Philippe Mathieu-Daudé
Debian 9 base container has been removed in commits e3755276d1f and c9d78b06c06. Remove the last remnants. Fixes: e3755276d1f ("tests/docker: Remove old Debian 9 containers") Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 3/4] whpx: Fixes include of whp-dispatch.h in whpx.h

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/7/21 6:38 AM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > include/sysemu/whpx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h > index 9346fd92e9..0e6c9faaf6 100644 > --- a/include/sysemu/whpx.h > +++ b/in

Re: [PATCH 4/4] maintainers: Add me as Windows Hosted Continuous Integration maintainer

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/7/21 6:38 AM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4be087b88e..4d9df874a1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3198,6 +3198,12 @@ S: Maintained >

Re: [PATCH 1/4] cirrus/msys2: Exit powershell with $LastExitCode

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/7/21 6:38 AM, Yonggang Luo wrote: > Currently if we don't exit with $LastExitCode manually, > the cirrus would not report the build/testing failure. > > Signed-off-by: Yonggang Luo > --- > .cirrus.yml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4] gdb: riscv: Add target description

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/6/21 9:41 PM, Sylvain Pelissier wrote: > Target description is not currently implemented in RISC-V > architecture. Thus GDB won't set it properly when attached. > The patch implements the target description response. > > Signed-off-by: Sylvain Pelissier > Reviewed-by: Bin Meng > Reviewed-by

Re: [PATCH v3 1/3] update-linux-headers: Include const.h

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/4/21 9:20 PM, Eric Farman wrote: > Kernel commit a85cbe6159ff ("uapi: move constants from > to ") breaks our script > because of the unrecognized include. Let's add that to > our processing. > > Signed-off-by: Eric Farman > --- > scripts/update-linux-headers.sh | 5 - > 1 file changed,

Re: [PATCH] docs/system: Remove deprecated 'fulong2e' machine alias

2021-01-06 Thread Thomas Huth
Am Wed, 6 Jan 2021 19:46:02 +0100 schrieb Philippe Mathieu-Daudé : > The 'fulong2e' machine alias has been marked as deprecated since > QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e'). > Time to remove it now. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/dep

Re: [PATCH] docs/system: Remove deprecated 'fulong2e' machine alias

2021-01-06 Thread Huacai Chen
Reviewed-by: Huacai Chen On Thu, Jan 7, 2021 at 2:46 AM Philippe Mathieu-Daudé wrote: > > The 'fulong2e' machine alias has been marked as deprecated since > QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e'). > Time to remove it now. > > Signed-off-by: Philippe Mathieu-Daudé > -

Re: [PATCH v3 3/8] acpi/gpex: Inform os to keep firmware resource map

2021-01-06 Thread Jiahui Cen
On 2021/1/6 21:29, Igor Mammedov wrote: > On Tue, 5 Jan 2021 09:53:49 +0800 > Jiahui Cen wrote: > >> On 2021/1/5 8:35, Igor Mammedov wrote: >>> On Wed, 30 Dec 2020 16:22:08 -0500 >>> "Michael S. Tsirkin" wrote: >>> On Tue, Dec 29, 2020 at 02:41:42PM +0100, Igor Mammedov wrote: >

Re: [PATCH v4 6/7] fuzz: add minimization options

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > -M1: loop around the remove minimizer > -M2: try setting bits in operand of write/out to zero > Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov > --- > scripts/oss-fuzz/minimize_qtest_trace.py | 32 +++- > 1 file changed, 26 insert

[PATCH 4/4] maintainers: Add me as Windows Hosted Continuous Integration maintainer

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4be087b88e..4d9df874a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3198,6 +3198,12 @@ S: Maintained F: .cirrus.yml W: https://cirrus-ci.com/github/qemu/qemu

[PATCH 2/4] cirrus/msys2: Cache msys2 mingw in a better way.

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 117 ++-- 1 file changed, 68 insertions(+), 49 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index ff6adabd0d..6f2a958472 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -58,23 +58,61 @@ windows_msy

[PATCH 3/4] whpx: Fixes include of whp-dispatch.h in whpx.h

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 9346fd92e9..0e6c9faaf6 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -15,7 +15,7 @@ #ifdef CONFIG_WH

[PATCH 1/4] cirrus/msys2: Exit powershell with $LastExitCode

2021-01-06 Thread Yonggang Luo
Currently if we don't exit with $LastExitCode manually, the cirrus would not report the build/testing failure. Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 62a9b57530..ff6adabd0d 100644 --- a/.cirrus.yml +++ b/.

[PATCH 0/4] Fixes whpx build and improve Windows host CI

2021-01-06 Thread Yonggang Luo
Exit powershell with $LastExitCode so that the CI would report the build/testing failure Fixes include of whp-dispatch.h Cache msys2 mingw with a proper fingerprint so that only when msys2 packages are changed need trigger the re-populate the cache Yonggang Luo (4): cirrus/msys2: Exit powershell

Re: [PATCH v4 5/7] fuzz: set bits in operand of write/out to zero

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > Simplifying the crash cases by opportunistically setting bits in operands of > out/write to zero may help to debug, since usually bit one means turn on or > trigger a function while zero is the default turn-off setting. > > Tested Bug 1908062. > > Signed-off-by:

Re: [PATCH v4 4/7] fuzz: loop the remove minimizer and refactoring

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > Now we use a one-time scan and remove strategy in the remval minimizer, > which is not suitable for timing dependent instructions. > > For example, instruction A will indicate an address where the config > chunk locates, and instruction B will make the configurat

Re: [PATCH v4 3/7] fuzz: split write operand using binary approach

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > Currently, we split the write commands' data from the middle. If it does not > work, try to move the pivot left by one byte and retry until there is no > space. > > But, this method has two flaws: > > 1. It may fail to trim all unnecessary bytes on the right sid

Re: [PATCH v4 2/7] fuzz: double the IOs to remove for every loop

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > Instead of removing IO instructions one by one, we can try deleting multiple > instructions at once. According to the locality of reference, we double the > number of instructions to remove for the next round and recover it to one > once we fail. > > This patch i

Re: [PATCH v4 1/7] fuzz: accelerate non-crash detection

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > We spend much time waiting for the timeout program during the minimization > process until it passes a time limit. This patch hacks the CLOSED (indicates > the redirection file closed) notification in QTest's output if it doesn't > crash. > > Test with quadrupled

Re: [PATCH v2 02/24] target/mips/translate: Expose check_mips_64() to 32-bit mode

2021-01-06 Thread Jiaxun Yang
在 2021/1/7 上午2:37, Philippe Mathieu-Daudé 写道: On Wed, Jan 6, 2021 at 7:20 PM Philippe Mathieu-Daudé wrote: Hi, ping for code review? :) FWIW the full series (rebased on mips-next) is available here: https://gitlab.com/philmd/qemu/-/commits/mips_msa_decodetree Reviewed-by: Jiaxun Yang - Ji

Re: [PATCH v4 1/7] fuzz: accelerate non-crash detection

2021-01-06 Thread Alexander Bulekov
On 201229 1240, Qiuhao Li wrote: > We spend much time waiting for the timeout program during the minimization > process until it passes a time limit. This patch hacks the CLOSED (indicates > the redirection file closed) notification in QTest's output if it doesn't > crash. > > Test with quadrupled

[Bug 1909418] Re: QEMU: Heap Overflow vulnerability in SDHCI Component

2021-01-06 Thread Muhammad Ramdhan
** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909418 Title: QEMU: Heap Overflow vulnerability in SDHCI Component Status in QEM

Re: [RFC PATCH 0/2] Pegasos2 emulation

2021-01-06 Thread BALATON Zoltan
On Wed, 6 Jan 2021, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2 currently posted as RFC because it depends on not yet merged VT8231 emulation currently on the list: https://patchew.org/QEMU/cover.1609967638.git.bala...@eik.bme.hu/ and may need some changes like

[Bug 1901359] Re: ignore bit 0 in pci CONFIG_ADDRESS register write for Type 1 access

2021-01-06 Thread cinap_lenrek
is anybody home? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1901359 Title: ignore bit 0 in pci CONFIG_ADDRESS register write for Type 1 access Status in QEMU: New Bug description: I'v rece

Re: [RFC PATCH 0/2] Pegasos2 emulation

2021-01-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1609973005.git.bala...@eik.bme.hu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1609973005.git.bala...@eik.bme.hu Subject: [RFC PATCH 0/2] Pegasos2 emulation === TEST

[RFC PATCH 2/2] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-01-06 Thread BALATON Zoltan
Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC board based on the Marvell MV64361 system controller and the VIA VT8231 integrated south bridge/superio chips. It can run Linux, AmigaOS and a wide range of MorphOS versions. Currently a firmware ROM image is needed to

[RFC PATCH 1/2] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-01-06 Thread BALATON Zoltan
The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on this board. The mv643xx.h header with register definitions is taken from Linux 4.15.10 only fixing end of line

[RFC PATCH 0/2] Pegasos2 emulation

2021-01-06 Thread BALATON Zoltan
Hello, This is adding a new PPC board called pegasos2 currently posted as RFC because it depends on not yet merged VT8231 emulation currently on the list: https://patchew.org/QEMU/cover.1609967638.git.bala...@eik.bme.hu/ and may need some changes like a test case but I'm posting it now for getti

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Snoobz
** Attachment added: "core.282" https://bugs.launchpad.net/qemu/+bug/1909921/+attachment/5449852/+files/core.282 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909921 Title: Raspberry Pi 4 qem

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Snoobz
** Attachment added: "core.300" https://bugs.launchpad.net/qemu/+bug/1909921/+attachment/5449851/+files/core.300 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909921 Title: Raspberry Pi 4 qem

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Snoobz
If you can't see the core dumps, provide me with a file hoster where I can upload them. They are around 180mb each. Feel free to ask more test to find a solution to this matter. Thank you! Regards, -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Snoobz
Hello, If I do as mentionned this command: qemu-i386 -d unimp ./ts3server I get this output : 2021-01-06 22:45:26.201997|INFO|ServerLibPriv | |TeamSpeak 3 Server 3.13.3 (2020-12-16 14:17:05) 2021-01-06 22:45:26.225836|INFO|ServerLibPriv | |SystemInformation: Linux 4.18.0-193.28.1.e

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Peter Maydell
If you run QEMU with the '-d unimp' option (if that's awkward, set the environment variable QEMU_LOG to 'unimp' instead) does QEMU print any messages about unimplemented functionality? (In https://bugs.launchpad.net/qemu/+bug/1619896 somebody else was trying to run TeamSpeak 3 Server, which fails b

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-06 Thread Snoobz
Hello, Can I get any help please? Thank you. Regards, -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909921 Title: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @

[PATCH 08/12] vt82c686: Fix superio_cfg_{read,write}() functions

2021-01-06 Thread BALATON Zoltan
These functions are memory region callbacks so we have to check against relative address not the mapped address. Also reduce indentation by returning early and log unimplemented accesses. Additionally we remove separate index value from SuperIOConfig and store the index at reg 0 which is reserved a

[PATCH 02/12] vt82c686: Reorganise code

2021-01-06 Thread BALATON Zoltan
Move lines around so that object definitions become consecutive and not scattered around. This brings functions belonging to an object together so it's clearer what is defined and what parts belong to which object. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 279 +++

[PATCH 03/12] vt82c686: Fix SMBus IO base and configuration registers

2021-01-06 Thread BALATON Zoltan
The base address of the SMBus io ports and its enabled status is set by registers in the PCI config space but this was not correctly emulated. Instead the SMBus registers were mapped on realize to the base address set by a property to the address expected by fuloong2e firmware. Fix the base and co

[PATCH 09/12] vt82c686: Implement control of serial port io ranges via config regs

2021-01-06 Thread BALATON Zoltan
In VIA super south bridge the io ranges of superio components (parallel and serial ports and FDC) can be controlled by superio config registers to set their base address and enable/disable them. This is not easy to implement in QEMU because ISA emulation is only designed to set io base address once

[PATCH 12/12] vt82c686: Add emulation of VT8231 south bridge

2021-01-06 Thread BALATON Zoltan
Add emulation of VT8231 south bridge ISA part based on the similar VT82C686B but implemented in a separate subclass that holds the differences while reusing parts that can be shared. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 152 ++ include

[PATCH 07/12] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-06 Thread BALATON Zoltan
Currently the ISA devices that are part of the VIA south bridge, superio chip are wired up by board code. Move creation of these ISA devices to the VIA ISA bridge model so that board code does not need to access ISA bus. This also allows vt82c686b-superio to be made internal to vt82c686 which allow

[PATCH 01/12] vt82c686: Move superio memory region to SuperIOConfig struct

2021-01-06 Thread BALATON Zoltan
The superio memory region holds the io space index/data registers used to access the superio config registers that are implemented in struct SuperIOConfig. To keep these related things together move the memory region to SuperIOConfig and rename it accordingly. Also remove the unused "data" member o

[PATCH 06/12] vt82c686: Simplify vt82c686b_realize()

2021-01-06 Thread BALATON Zoltan
Remove unneeded variables and setting value to 0 on zero initialised data and replace check for error with error_fatal. Rationalise loop that sets PCI config header fields read only. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 20 ++-- 1 file changed, 6 insertions(+), 1

[PATCH 04/12] vt82c686: Fix up power management io base and config

2021-01-06 Thread BALATON Zoltan
Similar to the SMBus io registers there is a power management io range that is set via similar base address reg and enable bit. Some handling of this was already there but with several problems: using the wrong registers and bits, wrong size range, not acually updating mapping and handling reset co

[PATCH 11/12] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO

2021-01-06 Thread BALATON Zoltan
The VT8231 south bridge is very similar to VT82C686B but there are some differences in register addresses and functionality, e.g. the VT8231 only has one serial port. This commit adds VT8231_SUPERIO subclass based on the abstract VIA_SUPERIO class to emulate the superio part of VT8231. Signed-off-

[PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

2021-01-06 Thread BALATON Zoltan
The vt82c686b-pm model can be shared between VT82C686B and VT8231. The only difference between the two is the device id in what we emulate so make an abstract via-pm model by renaming appropriately and add types for vt82c686b-pm and vt8231-pm based on it. Signed-off-by: BALATON Zoltan --- hw/isa

[PATCH 10/12] vt82c686: QOM-ify superio related functionality

2021-01-06 Thread BALATON Zoltan
Collect superio functionality and its controlling config registers handling in an abstract VIA_SUPERIO class that is a subclass of ISA_SUPERIO and put vt82c686b specific parts in a subclass of this abstract class. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 240

[PATCH 00/12] vt82c686b clean ups and vt8231 emulation

2021-01-06 Thread BALATON Zoltan
These are the remaining patches for VT8231 emulation after the first half of it was merged. After patch 3 fuloong2e will need the Bonito REG_MASK fix to be able to map SMBus registers because it's no longer mapped at fixed address (firmware will do this if it can access the right register). BALATO

Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration

2021-01-06 Thread BALATON Zoltan
On Wed, 6 Jan 2021, Paolo Bonzini wrote: Il mer 6 gen 2021, 18:06 BALATON Zoltan ha scritto: On Thu, 17 Dec 2020, Paolo Bonzini wrote: Due to the renumbering of text consoles when graphical consoles are created, init_displaystate must be called after all QemuConsoles are created, i.e. after d

Re: [PATCH V2 05/22] vl: memfd-alloc option

2021-01-06 Thread Steven Sistare
On 1/6/2021 3:10 PM, Paolo Bonzini wrote: > Il mer 6 gen 2021, 17:37 Steven Sistare > ha scritto: > > Yes, I considered that, but there are other memory regions that cannot be > controlled > by the command line but which must be preserved, such as vram,

[PATCH v4] gdb: riscv: Add target description

2021-01-06 Thread Sylvain Pelissier
Target description is not currently implemented in RISC-V architecture. Thus GDB won't set it properly when attached. The patch implements the target description response. Signed-off-by: Sylvain Pelissier Reviewed-by: Bin Meng Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 13 +

[PATCH V1] gdbstub: suspended state support

2021-01-06 Thread Steve Sistare
Modify the gdb server so a continue command appears to resume execution when in RUN_STATE_SUSPENDED. Do not print the next gdb prompt, but do not actually resume instruction fetch. While in this "fake" running mode, a ctrl-C returns the user to the gdb prompt. Signed-off-by: Steve Sistare ---

[PATCH v3] vl: pause option

2021-01-06 Thread Steve Sistare
Provide the -pause command-line parameter and the QEMU_PAUSE environment variable to pause QEMU during process startup and allow a developer to attach a debugger, or observe the process using tools such as strace. Useful when QEMU has been launched with some other entity, such as libvirt. QEMU_PAUS

Re: [PATCH V2] vl: pause option

2021-01-06 Thread Steven Sistare
On 11/5/2020 9:55 AM, Steven Sistare wrote: > On 11/4/2020 4:40 PM, Alex Bennée wrote: >> Eric Blake writes: >>> On 11/2/20 9:50 AM, Steve Sistare wrote: Provide the -pause command-line parameter and the QEMU_PAUSE environment variable to pause QEMU during process startup using SIGSTOP a

[PULL v4 4/4] cirrus: don't run full qtest on macOS

2021-01-06 Thread Alex Bennée
From: Daniel P. Berrangé The Cirrus CI macOS build hosts have exhibited a serious performance degradation in recent months. For example the "qom-test" qtest takes over an hour for only the qemu-system-aarch64 binary. This is as much 20-40 times slower than other environments. The other qtests all

[PULL v4 0/4] more testing fixes (all green now)

2021-01-06 Thread Alex Bennée
The following changes since commit aadac5b3d9fdce28030495f80fc76a4336e97328: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-01-06 15:55:29 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-060121-

[PULL v4 3/4] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-06 Thread Alex Bennée
The read binary data as text via a PPM export of the frame buffer seems a bit sketchy and it did blow up in the real world when the assertion failed: https://gitlab.com/qemu-project/qemu/-/jobs/943183183 However short of cleaning up the test to be more binary focused at least limit the attempt

[PULL v4 2/4] tests/iotests: drop test 312 from auto group

2021-01-06 Thread Alex Bennée
The "auto" documentation states: That means they should run with every QEMU binary (also non-x86) which is not the case as the check-system-fedora build which only includes a rag tag group of rare and deprecated targets doesn't support the virtio device required. Fixes: ef9bba1484b ("quorum: I

[PULL v4 1/4] tests/docker: Include 'ccache' in Debian base image

2021-01-06 Thread Alex Bennée
From: Philippe Mathieu-Daudé Include the 'ccache' package to speed up compilation. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201213211601.253530-1-f4...@amsat.org> Fixes: d6db2a1cdf ("docker: add debian-buster-arm64-cross") Signed-off-by: Alex Bennée diff --git a/tests/docker/docke

Re: [PATCH V2 05/22] vl: memfd-alloc option

2021-01-06 Thread Paolo Bonzini
Il mer 6 gen 2021, 17:37 Steven Sistare ha scritto: > Yes, I considered that, but there are other memory regions that cannot be > controlled > by the command line but which must be preserved, such as vram, bios, and > rom. If vram > is not preserved, parts of the screen will be blank until the u

Re: [PATCH v2 1/1] vl.c: do not execute trace_init_backends() before daemonizing

2021-01-06 Thread Paolo Bonzini
Il mer 6 gen 2021, 17:59 Stefan Hajnoczi ha scritto: > Acked-by: Stefan Hajnoczi

Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration

2021-01-06 Thread Paolo Bonzini
Il mer 6 gen 2021, 18:06 BALATON Zoltan ha scritto: > On Thu, 17 Dec 2020, Paolo Bonzini wrote: > > Due to the renumbering of text consoles when graphical consoles are > > created, init_displaystate must be called after all QemuConsoles are > > created, i.e. after devices are created. > > > > vl.

[Bug 1829459] Re: qemu seems to lack support for pid namespace.

2021-01-06 Thread -
The same issue persists in qemu-5.2.0. - # qemu-aarch64 --version qemu-aarch64 version 5.2.0 Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers - Symptoms when running inside the aarch64 chroot, w

Re: [Linuxarm] Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-01-06 Thread Ben Widawsky
On 21-01-06 10:05:57, Ben Widawsky wrote: > On 21-01-06 17:40:14, Jonathan Cameron wrote: > > On Wed, 6 Jan 2021 13:21:23 + > > Jonathan Cameron wrote: > > > > > On Tue, 5 Jan 2021 08:52:58 -0800 > > > Ben Widawsky wrote: > > > [snip] > > I'm sorry you had to debug this. I had fixed this

Re: [PATCH v3 1/3] update-linux-headers: Include const.h

2021-01-06 Thread Peter Xu
On Mon, Jan 04, 2021 at 09:20:55PM +0100, Eric Farman wrote: > Kernel commit a85cbe6159ff ("uapi: move constants from > to ") breaks our script > because of the unrecognized include. Let's add that to > our processing. > > Signed-off-by: Eric Farman > --- > scripts/update-linux-headers.sh | 5 +

[PATCH] docs/system: Remove deprecated 'fulong2e' machine alias

2021-01-06 Thread Philippe Mathieu-Daudé
The 'fulong2e' machine alias has been marked as deprecated since QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e'). Time to remove it now. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 5 - docs/system/removed-features.rst | 5 + hw/mips/fu

Re: [PATCH v2 02/24] target/mips/translate: Expose check_mips_64() to 32-bit mode

2021-01-06 Thread Philippe Mathieu-Daudé
On Wed, Jan 6, 2021 at 7:20 PM Philippe Mathieu-Daudé wrote: > > Hi, > > ping for code review? :) FWIW the full series (rebased on mips-next) is available here: https://gitlab.com/philmd/qemu/-/commits/mips_msa_decodetree > > Due to the "Simplify ISA definitions" > https://www.mail-archive.com/q

Re: [PATCH v2 02/24] target/mips/translate: Expose check_mips_64() to 32-bit mode

2021-01-06 Thread Philippe Mathieu-Daudé
Hi, ping for code review? :) Due to the "Simplify ISA definitions" https://www.mail-archive.com/qemu-devel@nongnu.org/msg770056.html patch #3 is not necessary. This is the last patch unreviewed. On 12/15/20 11:57 PM, Philippe Mathieu-Daudé wrote: > To allow compiling 64-bit specific translation

Re: [PATCH 6/6] spapr: Model DR connectors as simple objects

2021-01-06 Thread Greg Kurz
On Mon, 28 Dec 2020 19:28:39 +1100 David Gibson wrote: > On Fri, Dec 18, 2020 at 11:34:00AM +0100, Greg Kurz wrote: > > Modeling DR connectors as individual devices raises some > > concerns, as already discussed a year ago in this thread: > > > > https://patchew.org/QEMU/20191017205953.13122-1-c

Re: [Linuxarm] Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-01-06 Thread Ben Widawsky
On 21-01-06 17:40:14, Jonathan Cameron wrote: > On Wed, 6 Jan 2021 13:21:23 + > Jonathan Cameron wrote: > > > On Tue, 5 Jan 2021 08:52:58 -0800 > > Ben Widawsky wrote: > > > > > This is the beginning of implementing mailbox support for CXL 2.0 > > > devices. > > > > > > v2: Use register al

Re: [PATCH v3 00/15] target/mips/mips-defs: Simplify ISA definitions

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/4/21 11:11 PM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daud=C3=A9 (15): > target/mips/mips-defs: Remove USE_HOST_FLOAT_REGS comment > target/mips/mips-defs: Reorder CPU_MIPS5 definition > target/mips/mips-defs: Rename CPU_MIPSxx Release 1 as CPU_MIPSxxR1 > target/mips/mips-def

Re: [PATCH v3 04/15] target/mips/mips-defs: Introduce CPU_MIPS64 and cpu_type_is_64bit()

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/5/21 5:01 PM, Richard Henderson wrote: > On 1/5/21 12:05 AM, Philippe Mathieu-Daudé wrote: >> I'm not sure it is worth the effort, as I plan to check each ISA / >> ASE bit from the CP0_ConfigX bits (similarly target/arm/ does), so >> these definitions should disappear eventually. > > Excellen

Re: [PATCH v2 0/8] MIPS Bootloader helper

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/3/21 9:42 PM, Philippe Mathieu-Daudé wrote: > On 12/15/20 7:41 AM, Jiaxun Yang wrote: >> v2: >> A big reconstruction. rewrite helpers with CPU feature and sepreate >> changesets. >> >> Jiaxun Yang (8): >> hw/mips: Make bootloader addresses unsgined >> hw/mips/malta: Use address translation

Re: [PATCH v2 5/8] hw/mips: Use bl_gen_kernel_jump to generate bootloaders

2021-01-06 Thread Philippe Mathieu-Daudé
+Alex On 12/15/20 7:45 AM, Jiaxun Yang wrote: > Replace embedded binary with generated code. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/boston.c| 17 ++--- > hw/mips/fuloong2e.c | 28 > hw/mips/malta.c | 41 ++-

Re: [Linuxarm] Re: [RFC PATCH v2 07/32] hw/cxl/device: Implement basic mailbox (8.2.8.4)

2021-01-06 Thread Jonathan Cameron
On Wed, 6 Jan 2021 13:21:23 + Jonathan Cameron wrote: > On Tue, 5 Jan 2021 08:52:58 -0800 > Ben Widawsky wrote: > > > This is the beginning of implementing mailbox support for CXL 2.0 > > devices. > > > > v2: Use register alignment helper (Ben) > > Minor cleanups (Jonathan) > > Ren

Re: [PATCH v2 8/8] hw/mips/boston: Use bootloader helper to set GCRs

2021-01-06 Thread Philippe Mathieu-Daudé
On Wed, Jan 6, 2021 at 6:30 PM Philippe Mathieu-Daudé wrote: > On Wed, Jan 6, 2021 at 6:28 PM Philippe Mathieu-Daudé wrote: > > On 12/15/20 7:46 AM, Jiaxun Yang wrote: > > > Translate embedded assembly into IO writes which is more > > > readable. > > > > > > Also hardcode cm_base at boot time ins

Re: [PATCH v2 8/8] hw/mips/boston: Use bootloader helper to set GCRs

2021-01-06 Thread Philippe Mathieu-Daudé
On Wed, Jan 6, 2021 at 6:28 PM Philippe Mathieu-Daudé wrote: > > On 12/15/20 7:46 AM, Jiaxun Yang wrote: > > Translate embedded assembly into IO writes which is more > > readable. > > > > Also hardcode cm_base at boot time instead of reading from CP0. > > > > Signed-off-by: Jiaxun Yang > > --- >

Re: [PATCH v2 8/8] hw/mips/boston: Use bootloader helper to set GCRs

2021-01-06 Thread Philippe Mathieu-Daudé
On 12/15/20 7:46 AM, Jiaxun Yang wrote: > Translate embedded assembly into IO writes which is more > readable. > > Also hardcode cm_base at boot time instead of reading from CP0. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/boston.c | 45 - > 1 file

Re: [PULL v3 00/52] Misc patches for 2020-12-21

2021-01-06 Thread Peter Maydell
On Wed, 6 Jan 2021 at 14:57, Paolo Bonzini wrote: > > The following changes since commit 41192db338588051f21501abc13743e62b0a5605: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 > 22:57:15 +) > > are available in the Git rep

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Eduardo Habkost
On Wed, Jan 06, 2021 at 05:45:42PM +0100, Igor Mammedov wrote: > On Wed, 06 Jan 2021 14:38:56 +0100 > Vitaly Kuznetsov wrote: > > > Igor Mammedov writes: > > > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > > Vitaly Kuznetsov wrote: > > > > > >> Igor Mammedov writes: > > >> > > >> > On Tue,

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-06 Thread Igor Mammedov
On Thu, 31 Dec 2020 00:13:01 +0200 Marian Posteuca wrote: > Qemu's ACPI table generation sets the fields OEM ID and OEM table ID > to "BOCHS " and "BXPC" where "" is replaced by the ACPI > table name. > > Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID > and OEM table

Re: [PATCH v2 7/8] hw/mips/malta: Use bootloader helper to set BAR resgiters

2021-01-06 Thread Philippe Mathieu-Daudé
On 12/15/20 7:45 AM, Jiaxun Yang wrote: > Translate embedded assembly into IO writes which is more > readable. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/malta.c | 68 ++--- > 1 file changed, 19 insertions(+), 49 deletions(-) Reviewed-by: Philippe

Re: [PATCH v2 2/2] tests: Collapse echoed JSON input to a single line

2021-01-06 Thread David Edmondson
On Wednesday, 2021-01-06 at 10:49:06 +01, Max Reitz wrote: > On 21.12.20 14:49, David Edmondson wrote: >> When sending JSON to running qemu, qemu-io, etc. instances, flatten >> the echoed input to a single line to ensure that comparisons with the >> expected input (which is always a single line) a

Re: [RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-06 Thread Ben Widawsky
On 21-01-06 17:06:41, Jonathan Cameron wrote: > On Wed, 6 Jan 2021 08:49:48 -0800 > Ben Widawsky wrote: > > > On 21-01-06 13:28:05, Jonathan Cameron wrote: > > > On Tue, 5 Jan 2021 08:52:56 -0800 > > > Ben Widawsky wrote: > > > > > > > This implements all device MMIO up to the first capabilit

Re: [PULL v2 00/53] Misc patches for 2020-12-21

2021-01-06 Thread Paolo Bonzini
I have already sent the v3, so you may want to wait a day or two. The good thing of conversion patches is that if they break something you can just drop them. :) Paolo Il mer 6 gen 2021, 17:56 Alex Bennée ha scritto: > > Peter Maydell writes: > > > On Mon, 4 Jan 2021 at 14:44, Paolo Bonzini w

Re: [RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-06 Thread Jonathan Cameron
On Wed, 6 Jan 2021 08:49:48 -0800 Ben Widawsky wrote: > On 21-01-06 13:28:05, Jonathan Cameron wrote: > > On Tue, 5 Jan 2021 08:52:56 -0800 > > Ben Widawsky wrote: > > > > > This implements all device MMIO up to the first capability .That > > > includes the CXL Device Capabilities Array Regis

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Eduardo Habkost
On Wed, Jan 06, 2021 at 02:38:56PM +0100, Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 05 Jan 2021 12:50:05 +0100 > >> > > >> > I think there is a misunderstanding, idea w

Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration

2021-01-06 Thread BALATON Zoltan
On Thu, 17 Dec 2020, Paolo Bonzini wrote: Due to the renumbering of text consoles when graphical consoles are created, init_displaystate must be called after all QemuConsoles are created, i.e. after devices are created. vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is where d

Re: [PATCH v2] Docs/RCU: Correct sample code of qatomic_rcu_set

2021-01-06 Thread Stefan Hajnoczi
On Wed, Jan 06, 2021 at 03:17:10PM +0800, Keqian Zhu wrote: > Correct sample code to avoid confusing readers. > > Signed-off-by: Keqian Zhu > Cc: qemu-triv...@nongnu.org > Reviewed-by: Paolo Bonzini > Reviewed-by: Peter Xu > --- > > v2: > - Add Cc and R-b. > > --- > docs/devel/rcu.txt | 2 +

Re: [PATCH v2 1/1] vl.c: do not execute trace_init_backends() before daemonizing

2021-01-06 Thread Stefan Hajnoczi
On Tue, Jan 05, 2021 at 03:14:37PM -0300, Daniel Henrique Barboza wrote: > Commit v5.2.0-190-g0546c0609c ("vl: split various early command line > options to a separate function") moved the trace backend init code to > the qemu_process_early_options(). Which is now being called before > os_daemonize

Re: [PULL v2 00/53] Misc patches for 2020-12-21

2021-01-06 Thread Alex Bennée
Peter Maydell writes: > On Mon, 4 Jan 2021 at 14:44, Paolo Bonzini wrote: >> >> The following changes since commit 41192db338588051f21501abc13743e62b0a5605: >> >> Merge remote-tracking branch >> 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging >> (2021-01-01 22:57:15 +

CDOS 386 keyboard handling

2021-01-06 Thread LE LIEGARD, Stephane
Hello, Host : centos 7 Guest : Concurrent DOS 386 v3.00 (problem also happen on DOS 3.0) QEMU : v5.1.0 Virtualbox : v6.1.14 Seabios : seabios-rel-1.13.0 I first started to run some tests to debug the alt-gr behavior, and I ended up noticing something strange. This issue is the same as this one:

Re: [RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-06 Thread Ben Widawsky
On 21-01-06 13:28:05, Jonathan Cameron wrote: > On Tue, 5 Jan 2021 08:52:56 -0800 > Ben Widawsky wrote: > > > This implements all device MMIO up to the first capability .That > > includes the CXL Device Capabilities Array Register, as well as all of > > the CXL Device Capability Header Registers.

Re: [PATCH v2] tracetool: also strip %l and %ll from systemtap format strings

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/6/21 3:36 PM, Laurent Vivier wrote: > On 06/01/2021 14:02, Daniel P. Berrangé wrote: >> All variables are 64-bit and so %l / %ll are not required, and the >> latter is actually invalid: >> >> $ sudo stap -e 'probe begin{printf ("BEGIN")}' -I . >> parse error: invalid or missing conversion

Re: [PATCHv3] arm-virt: add secure pl061 for reset/power down

2021-01-06 Thread Philippe Mathieu-Daudé
On 1/6/21 5:34 PM, Maxim Uvarov wrote: > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). > Use the same gpio 3 and gpio 4 which were used by > non acpi variant of linux power control gpios. > > Signed-off-by: Maxim Uvarov > --- > v3: added missed inc

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Igor Mammedov
On Wed, 06 Jan 2021 14:38:56 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 05 Jan 2021 12:50:05 +0100 > >> > > >> > I think there is a misunderstanding, idea wa

Re: [PATCH V2 05/22] vl: memfd-alloc option

2021-01-06 Thread Steven Sistare
On 1/5/2021 11:27 AM, Daniel P. Berrangé wrote: > On Tue, Jan 05, 2021 at 07:41:53AM -0800, Steve Sistare wrote: >> Allocate anonymous memory using memfd_create if the memfd-alloc option is >> set. >> >> Signed-off-by: Steve Sistare >> --- >> exec.c | 38 +

Re: [PATCHv3] arm-virt: add secure pl061 for reset/power down

2021-01-06 Thread Maxim Uvarov
Please skip v2 and use v3. I had to check that one line change code compiles. qemu_log() requires include header for that function. Best regards, Maxim. On Wed, 6 Jan 2021 at 19:34, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmwar

  1   2   >