Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-21 Thread Alessandro Di Federico via
On Mon, 20 Mar 2023 10:10:27 + Alex Bennée wrote: > This doesn't save much as cpu-exec-common still needs to be built > per-target for its knowledge of CPUState but this helps with keeping > things organised. > --- /dev/null > +++ b/accel/tcg/cpu-exec-softmmu.c Could `cpu_reloading_memory_m

Re: [PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alessandro Di Federico via
On Wed, 15 Mar 2023 17:43:29 + Alex Bennée wrote: > +rev.ng revng Can we have "rev.ng Labs"? I suggested this in my previous e-mail too, but maybe it slipped away. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v2 08/10] contrib/gitdm: add revng to domain map

2023-03-10 Thread Alessandro Di Federico via
On Fri, 10 Mar 2023 18:03:30 + Alex Bennée wrote: > +rev.ng revng Please use "rev.ng Labs". Thanks! Reviewed-by: Alessandro Di Federico -- Alessandro Di Federico rev.ng Labs

Re: [RFC] Reducing NEED_CPU_H usage

2023-01-12 Thread Alessandro Di Federico via
On Tue, 10 Jan 2023 11:56:50 -0800 Richard Henderson wrote: > However, at some point we do want to keep some target addresses in > the proper size. For instance within the softmmu tlb, where > CPUTLBEntry is either 16 or 32 bytes, depending. So that would be an optimization if `HOST_LONG_BITS =

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 10:51:36 -0500 Stefan Hajnoczi wrote: > QEMU's Makefile used to a use a technique where it generated > "timestamp" files and used cmp(1) to check if rebuilding was > necessary: > 1. Always generate meson-buildoptions.sh-timestamp. `meson-buildoptions.sh-timestamp` would be the

Re: [RFC PATCH] docs: add some details about compilation units to coding style

2023-01-03 Thread Alessandro Di Federico via
Makes sense to me. Reviewed-by: Alessandro Di Federico On Tue, 3 Jan 2023 10:47:58 + Alex Bennée wrote: > +"Templates" and generated code > +== > + > +We make heavy use of C's macro facilities combined with multiple > +inclusion to generate code. This tends to

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 09:37:51 -0500 Stefan Hajnoczi wrote: > I don't understand the issue. Can you describe the steps that cause > meson-buildoptions.sh to become out-of-sync with meson_options.txt? > > This will continue to be a problem in the future. Is there a way to > fix it permanently? In M

[PATCH] Update scripts/meson-buildoptions.sh

2023-01-02 Thread Alessandro Di Federico via
Note: `Makefile` relies on modification dates in the source tree to detect changes to `meson_options.txt`. However, git does not track those. Therefore, the following was necessary to regenerate `meson-buildoptions.sh`: touch meson_options.txt cd "$BUILD_DIR" make update-buildoptions

Re: [PULL 17/21] target/hexagon: prepare input for the idef-parser

2022-12-31 Thread Alessandro Di Federico via
On Thu, 29 Dec 2022 11:41:22 +0100 Thomas Huth wrote: > I'm now seeing changes to scripts/meson-buildoptions.sh after > rebuilding QEMU ... looks like you likely forgot to update that file > with the automatic update after changing meson_options.txt ? Ah, there seems to be another couple of unre

Re: [PATCH 1/1] target/hexagon: work around unused variable in yyparser

2022-12-31 Thread Alessandro Di Federico via
On Sat, 31 Dec 2022 17:19:35 +0800 Zongyuan Li wrote: > Variable 'yynerrs' is recognized as unused variable in clang15, This issue is already handled by another similar patch (target/hexagon: suppress unused variable warning) that will soon end up in a pull request. Thanks for looking into this

[RFC] Reducing NEED_CPU_H usage

2022-12-28 Thread Alessandro Di Federico via
Hello everyone, this is a proposal in the libtcg direction, i.e., enabling building a single QEMU executable featuring multiple *targets* (i.e., TCG frontends). This follows what we discussed in recent KVM calls and originally at the KVM Forum Emulation BoF. Note that our commitment to this projec

Re: [PATCH] target/hexagon/idef-parser: fix two typos in README

2022-12-28 Thread Alessandro Di Federico via
On Tue, 27 Dec 2022 17:49:04 -0300 Matheus Tavares Bernardino wrote: > Signed-off-by: Matheus Tavares Bernardino > --- > target/hexagon/idef-parser/README.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Alessandro Di Federico Thanks for the fixes! -- Alessandro

[PATCH v2] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
This patch manually suppresses a warning for an unused variable (yynerrs) emitted by bison. This warning has been triggered for the first time by clang 15. This patch also disables `-Wextra`, which is not usually adopted in QEMU. However, clang 15 triggers the warning fixed in this patch even in

[PATCH] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
This patch manually suppresses a warning for an unused variable (yynerrs) emitted by bison. This warning has been triggered for the first time by clang 15. This patch also disables `-Wextra`, which is not usually adopted in QEMU. However, clang 15 triggers the warning fixed in this patch even in

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Tue, 20 Dec 2022 08:30:02 +0100 Philippe Mathieu-Daudé wrote: > Do we really need this level? IIUC the problem with -Wextra is using a > newer compiler toolchain it can include warnings we haven't fixed. > Maybe worthwhile but it can break from times to times. I think we just wanted to be ove

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Mon, 19 Dec 2022 18:54:22 + Taylor Simpson wrote: > > Applied, thanks. > > Thanks!! Thanks from our side too! :) We started this project back in 2015, I'm really happy we finally got it in! -- Alessandro Di Federico rev.ng Labs

Re: Any interest in a QEMU emulation BoF at KVM Forum?

2022-09-01 Thread Alessandro Di Federico via
I'm very interested too. Thanks for organizing this, Alex! In particular we're interested in the infrastructure work to enable having a single build of QEMU using several different TCG frontends, which is probably preliminary to heterogeneous vCPU emulation. In fact, I was going to send an RFC ab

Re: [PATCH v6 0/7] tests: Refresh lcitool submodule & remove libxml2

2022-01-30 Thread Alessandro Di Federico via
On Tue, 25 Jan 2022 11:59:38 +0100 Philippe Mathieu-Daudé via wrote: > I'm seeing the same issue with these domains since mid december: > > ... > - rev.ng > > ... > https://lore.kernel.org/qemu-devel/20220105185720.0d4fc159@orange/ > ... I've tried to look into this and it looks like our set u

CI for qemu-hexagon

2022-01-05 Thread Alessandro Di Federico via
Hi Alex, I hope you enjoyed the holidays! We're trying to upstream idef-parser (the automatic generator of the Hexagon frontend). This introduces new dependencies, specifically flex and bison. Attached you can find our patch for that. However the CI fails: https://gitlab.com/carl.cudig/qemu

Re: QEMU CI failure of cross-i386-* targets (meson picks wrong glib for native target)

2021-12-29 Thread Alessandro Di Federico via
On Fri, 24 Dec 2021 22:25:24 +0100 Paolo Bonzini wrote: > Is the configure script setting $cross_compile to yes? That will > decide whether meson getting a --cross-file or a --native-file > option, and consequently whether it treats the host and build > machines as equal or different. From what

QEMU CI failure of cross-i386-* targets (meson picks wrong glib for native target)

2021-12-24 Thread Alessandro Di Federico via
Hi Paolo, I'm trying to get the QEMU CI run successfully for the idef-parser patchset. However I'm facing an issue I haven't been able to work around with meson. Maybe you can help? The failing tests are cross-i386-* https://gitlab.com/carl.cudig/qemu/-/jobs/1437392669 https://gitlab.com/

[PATCH v6 12/12] gitlab-ci: do not use qemu-project Docker registry

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. This should be considered as a temporary solution in order

[PATCH v6 08/12] target/hexagon: import lexer for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 258 +++ target/hexagon/idef-parser/idef-parser.lex| 642 ++ target/hexagon/meson.build| 4 + tests/docker/

[PATCH v6 00/12] target/hexagon: introduce idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the sixth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny

[PATCH v6 07/12] target/hexagon: prepare input for the idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH v6 10/12] target/hexagon: call idef-parser functions

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico Reviewed-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 5 +- target/hexagon/gen_helper_protos.py | 5 +-

[PATCH v6 02/12] target/hexagon: import README for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/README.rst | 447 ++ target/hexagon/README | 5 + 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v6 09/12] target/hexagon: import parser for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/parser-helpers.h | 346 +++ target/hexagon/idef-parser/parser-helpers.c | 2396 + target/hexagon/idef-parser/idef-parser.y | 975 +++ target/he

[PATCH v6 11/12] target/hexagon: import additional tests

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 30 +- tests/tcg/hexagon/crt.S| 26 tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_bitcnt.S| 42 +++

[PATCH v6 04/12] target/hexagon: make helper functions non-static

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. This commit also makes some op_helper.c non-static in order to avoid having them marked as unused when using the idef-parser g

[PATCH v6 03/12] target/hexagon: make slot number an unsigned

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/macros.h | 2 +- target/hexagon/genptr.c | 24 +--- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/target/hexagon/macr

[PATCH v6 06/12] target/hexagon: expose next PC in DisasContext

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/translate.h | 1 + target/hexagon/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/h

[PATCH v6 05/12] target/hexagon: introduce new helper functions

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.h | 15 +- target/hexagon/macros.h | 9 target/hexagon/genptr.c | 113 ++

[PATCH v6 01/12] target/hexagon: update MAINTAINERS for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4256ad1adb..6c825a9eb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,6 +194,8 @@ He

Re: [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-07-08 Thread Alessandro Di Federico via
On Tue, 29 Jun 2021 15:37:21 +0100 Daniel P. Berrangé wrote: > We have either one or two images. If this is a new user fork, > we only have the $COMMON_TAG image in the main QEMU registry. > If this is a existing fork, we might have two images, one in > the main QEMU registry and one in the user

Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-07-05 Thread Alessandro Di Federico via
On Thu, 24 Jun 2021 03:55:35 + Taylor Simpson wrote: > > +void gen_deposit_op(Context *c, > > +YYLTYPE *locp, > > +HexValue *dest, > > +HexValue *value, > > +HexValue *index, > > +HexCast *cast

Re: [PATCH v5 13/14] target/hexagon: import additional tests

2021-07-05 Thread Alessandro Di Federico via
On Fri, 25 Jun 2021 18:56:57 -0500 Taylor Simpson wrote: > Each of these are very small, so I recommend putting them into misc.c > or combine all the assembly into a small number of executables. These tests are designed to run without libc and test in isolation very specific functionality making

Re: [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-06-29 Thread Alessandro Di Federico via
On Sat, 19 Jun 2021 11:37:13 +0200 Alessandro Di Federico wrote: > From: Alessandro Di Federico > > This commit is necessary in order to use container built by the > current run of the CI. If we don't do this, we use official > containers which are not affected by the additional dependencies >

Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-29 Thread Alessandro Di Federico via
On Thu, 24 Jun 2021 03:55:35 + Taylor Simpson wrote: > > + | rvalue '[' rvalue ']' > > + { > > + @1.last_column = @4.last_column; > > + if ($3.type == IMMEDIATE) { > > + $$ = gen_tmp(c, &@1, $1.bit_width); > > + OUT(c, &@1,

Re: [PATCH v5 03/14] target/hexagon: import README for idef-parser

2021-06-24 Thread Alessandro Di Federico via
On Wed, 23 Jun 2021 15:46:22 + Taylor Simpson wrote: > The output isn't actually indented, but it would be great if it were. > This is especially true for instructions where an "if" or "for" show > up in the emitted code. Emitting whitespaces in the parser is a bit annoying and fragile, but

[PATCH v5 13/14] target/hexagon: import additional tests

2021-06-19 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 36 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S | 20

[PATCH v5 03/14] target/hexagon: import README for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v5 12/14] target/hexagon: remove unused macros and functions

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/gen_tcg.h | 528 - target/hexagon/genptr.c| 98 --- target/hexagon/macros.h| 200 +- target/hexagon/op_helper.c | 119 -

[PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. Signed-off-by: Alessandro Di Federico --- .gitlab-ci.d/co

[PATCH v5 02/14] target/hexagon: update MAINTAINERS for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d9cd29042..7fd32062be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,6 +192,8 @@ He

[PATCH v5 11/14] target/hexagon: call idef-parser functions

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_helper_funcs.py | 5 ++- target/hexagon/gen_helper_protos.py | 5 ++- target/hexagon/gen_tcg_fu

[PATCH v5 05/14] target/hexagon: make helper functions non-static

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson --- target/hexagon/genp

[PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 961 +++ target/hexagon/idef-parser/parser-helpers.c | 2396 + target/hexagon/idef-parser/parser-helpers.h | 347 +++ target/he

[PATCH v5 04/14] target/hexagon: make slot number an unsigned

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/

[PATCH v5 09/14] target/hexagon: import lexer for idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 262 target/hexagon/idef-parser/idef-parser.lex| 597 ++ target/hexagon/meson.build| 4 + tests/docker

[PATCH v5 00/14] target/hexagon: introduce idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the fifth iteration of the patchset and includes fixes suggested in previous iterations. This patchset also drops some macro overrides that are no longer necessary, since the instructions they were ha

[PATCH v5 08/14] target/hexagon: prepare input for the idef-parser

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH v5 07/14] target/hexagon: expose next PC in DisasContext

2021-06-19 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/h

[PATCH v5 06/14] target/hexagon: introduce new helper functions

2021-06-19 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 163 target/hexagon/genptr.h | 23 ++ target/hexagon/macros.h |

[PATCH v5 01/14] tcg: expose TCGCond manipulation routines

2021-06-19 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101 + i

Re: [PATCH v4 06/12] target/hexagon: introduce new helper functions

2021-04-19 Thread Alessandro Di Federico via
On Mon, 19 Apr 2021 15:00:17 + Taylor Simpson wrote: > Once this patch series is merged, many load/store instructions will > have manual overrides. I can easily provide overrides for the > remainder. Then, we could skip them in the idef-parser. At a > minimum, you should skip the ones that

[PATCH v4 07/12] target/hexagon: expose next PC in DisasContext

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index eeaad5f

[PATCH v4 01/12] tcg: expose TCGCond manipulation routines

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101 + i

[PATCH v4 04/12] target/hexagon: make slot number an unsigned

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c1dd..fd

[PATCH v4 02/12] target/hexagon: update MAINTAINERS for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36055f14c5..158badbd18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -193,11 +193,19 @@ Hexagon TCG CPUs M: Taylor Simp

[PATCH v4 11/12] target/hexagon: call idef-parser functions

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10 ++ t

[PATCH v4 10/12] target/hexagon: import parser for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 947 +++ target/hexagon/idef-parser/parser-helpers.c | 2374 + target/hexagon/idef-parser/parser-helpers.h | 347 +++ target/he

[PATCH v4 09/12] target/hexagon: import lexer for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 254 target/hexagon/idef-parser/idef-parser.lex| 611 ++ target/hexagon/meson.build| 4 + tests/docker

[PATCH v4 12/12] target/hexagon: import additional tests

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 36 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S | 20

[PATCH v4 06/12] target/hexagon: introduce new helper functions

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 188 target/hexagon/genptr.h | 22 + target/hexagon/macros.h | 9

[PATCH v4 08/12] target/hexagon: prepare input for the idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 150

[PATCH v4 05/12] target/hexagon: make helper functions non-static

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 7 --- target/hexagon

[PATCH v4 00/12] target/hexagon: introduce idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the fourth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny

[PATCH v4 03/12] target/hexagon: import README for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v3 10/12] target/hexagon: import parser for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 940 +++ target/hexagon/idef-parser/parser-helpers.c | 2230 + target/hexagon/idef-parser/parser-helpers.h | 344 +++ target/he

[PATCH v3 11/12] target/hexagon: call idef-parser functions

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10 ++ t

[PATCH v3 06/12] target/hexagon: introduce new helper functions

2021-03-30 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 173 target/hexagon/genptr.h | 17 target/hexagon/macros.h | 9

[PATCH v3 12/12] target/hexagon: import additional tests

2021-03-30 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S | 20

[PATCH v3 08/12] target/hexagon: prepare input for the idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 150

[PATCH v3 02/12] target/hexagon: update MAINTAINERS for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 554be84b32..13de7ecc36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,11 +194,19 @@ Hexagon TCG CPUs M: Taylor Simp

[PATCH v3 00/12] target/hexagon: introduce idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the third iteration of the patchset and includes fixes suggested in the previous iteration. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the ti

[PATCH v3 04/12] target/hexagon: make slot number an unsigned

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c1dd..fd

[PATCH v3 09/12] target/hexagon: import lexer for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 240 +++ target/hexagon/idef-parser/idef-parser.lex| 611 ++ target/hexagon/meson.build| 4 + tests/docker/

[PATCH v3 07/12] target/hexagon: expose next PC in DisasContext

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index eeaad5f

[PATCH v3 03/12] target/hexagon: import README for idef-parser

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v3 01/12] tcg: expose TCGCond manipulation routines

2021-03-30 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101 + i

[PATCH v3 05/12] target/hexagon: make helper functions non-static

2021-03-30 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 7 --- target/hexagon

Re: [PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-03-18 Thread Alessandro Di Federico via
On Wed, 10 Mar 2021 15:48:14 + Taylor Simpson wrote: > Which instructions require this? There must be an attribute that we > could check to see if it is needed before emitting the TCG. The following should be an example of an instruction that requires zero-initialization: /* S2_vsplatr

Re: [PATCH v2 08/10] target/hexagon: import parser for idef-parser

2021-03-01 Thread Alessandro Di Federico via
On Thu, 25 Feb 2021 19:30:14 -0800 Richard Henderson wrote: > > +} > > +} > > +code > > +{ > > +if (c->inst.error_count != 0) { > > +fprintf(stderr, > > +"Parsing of instruction %s generated %d errors!\n", > > +c->inst.name, > > +c->

Re: [PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-03-01 Thread Alessandro Di Federico via
On Thu, 25 Feb 2021 12:20:53 -0800 Richard Henderson wrote: > This is odd, as is the description of why. Yes, if RdV is read > without initialization, TCG middle-end will abort (at least with > --enable-debug-tcg enabling the assertions). But you've just said > that "no reading" was found. When

Re: [PATCH v2 09/10] target/hexagon: call idef-parser functions

2021-03-01 Thread Alessandro Di Federico via
On Thu, 25 Feb 2021 19:47:04 -0800 Richard Henderson wrote: > On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > > +elif hex_common.is_new_val(regtype, regid, tag): > > +declared.append("%s%sN" % (regtype,regid)) > > +else: > > +print("Bad

Re: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci

2021-03-01 Thread Alessandro Di Federico via
On Sun, 28 Feb 2021 23:23:10 +0100 Philippe Mathieu-Daudé wrote: > This series is a rework of the 'Add Dockerfile for hexagon' patch > from Alessandro/Brian that Taylor sent in v8: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html > but adapted to mainstream. All of this looks

[PATCH v2 10/10] target/hexagon: import additional tests

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/first.S | 24 ++-- tests/tcg/hexagon/test_abs.S |

[PATCH v2 07/10] target/hexagon: import lexer for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 245 +++ target/hexagon/idef-parser/idef-parser.lex| 647 ++ target/hexagon/meson.build| 4 + tests/docker/

Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 13:52:25 -0800 Richard Henderson wrote: > Well, first off, this fails to build with our gitlab CI. > > There are several problems, apart from the new bison parse.error > option previously reported: > > (1) bison and flex not added to dockerfiles, so the packages are not > av

Re: [RFC PATCH 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
On Sun, 14 Feb 2021 08:56:11 -0800 Richard Henderson wrote: > What version of bison are you using? We were using a rather recent version of bison (3.7.5), but it's not strictly required. Fixed in v2. -- Alessandro Di Federico rev.ng

[PATCH v2 08/10] target/hexagon: import parser for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 1250 +++ target/hexagon/idef-parser/parser-helpers.c | 1925 + target/hexagon/idef-parser/parser-helpers.h | 293 +++ targe

[PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v2 09/10] target/hexagon: call idef-parser functions

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10 ++ t

[PATCH v2 05/10] target/hexagon: expose next PC in DisasContext

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 4 +++- target/hexagon/translate.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index eeaad5

[PATCH v2 04/10] target/hexagon: introduce new helper functions

2021-02-25 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 227 +++- target/hexagon/genptr.h | 19 target/hexagon/macros.h | 2

[PATCH v2 06/10] target/hexagon: prepare input for the idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 target/hexagon/idef-parser/macros.inc | 166 ++

[PATCH v2 01/10] target/hexagon: update MAINTAINERS for idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..9a6878b970 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,11 +192,19 @@ Hexagon TCG CPUs M: Taylor Simp

[PATCH v2 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the second iteration of the patchset and includes fixes suggested in the previous iteration. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the t

[PATCH v2 03/10] target/hexagon: make helper functions non-static

2021-02-25 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 13 ++--- target/

  1   2   >