Re: [PATCH 08/40] igb: Always copy ethernet header

2023-04-21 Thread Akihiko Odaki
On 2023/04/14 23:46, Philippe Mathieu-Daudé wrote: On 14/4/23 13:37, Akihiko Odaki wrote: igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-ne

Re: [PATCH 08/40] igb: Always copy ethernet header

2023-04-14 Thread Philippe Mathieu-Daudé
On 14/4/23 13:37, Akihiko Odaki wrote: igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy

[PATCH 08/40] igb: Always copy ethernet header

2023-04-14 Thread Akihiko Odaki
igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 22 octets, which can be even less