Re: [PATCH 2/5] pc-bios/dtb/meson: Prefer target name to be outfile, not infile

[Thomas Huth]

On 10/06/2025 22.41, Bernhard Beschow wrote:

Makes this custom_target() usage consistent with other ones in QEMU.

Fixes: 6e0dc9d2a88a ("meson: compile bundled device trees")
Signed-off-by: Bernhard Beschow 
---
  pc-bios/dtb/meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/dtb/meson.build b/pc-bios/dtb/meson.build
index 7a71835bca..993032949f 100644
--- a/pc-bios/dtb/meson.build
+++ b/pc-bios/dtb/meson.build
@@ -9,7 +9,7 @@ dtc = find_program('dtc', required: false)
  if dtc.found()
foreach out : dtbs
  f = fs.replace_suffix(out, '.dts')
-custom_target(f,
+custom_target(out,
  build_by_default: have_system,
  input: files(f),
  output: out,


That looks better, indeed.

Tested-by: Thomas Huth 
Reviewed-by: Thomas Huth 

[PATCH 2/5] pc-bios/dtb/meson: Prefer target name to be outfile, not infile

[Bernhard Beschow]

Makes this custom_target() usage consistent with other ones in QEMU.

Fixes: 6e0dc9d2a88a ("meson: compile bundled device trees")
Signed-off-by: Bernhard Beschow 
---
 pc-bios/dtb/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/dtb/meson.build b/pc-bios/dtb/meson.build
index 7a71835bca..993032949f 100644
--- a/pc-bios/dtb/meson.build
+++ b/pc-bios/dtb/meson.build
@@ -9,7 +9,7 @@ dtc = find_program('dtc', required: false)
 if dtc.found()
   foreach out : dtbs
 f = fs.replace_suffix(out, '.dts')
-custom_target(f,
+custom_target(out,
 build_by_default: have_system,
 input: files(f),
 output: out,
-- 
2.49.0