Re: [PATCH v2 0/2] Add me as the maintainer for ivshmem-pci
Philippe Mathieu-Daudé writes: > On 24/1/25 17:22, Philippe Mathieu-Daudé wrote: >> On 23/1/25 02:22, Gustavo Romero wrote: >>> Add me as the maintainer for the ivshmem-pci.c device, the ivshmem >>> server, and the ivshmem client tool. Also, adjust remaining parts left >>> behind after ivshmem PCI device was renamed from ivshmem.c to >>> ivshmem-pci.c, like header files, Kconfig, docs, and build scripts. >>> >>> >>> Cheers, >>> Gustavo >>> >>> Gustavo Romero (2): >>> hw/misc/ivshmem-pci: Rename remaining parts for consistency >>> MAINTAINERS: Add me as the maintainer for ivshmem-pci >> Reviewed-by: Philippe Mathieu-Daudé >> and queued, thanks for volunteering! > > Failing to build: > > docs/specs/ivshmem-spec.rst:17:unknown document: '../system/devices/ivshmem' > ninja: build stopped: subcommand failed. > > docs/specs/ivshmem-spec.rst only mention PCI, so I could squash in the > first patch: > -- >8 -- > diff --git a/docs/specs/ivshmem-spec.rst b/docs/specs/ivshmem-spec.rst > index 2d8e80055b0..e326d024487 100644 > --- a/docs/specs/ivshmem-spec.rst > +++ b/docs/specs/ivshmem-spec.rst > @@ -17,3 +17,3 @@ get interrupted by its peers. > For information on configuring the ivshmem device on the QEMU > -command line, see :doc:`../system/devices/ivshmem`. > +command line, see :doc:`../system/devices/ivshmem-pci`. > --- > But then I wonder if this document shouldn't mention the flat > device. Since I'm unsure I'm dropping the series (patch 2 > depends on 1). Simple oversight in PATCH 1. It renames docs/system/devices/ivshmem.rst to docs/system/devices/ivshmem-pci.rst without updating the reference in docs/specs/ivshmem-spec.rst. Surprisingly, this didn't fail for me in an incremental build, only in a full one.
Re: [PATCH v2 0/2] Add me as the maintainer for ivshmem-pci
On 24/1/25 17:22, Philippe Mathieu-Daudé wrote: On 23/1/25 02:22, Gustavo Romero wrote: Add me as the maintainer for the ivshmem-pci.c device, the ivshmem server, and the ivshmem client tool. Also, adjust remaining parts left behind after ivshmem PCI device was renamed from ivshmem.c to ivshmem-pci.c, like header files, Kconfig, docs, and build scripts. Cheers, Gustavo Gustavo Romero (2): hw/misc/ivshmem-pci: Rename remaining parts for consistency MAINTAINERS: Add me as the maintainer for ivshmem-pci Reviewed-by: Philippe Mathieu-Daudé and queued, thanks for volunteering! Failing to build: docs/specs/ivshmem-spec.rst:17:unknown document: '../system/devices/ivshmem' ninja: build stopped: subcommand failed. docs/specs/ivshmem-spec.rst only mention PCI, so I could squash in the first patch: -- >8 -- diff --git a/docs/specs/ivshmem-spec.rst b/docs/specs/ivshmem-spec.rst index 2d8e80055b0..e326d024487 100644 --- a/docs/specs/ivshmem-spec.rst +++ b/docs/specs/ivshmem-spec.rst @@ -17,3 +17,3 @@ get interrupted by its peers. For information on configuring the ivshmem device on the QEMU -command line, see :doc:`../system/devices/ivshmem`. +command line, see :doc:`../system/devices/ivshmem-pci`. --- But then I wonder if this document shouldn't mention the flat device. Since I'm unsure I'm dropping the series (patch 2 depends on 1). Regards, Phil.
Re: [PATCH v2 0/2] Add me as the maintainer for ivshmem-pci
On 23/1/25 02:22, Gustavo Romero wrote: Add me as the maintainer for the ivshmem-pci.c device, the ivshmem server, and the ivshmem client tool. Also, adjust remaining parts left behind after ivshmem PCI device was renamed from ivshmem.c to ivshmem-pci.c, like header files, Kconfig, docs, and build scripts. Cheers, Gustavo Gustavo Romero (2): hw/misc/ivshmem-pci: Rename remaining parts for consistency MAINTAINERS: Add me as the maintainer for ivshmem-pci Reviewed-by: Philippe Mathieu-Daudé and queued, thanks for volunteering!
Re: [PATCH v2 0/2] Add me as the maintainer for ivshmem-pci
Gustavo Romero writes: > Add me as the maintainer for the ivshmem-pci.c device, the ivshmem > server, and the ivshmem client tool. Also, adjust remaining parts left > behind after ivshmem PCI device was renamed from ivshmem.c to > ivshmem-pci.c, like header files, Kconfig, docs, and build scripts. Thank you! Acked-by: Markus Armbruster
[PATCH v2 0/2] Add me as the maintainer for ivshmem-pci
Add me as the maintainer for the ivshmem-pci.c device, the ivshmem
server, and the ivshmem client tool. Also, adjust remaining parts left
behind after ivshmem PCI device was renamed from ivshmem.c to
ivshmem-pci.c, like header files, Kconfig, docs, and build scripts.
Cheers,
Gustavo
Gustavo Romero (2):
hw/misc/ivshmem-pci: Rename remaining parts for consistency
MAINTAINERS: Add me as the maintainer for ivshmem-pci
MAINTAINERS | 9 -
contrib/ivshmem-client/ivshmem-client.h | 2 +-
contrib/ivshmem-server/ivshmem-server.h | 2 +-
docs/system/device-emulation.rst | 2 +-
docs/system/devices/ivshmem-flat.rst | 2 +-
docs/system/devices/{ivshmem.rst => ivshmem-pci.rst} | 4 ++--
hw/misc/Kconfig | 4 ++--
hw/misc/ivshmem-pci.c| 2 +-
hw/misc/meson.build | 4 ++--
include/hw/misc/{ivshmem.h => ivshmem-pci.h} | 6 +++---
tests/qtest/meson.build | 2 +-
11 files changed, 23 insertions(+), 16 deletions(-)
rename docs/system/devices/{ivshmem.rst => ivshmem-pci.rst} (96%)
rename include/hw/misc/{ivshmem.h => ivshmem-pci.h} (88%)
--
2.34.1
