Re: [PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/

2025-05-27 Thread Markus Armbruster
Pierrick Bouvier  writes:

> As requested by Markus:
>> I'd prefer "field is set".
>
> Signed-off-by: Pierrick Bouvier 
> ---
>  qapi/misc-i386.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
> index 3fda7a20bdd..6f79817e382 100644
> --- a/qapi/misc-i386.json
> +++ b/qapi/misc-i386.json
> @@ -129,7 +129,7 @@
>  # Return information about SEV/SEV-ES/SEV-SNP.
>  #
>  # If unavailable due to an incompatible configuration the
> -# returned @enabled field will be set to 'false' and the
> +# returned @enabled field is set to 'false' and the
>  # state of all other fields is undefined.
>  #
>  # Returns: @SevInfo

I'd squash this into PATCH 02.  I figure you didn't because PATCH 02 is
Daniel's.  Here's how I would record provenance when squashing:

Reviewed-by: Richard Henderson 
Signed-off-by: Daniel P. Berrangé 
[Doc comment tweaked]
Signed-off-by: Pierrick Bouvier 

If you want to blame me for the tweak (kidding, it's fine), you could
use [Doc comment tweaked at Markus's request].




[PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/

2025-05-22 Thread Pierrick Bouvier
As requested by Markus:
> I'd prefer "field is set".

Signed-off-by: Pierrick Bouvier 
---
 qapi/misc-i386.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
index 3fda7a20bdd..6f79817e382 100644
--- a/qapi/misc-i386.json
+++ b/qapi/misc-i386.json
@@ -129,7 +129,7 @@
 # Return information about SEV/SEV-ES/SEV-SNP.
 #
 # If unavailable due to an incompatible configuration the
-# returned @enabled field will be set to 'false' and the
+# returned @enabled field is set to 'false' and the
 # state of all other fields is undefined.
 #
 # Returns: @SevInfo
-- 
2.47.2