[PULL 23/29] qom: shorten name of object_set_properties_from_keyval
This matches the convention established by the object_set_props and
object_set_propv methods.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
include/qom/object.h| 6 +++---
qom/object_interfaces.c | 12 ++--
system/qdev-monitor.c | 4 ++--
system/vl.c | 7 ---
4 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index a905a9e42f..83b0cd01b5 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -915,7 +915,7 @@ type_init(do_qemu_init_ ## type_array)
bool type_print_class_properties(const char *type);
/**
- * object_set_properties_from_keyval:
+ * object_set_props_from_keyval:
* @obj: a QOM object
* @qdict: a dictionary with the properties to be set
* @from_json: true if leaf values of @qdict are typed, false if they
@@ -925,8 +925,8 @@ bool type_print_class_properties(const char *type);
* For each key in the dictionary, parse the value string if needed,
* then set the corresponding property in @obj.
*/
-void object_set_properties_from_keyval(Object *obj, const QDict *qdict,
- bool from_json, Error **errp);
+void object_set_props_from_keyval(Object *obj, const QDict *qdict,
+ bool from_json, Error **errp);
/**
* object_class_dynamic_cast_assert:
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index 415cbee8c5..4377d65b76 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -44,8 +44,8 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)
}
}
-static void object_set_properties_from_qdict(Object *obj, const QDict *qdict,
- Visitor *v, Error **errp)
+static void object_set_props_from_qdict(Object *obj, const QDict *qdict,
+Visitor *v, Error **errp)
{
const QDictEntry *e;
@@ -62,8 +62,8 @@ out:
visit_end_struct(v, NULL);
}
-void object_set_properties_from_keyval(Object *obj, const QDict *qdict,
- bool from_json, Error **errp)
+void object_set_props_from_keyval(Object *obj, const QDict *qdict,
+ bool from_json, Error **errp)
{
Visitor *v;
if (from_json) {
@@ -71,7 +71,7 @@ void object_set_properties_from_keyval(Object *obj, const
QDict *qdict,
} else {
v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
}
-object_set_properties_from_qdict(obj, qdict, v, errp);
+object_set_props_from_qdict(obj, qdict, v, errp);
visit_free(v);
}
@@ -110,7 +110,7 @@ Object *user_creatable_add_type(const char *type, const
char *id,
assert(qdict);
obj = object_new_with_class(klass);
-object_set_properties_from_qdict(obj, qdict, v, &local_err);
+object_set_props_from_qdict(obj, qdict, v, &local_err);
if (local_err) {
goto out;
}
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index e5b55e3004..dfc95a08c1 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -730,8 +730,8 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts,
qdict_del(properties, "bus");
qdict_del(properties, "id");
-object_set_properties_from_keyval(&dev->parent_obj, properties, from_json,
- errp);
+object_set_props_from_keyval(&dev->parent_obj, properties, from_json,
+ errp);
qobject_unref(properties);
if (*errp) {
goto err_del_dev;
diff --git a/system/vl.c b/system/vl.c
index e690aa3ed8..da36b2c6e1 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2010,7 +2010,8 @@ static bool object_create_early(const char *type)
static void qemu_apply_machine_options(QDict *qdict)
{
-object_set_properties_from_keyval(OBJECT(current_machine), qdict, false,
&error_fatal);
+object_set_props_from_keyval(OBJECT(current_machine), qdict,
+ false, &error_fatal);
if (semihosting_enabled(false) && !semihosting_get_argc()) {
/* fall back to the -kernel/-append */
@@ -2225,8 +2226,8 @@ static void qemu_create_machine(QDict *qdict)
keyval_parse(machine_class->default_machine_opts, NULL, NULL,
&error_abort);
qemu_apply_legacy_machine_options(default_opts);
-object_set_properties_from_keyval(OBJECT(current_machine),
default_opts,
- false, &error_abort);
+object_set_props_from_keyval(OBJECT(current_machine), default_opts,
+ false, &error_abort);
qobject_unref(default_opts);
}
}
--
2.54.0
[PULL 23/29] qom: shorten name of object_set_properties_from_keyval
This matches the convention established by the object_set_props and
object_set_propv methods.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
include/qom/object.h| 6 +++---
qom/object_interfaces.c | 12 ++--
system/qdev-monitor.c | 4 ++--
system/vl.c | 7 ---
4 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index a905a9e42f..83b0cd01b5 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -915,7 +915,7 @@ type_init(do_qemu_init_ ## type_array)
bool type_print_class_properties(const char *type);
/**
- * object_set_properties_from_keyval:
+ * object_set_props_from_keyval:
* @obj: a QOM object
* @qdict: a dictionary with the properties to be set
* @from_json: true if leaf values of @qdict are typed, false if they
@@ -925,8 +925,8 @@ bool type_print_class_properties(const char *type);
* For each key in the dictionary, parse the value string if needed,
* then set the corresponding property in @obj.
*/
-void object_set_properties_from_keyval(Object *obj, const QDict *qdict,
- bool from_json, Error **errp);
+void object_set_props_from_keyval(Object *obj, const QDict *qdict,
+ bool from_json, Error **errp);
/**
* object_class_dynamic_cast_assert:
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index 415cbee8c5..4377d65b76 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -44,8 +44,8 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)
}
}
-static void object_set_properties_from_qdict(Object *obj, const QDict *qdict,
- Visitor *v, Error **errp)
+static void object_set_props_from_qdict(Object *obj, const QDict *qdict,
+Visitor *v, Error **errp)
{
const QDictEntry *e;
@@ -62,8 +62,8 @@ out:
visit_end_struct(v, NULL);
}
-void object_set_properties_from_keyval(Object *obj, const QDict *qdict,
- bool from_json, Error **errp)
+void object_set_props_from_keyval(Object *obj, const QDict *qdict,
+ bool from_json, Error **errp)
{
Visitor *v;
if (from_json) {
@@ -71,7 +71,7 @@ void object_set_properties_from_keyval(Object *obj, const
QDict *qdict,
} else {
v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
}
-object_set_properties_from_qdict(obj, qdict, v, errp);
+object_set_props_from_qdict(obj, qdict, v, errp);
visit_free(v);
}
@@ -110,7 +110,7 @@ Object *user_creatable_add_type(const char *type, const
char *id,
assert(qdict);
obj = object_new_with_class(klass);
-object_set_properties_from_qdict(obj, qdict, v, &local_err);
+object_set_props_from_qdict(obj, qdict, v, &local_err);
if (local_err) {
goto out;
}
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index e5b55e3004..dfc95a08c1 100644
--- a/system/qdev-monitor.c
+++ b/system/qdev-monitor.c
@@ -730,8 +730,8 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts,
qdict_del(properties, "bus");
qdict_del(properties, "id");
-object_set_properties_from_keyval(&dev->parent_obj, properties, from_json,
- errp);
+object_set_props_from_keyval(&dev->parent_obj, properties, from_json,
+ errp);
qobject_unref(properties);
if (*errp) {
goto err_del_dev;
diff --git a/system/vl.c b/system/vl.c
index e690aa3ed8..da36b2c6e1 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2010,7 +2010,8 @@ static bool object_create_early(const char *type)
static void qemu_apply_machine_options(QDict *qdict)
{
-object_set_properties_from_keyval(OBJECT(current_machine), qdict, false,
&error_fatal);
+object_set_props_from_keyval(OBJECT(current_machine), qdict,
+ false, &error_fatal);
if (semihosting_enabled(false) && !semihosting_get_argc()) {
/* fall back to the -kernel/-append */
@@ -2225,8 +2226,8 @@ static void qemu_create_machine(QDict *qdict)
keyval_parse(machine_class->default_machine_opts, NULL, NULL,
&error_abort);
qemu_apply_legacy_machine_options(default_opts);
-object_set_properties_from_keyval(OBJECT(current_machine),
default_opts,
- false, &error_abort);
+object_set_props_from_keyval(OBJECT(current_machine), default_opts,
+ false, &error_abort);
qobject_unref(default_opts);
}
}
--
2.54.0
