Re: [PATCH 0/4] target/s390x: Cleanups around s390_cpu_[un]halt()

2025-07-11 Thread David Hildenbrand 

On 11.07.25 10:50, Thomas Huth wrote:

On 08/07/2025 11.57, Philippe Mathieu-Daudé wrote:

Trivial cleanups around s390_cpu_[un]halt(), split of
a bigger series which consolidates CPUClass::[un]halt()
for re-use between accelerators.

Philippe Mathieu-Daudé (4):
target/s390x: Remove unused s390_cpu_[un]halt() user stubs
target/s390x: Expose s390_count_running_cpus() method
target/s390x: Have s390_cpu_halt() not return anything
target/s390x: Extract system internal declarations to s390x-internal.h

   target/s390x/s390x-internal.h | 231 +-
   target/s390x/s390x-system.h   | 215 +++
   target/s390x/cpu-system.c |   6 +-
   target/s390x/helper.c |   4 +-
   4 files changed, 222 insertions(+), 234 deletions(-)
   create mode 100644 target/s390x/s390x-system.h


Thanks, I'll queue 1-3 for my next pull request.


For these 3:

Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb

Re: [PATCH 0/4] target/s390x: Cleanups around s390_cpu_[un]halt()

2025-07-11 Thread Thomas Huth 

On 08/07/2025 11.57, Philippe Mathieu-Daudé wrote:

Trivial cleanups around s390_cpu_[un]halt(), split of
a bigger series which consolidates CPUClass::[un]halt()
for re-use between accelerators.

Philippe Mathieu-Daudé (4):
   target/s390x: Remove unused s390_cpu_[un]halt() user stubs
   target/s390x: Expose s390_count_running_cpus() method
   target/s390x: Have s390_cpu_halt() not return anything
   target/s390x: Extract system internal declarations to s390x-internal.h

  target/s390x/s390x-internal.h | 231 +-
  target/s390x/s390x-system.h   | 215 +++
  target/s390x/cpu-system.c |   6 +-
  target/s390x/helper.c |   4 +-
  4 files changed, 222 insertions(+), 234 deletions(-)
  create mode 100644 target/s390x/s390x-system.h


Thanks, I'll queue 1-3 for my next pull request. Patch 4 needs some 
modifications.


 Thomas