Re: [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
On 29/7/25 11:16, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
Markus Armbruster writes: > Manos Pitsidianakis writes: > >> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster wrote: >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> MAINTAINERS | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index f1bd69c3db..9c22e921e8 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt >>> F: docs/sphinx/ >>> F: docs/_templates/ >>> F: docs/devel/docs.rst >>> +F: docs/devel/qapi-domain.rst >> >> Question: Does it matter if this is already covered by QAPI section >> which has: "F: docs/devel/qapi*"? > > I'm adding it to the "Sphinx documentation configuration and build > machinery" section as well. > > Before the patch: > > $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst > Markus Armbruster (supporter:QAPI) > Michael Roth (supporter:QAPI) > [email protected] (open list:All patches CC here) > > Afterwards: > > $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst > --> John Snow (maintainer:Sphinx documentat...) > --> Peter Maydell (maintainer:Sphinx documentat...) > Markus Armbruster (supporter:QAPI) > Michael Roth (supporter:QAPI) > [email protected] (open list:All patches CC here) > > Good, because it's John's baby, and he's maintaining it. > >> If not, >> >> Reviewed-by: Manos Pitsidianakis > > Thank you! > > [...] Amending the commit message: Section QAPI already covers it, and that's fine. It's missing from "Sphinx documentation configuration and build machinery". Add it there.
Re: [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
Manos Pitsidianakis writes: > On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster wrote: >> >> Signed-off-by: Markus Armbruster >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index f1bd69c3db..9c22e921e8 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt >> F: docs/sphinx/ >> F: docs/_templates/ >> F: docs/devel/docs.rst >> +F: docs/devel/qapi-domain.rst > > Question: Does it matter if this is already covered by QAPI section > which has: "F: docs/devel/qapi*"? I'm adding it to the "Sphinx documentation configuration and build machinery" section as well. Before the patch: $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst Markus Armbruster (supporter:QAPI) Michael Roth (supporter:QAPI) [email protected] (open list:All patches CC here) Afterwards: $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst --> John Snow (maintainer:Sphinx documentat...) --> Peter Maydell (maintainer:Sphinx documentat...) Markus Armbruster (supporter:QAPI) Michael Roth (supporter:QAPI) [email protected] (open list:All patches CC here) Good, because it's John's baby, and he's maintaining it. > If not, > > Reviewed-by: Manos Pitsidianakis Thank you! [...]
Re: [PATCH 2/2] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f1bd69c3db..9c22e921e8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4432,6 +4432,7 @@ F: docs/requirements.txt > F: docs/sphinx/ > F: docs/_templates/ > F: docs/devel/docs.rst > +F: docs/devel/qapi-domain.rst Question: Does it matter if this is already covered by QAPI section which has: "F: docs/devel/qapi*"? If not, Reviewed-by: Manos Pitsidianakis > > Rust build system integration > M: Manos Pitsidianakis > -- > 2.49.0 > >
