Re: [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary
On Thu, Jan 30, 2025 at 06:12:33PM +0100, Kevin Wolf wrote: > Putting an active block node on top of an inactive one is strictly > speaking an invalid configuration and the next patch will turn it into a > hard error. > > However, taking a snapshot while disk images are inactive after > completing migration has an important use case: After migrating to a > file, taking an external snapshot is what is needed to take a full VM > snapshot. > > In order for this to keep working after the later patches, change > creating a snapshot such that it automatically inactivates an overlay > that is added on top of an already inactive node. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 16 > 1 file changed, 16 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature
Re: [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary
On Thu, Jan 30, 2025 at 06:12:33PM +0100, Kevin Wolf wrote: > Putting an active block node on top of an inactive one is strictly > speaking an invalid configuration and the next patch will turn it into a > hard error. > > However, taking a snapshot while disk images are inactive after > completing migration has an important use case: After migrating to a > file, taking an external snapshot is what is needed to take a full VM > snapshot. > > In order for this to keep working after the later patches, change > creating a snapshot such that it automatically inactivates an overlay > that is added on top of an already inactive node. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 16 > 1 file changed, 16 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
