Re: [PATCH v2 11/11] mirror: Allow QMP override to declare target already zero

2025-04-18 Thread Markus Armbruster
Eric Blake  writes:

> QEMU's attempts to learn whether a destination file starts life with
> all zero contents are just a heuristic.  There may be cases where the
> caller is aware of information that QEMU cannot learn quickly, in
> which case telling QEMU what to assume about the destination can make
> the mirror operation faster.  Given our existing example of "qemu-img
> convert --target-is-zero", it is time to expose this override in QMP
> for blockdev-mirror as well.
>
> Signed-off-by: Eric Blake 

Acked-by: Markus Armbruster 




Re: [PATCH v2 11/11] mirror: Allow QMP override to declare target already zero

2025-04-17 Thread Stefan Hajnoczi
On Thu, Apr 17, 2025 at 01:39:16PM -0500, Eric Blake wrote:
> QEMU's attempts to learn whether a destination file starts life with
> all zero contents are just a heuristic.  There may be cases where the
> caller is aware of information that QEMU cannot learn quickly, in
> which case telling QEMU what to assume about the destination can make
> the mirror operation faster.  Given our existing example of "qemu-img
> convert --target-is-zero", it is time to expose this override in QMP
> for blockdev-mirror as well.
> 
> Signed-off-by: Eric Blake 
> ---
>  qapi/block-core.json   |  8 +++-
>  include/block/block_int-global-state.h |  3 ++-
>  block/mirror.c | 23 +++
>  blockdev.c | 18 +++---
>  tests/unit/test-block-iothread.c   |  2 +-
>  5 files changed, 36 insertions(+), 18 deletions(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature