Re: [PATCH v2 14/14] tcg: Remove TCG_OVERSIZED_GUEST

2025-02-04 Thread Richard Henderson

On 2/3/25 05:59, Alex Bennée wrote:

Richard Henderson  writes:


This is now prohibited in configuration.

Signed-off-by: Richard Henderson 



-#if TARGET_LONG_BITS > TCG_TARGET_REG_BITS


Is it worth keeping a compile time assert with a comment so if anyone
attempts to hack 32 bit support back in they will find out quickly?


It's there via the assert within qatomic_set().


r~



Re: [PATCH v2 14/14] tcg: Remove TCG_OVERSIZED_GUEST

2025-02-03 Thread Alex Bennée
Richard Henderson  writes:

> This is now prohibited in configuration.
>
> Signed-off-by: Richard Henderson 

> -#if TARGET_LONG_BITS > TCG_TARGET_REG_BITS

Is it worth keeping a compile time assert with a comment so if anyone
attempts to hack 32 bit support back in they will find out quickly?

Otherwise:

Reviewed-by: Alex Bennée 


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro