Re: [PATCH v2 34/38] MAINTAINERS: Drop stale F: from "Linux io_uring"

2026-06-05 Thread Stefano Garzarella

On Thu, Jun 04, 2026 at 10:29:19AM -0400, Stefan Hajnoczi wrote:

On Thu, Jun 04, 2026 at 03:17:52PM +0200, Stefano Garzarella wrote:

On Wed, Jun 03, 2026 at 08:40:28AM +0200, Markus Armbruster wrote:
> We neglected to update MAINTAINERS when we dropped stubs/io_uring.c.
> Update it now.
>
> Fixes: 047dabef97 (block/io_uring: use aio_add_sqe(), 2025-11-03)
> Cc: Julia Suvorova 
> Cc: Stefan Hajnoczi 
> Cc: Stefano Garzarella 
> Cc: [email protected]
> Signed-off-by: Markus Armbruster 
> Reviewed-by: Stefan Hajnoczi 
> ---
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 71383b9807..c5b6985767 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4331,7 +4331,6 @@ R: Stefano Garzarella 
> L: [email protected]
> S: Maintained
> F: block/io_uring.c
> -F: stubs/io_uring.c

Should we add `util/fdmon-io_uring.c` in this list ?


No, this section is under "Block drivers" and is specifically for qcow2,
iscsi, raw, etc.


Oops, I missed we have sections in the MAINTAINERS file. I thought this 
entry was a generic one for io_uring support in QEMU.




util/fdmon-io_uring.c is covered by util/fdmon-*.c in "Block I/O path",
which is where AioContext and QEMU's event loop lives. 


Okay, makes sense to me, thanks for the clarification.


The name "Block
I/O path" is not the best fit anymore and maybe it should be changed to
"AioContext event loop".


yeah, I agree.

Thanks,
Stefano





BTW this is unrelated to this patch that LGTM:

Reviewed-by: Stefano Garzarella 

>
> qcow2
> M: Kevin Wolf 
> --
> 2.54.0
>







Re: [PATCH v2 34/38] MAINTAINERS: Drop stale F: from "Linux io_uring"

2026-06-04 Thread Stefan Hajnoczi
On Thu, Jun 04, 2026 at 03:17:52PM +0200, Stefano Garzarella wrote:
> On Wed, Jun 03, 2026 at 08:40:28AM +0200, Markus Armbruster wrote:
> > We neglected to update MAINTAINERS when we dropped stubs/io_uring.c.
> > Update it now.
> > 
> > Fixes: 047dabef97 (block/io_uring: use aio_add_sqe(), 2025-11-03)
> > Cc: Julia Suvorova 
> > Cc: Stefan Hajnoczi 
> > Cc: Stefano Garzarella 
> > Cc: [email protected]
> > Signed-off-by: Markus Armbruster 
> > Reviewed-by: Stefan Hajnoczi 
> > ---
> > MAINTAINERS | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 71383b9807..c5b6985767 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4331,7 +4331,6 @@ R: Stefano Garzarella 
> > L: [email protected]
> > S: Maintained
> > F: block/io_uring.c
> > -F: stubs/io_uring.c
> 
> Should we add `util/fdmon-io_uring.c` in this list ?

No, this section is under "Block drivers" and is specifically for qcow2,
iscsi, raw, etc.

util/fdmon-io_uring.c is covered by util/fdmon-*.c in "Block I/O path",
which is where AioContext and QEMU's event loop lives. The name "Block
I/O path" is not the best fit anymore and maybe it should be changed to
"AioContext event loop".

> 
> BTW this is unrelated to this patch that LGTM:
> 
> Reviewed-by: Stefano Garzarella 
> 
> > 
> > qcow2
> > M: Kevin Wolf 
> > -- 
> > 2.54.0
> > 
> 


signature.asc
Description: PGP signature


Re: [PATCH v2 34/38] MAINTAINERS: Drop stale F: from "Linux io_uring"

2026-06-04 Thread Stefano Garzarella

On Wed, Jun 03, 2026 at 08:40:28AM +0200, Markus Armbruster wrote:

We neglected to update MAINTAINERS when we dropped stubs/io_uring.c.
Update it now.

Fixes: 047dabef97 (block/io_uring: use aio_add_sqe(), 2025-11-03)
Cc: Julia Suvorova 
Cc: Stefan Hajnoczi 
Cc: Stefano Garzarella 
Cc: [email protected]
Signed-off-by: Markus Armbruster 
Reviewed-by: Stefan Hajnoczi 
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 71383b9807..c5b6985767 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4331,7 +4331,6 @@ R: Stefano Garzarella 
L: [email protected]
S: Maintained
F: block/io_uring.c
-F: stubs/io_uring.c


Should we add `util/fdmon-io_uring.c` in this list ?

BTW this is unrelated to this patch that LGTM:

Reviewed-by: Stefano Garzarella 



qcow2
M: Kevin Wolf 
--
2.54.0






Re: [PATCH v2 34/38] MAINTAINERS: Drop stale F: from "Linux io_uring"

2026-06-03 Thread Stefan Hajnoczi
On Wed, Jun 03, 2026 at 08:40:28AM +0200, Markus Armbruster wrote:
> We neglected to update MAINTAINERS when we dropped stubs/io_uring.c.
> Update it now.
> 
> Fixes: 047dabef97 (block/io_uring: use aio_add_sqe(), 2025-11-03)
> Cc: Julia Suvorova 
> Cc: Stefan Hajnoczi 
> Cc: Stefano Garzarella 
> Cc: [email protected]
> Signed-off-by: Markus Armbruster 
> Reviewed-by: Stefan Hajnoczi 
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature