Re: Question about customizing the diff view

2009-09-25 Thread Hui Lin
- chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > On Fri, Sep 25, 2009 at 8:31 AM, Hui Lin wrote: > > > I noticed that the lines in the diff view are automatically wrapped at > > the boundary of the browser windows.

Question about customizing the diff view

2009-09-25 Thread Hui Lin
I noticed that the lines in the diff view are automatically wrapped at the boundary of the browser windows. Is there a way to turn off the wrapping, and allow people to use horizontal scroll bar to control what is shown on the screen? --~--~-~--~~~---~--~~ You rece

Question about setting up Default Reviewers

2009-09-25 Thread Hui Lin
If we want person A to review all the changes made to any class of in directory "D", but also want person B to review changes made to a particular class "C1" in "D", how should we define the default reviewers? Would the followings work? Or only the first matched reviewer will be picked? * Def

Re: post-review login issue

2009-09-23 Thread Hui Lin
great. On Sep 23, 12:00 pm, Hui Lin wrote: > Hi, Dana: > > I saw your posts are rendered at full length each line, but mine are > wrapped at 70-80 characters, which makes them look quite different > from what I originally posted. > > What is the trick? > > Thanks >

Re: post-review login issue

2009-09-23 Thread Hui Lin
Hi, Dana: I saw your posts are rendered at full length each line, but mine are wrapped at 70-80 characters, which makes them look quite different from what I originally posted. What is the trick? Thanks On Sep 23, 11:28 am, Hui Lin wrote: > The issue started from line 107 of "diff

Re: post-review login issue

2009-09-23 Thread Hui Lin
> > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > > > On Tue, Sep 22, 2009 at 10:39 PM, Hui Lin wrote: > > > Uploading the diff works now after fixing some perforce registry > &g

Re: post-review login issue

2009-09-22 Thread Hui Lin
Uploading the diff works now after fixing some perforce registry issues. However, when I click the "View Diff" button in the request details page, I got this error: [Errno 2] No such file or directory: 'c:\\winnt\\temp\ \reviewboard.jyl6y5\\tmpsx6zut-new' The patched new file isn't there. I

Re: post-review login issue

2009-09-22 Thread Hui Lin
p4.exe some > > > place where the web server can see it in the PATH and it should work. > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.review-board.org > > > VMware, Inc. -http:/

Re: post-review login issue

2009-09-21 Thread Hui Lin
eview-board.org > VMware, Inc. -http://www.vmware.com > > > > On Mon, Sep 21, 2009 at 2:14 PM, Hui Lin wrote: > > > Yes, I solved this issue by putting what returned from "p4 info" > > exactly to the repository setup. My local p4 was using an alias of &g

Re: post-review login issue

2009-09-21 Thread Hui Lin
googlegroups.com > > *Subject:* Re: post-review login issue > > > Make sure that the repository Path field matches *exactly* what you see > > when running 'p4 info'. We do a literal string comparison. > > > Christian > > > -- > > Christian Hammond

Re: post-review login issue

2009-09-21 Thread Hui Lin
ectory writable by the web server. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > On Sun, Sep 20, 2009 at 5:57 PM, Hui Lin wrote: > > > The apache server was inst

Re: post-review login issue

2009-09-20 Thread Hui Lin
ct it's not the Review Board one. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > On Sun, Sep 20, 2009 at 5:18 PM, Hui Lin wrote: > > > "http://b00237d4f5

Re: post-review login issue

2009-09-20 Thread Hui Lin
Is there a debug flag on the review board server which can be turned on to trace what is happening? On Sep 20, 7:18 pm, Hui Lin wrote: > "http://b00237d4f5dc7/reviews/vtm/"; redirect me to the dashboard. > Going to "http://b00237d4f5dc7/reviews/vtm/api/json/accounts/logi

Re: post-review login issue

2009-09-20 Thread Hui Lin
> > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.review-board.org > VMware, Inc. -http://www.vmware.com > > On Sat, Sep 19, 2009 at 9:57 PM, Hui Lin wrote: > > > I was trying to create a post review request with the command o

post-review login issue

2009-09-19 Thread Hui Lin
I was trying to create a post review request with the command on Windows: post-review 388600 388600 is the changelist # of perforce. The script was able generate the diff but failed on logon the review board server, its url is: http://b00237d4f5dc7/reviews/vtm/ The error message showing