[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (8 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 3: (6 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#3). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool ...

[Impala-ASF-CR] IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#2). Change subject: IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool .

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9348 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9348

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9348 ) Change subject: Bump Kudu version to 0eef8e0 .. Bump Kudu version to 0eef8e0 This pulls in support for DECIMAL. Change

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (7 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 5: Build started: https://j

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9291 To

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryr

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9349

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9349 To

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9348 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9348 To uns

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9349 Change subject: Bump Kudu Java version to 1.7.0 .. Bump Kudu Java version to 1.7.0 Change-Id: I69a9bc9e36657a936591f723cf4110a1

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9306 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 2: (5 comments) > (1 comment) > > I ran th

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 10: (1 comment) Thanks for the reviews. Please see PS10. http://gerrit.clo

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#10). Change subject: IMPALA-6508: add KRPC test flag

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 7: (10 comments) Thanks for the reviews. Please see my in

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#7). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ..

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 9: Code-Review+1 (1 comment) Feel free to carry forward my +1 after fixin

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9348 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9348 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9348 To uns

[Impala-ASF-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9348 Change subject: Bump Kudu version to 0eef8e0 .. Bump Kudu version to 0eef8e0 This pulls in support for DECIMAL. Change-Id: Id9

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 3: Thanks for giving it a try! I might try to see if the https://

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9337/1/be

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. Patch Set 3: Verified-1 Build failed: https://jenkins.impal

[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options

2018-02-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9341 Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. [DOCS] Fix in REPLICA_PREFERENCE numeric options Change-Id: Ia10e69ac3

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/9292/6

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9292

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/9292/

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9337/1

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/929

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9346 Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. IMPALA-6230, IMPALA-6468: Fix the output

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 5: (6 comments) Some initial comments. Doing another pass.

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 6: PS 6 rebases the change and removed the client timeout

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#6). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ..

[Impala-ASF-CR] IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool

2018-02-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool .. Patch Set 1: (7 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9337/1

[Impala-ASF-CR] IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9344 Change subject: IMPALA-5518: Allocate RowBatch tuples pointers and data from BufferPool .. IMPALA-5518: Allocate RowBatch tuples pointers a

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9337/

[Impala-ASF-CR] IMPALA-6230: Change output type of round() to match the input type

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. ( http://gerrit.cloudera.org:8080/9174 ) Change subject: IMPALA-6230: Change output type of round() to match the input type .. Abandoned Published the wrong patch accidentally -- T

[Impala-ASF-CR] IMPALA-6230: Change output type of round() to match the input type

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9174 Change subject: IMPALA-6230: Change output type of round() to match the input type .. IMPALA-6230: Change output type of round() to

[Impala-ASF-CR] IMPALA-6405: Error when string to decimal cast overflows

2018-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9339 Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows

[native-toolchain-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9338 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/933

[native-toolchain-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9338 ) Change subject: Bump Kudu version to 0eef8e0 .. Bump Kudu version to 0eef8e0 This pulls in support for DECIMAL. Chang

[native-toolchain-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9338 ) Change subject: Bump Kudu version to 0eef8e0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9338 To uns

[native-toolchain-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9338 ) Change subject: Bump Kudu version to 0eef8e0 .. Bump Kudu version to 0eef8e0 This pulls in support for DECIMAL. Change-Id: I186

[native-toolchain-CR] Bump Kudu version to 0eef8e0

2018-02-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9338 Change subject: Bump Kudu version to 0eef8e0 .. Bump Kudu version to 0eef8e0 Change-Id: I186317c3440e1a50fffa87e67b23166da7715e

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 9: (3 comments) Thanks for the reviews, please see PS9. http://gerrit.clou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#9). Change subject: IMPALA-6508: add KRPC test flag .

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9337/1/

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 8: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. IMPALA-6416: extend Thread::Create to track i

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9337 Change subject: IMPALA-4874: Increase maximum KRPC message size .. IMPALA-4874: Increase maximum KRPC message size The default value for

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (4 comments) http://gerr

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. IMPALA-5690: Part 1: Rename ostream operators for thrift t

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-02-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: - BE

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a workarou

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9195/3/

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a workarou

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-15 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8958 to look at the new patch set (#4). Change subject: IMPALA-5152: Introduce metadata loading phase

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 3: (22 comments) I did not rebase for now to make reviewing eas

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (4 comments) > Line 38: I hav

[Impala-ASF-CR] IMPALA-6515: [docs] HAproxy with sticky session requires the check option

2018-02-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9293 Change subject: IMPALA-6515: [docs] HAproxy with sticky session requires the check option .. IMPALA-6515: [docs] HAproxy with sticky sessi

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 25: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 8: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9195/3

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/cus

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/885

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a workarou

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: > Patch Set 3: > > (2 com

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: > Patch Set 1: > > I thin

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 7: Fixed the clang-tidy warnings. -- To view

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9053 to look at the new patch set (#7). Change subject: IMPALA-6416: extend Thread::Create to track instance id ..

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. IMPALA-6512: Fix test_exchange_delays for KRPC The se

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Michael and/or David may want to do another pass and +2 the change. -- T

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9291/8/test

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (1 comment) http://gerrit.cloudera.o