[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4402 To un

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4402 To uns

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 21: Rebase. Carry +2. Fixed a bug in test_hs2::test_get_log where the test ass

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-15 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#21). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-15 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#20). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4402 To uns

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#19). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 18: I think this change has exposed a race in error log reporting that's very

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 18: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#18). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 17: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#17). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 16: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#16). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 14: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 15: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/runtime/co

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#14). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 13: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/4402/12/b

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-12 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#13). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 12: (10 comments) This patch includes planner test changes. http://gerrit.clo

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 12: (12 comments) http://gerrit.cloudera.org:8080/#/c/4402/10/be/src/runtime

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 11: (42 comments) http://gerrit.cloudera.org:8080/#/c/4402/10/be/src/exec/plan

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

Re: [Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson
Supposed to be a draft; will post the final patch in a short while. On 11 October 2016 at 16:44, Henry Robinson (Code Review) < ger...@cloudera.org> wrote: > Henry Robinson has uploaded a new patch set (#11). > > Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like > all others

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#11). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 10: (44 comments) haven't looked at plan-root-sink.cc yet http://gerrit.clo

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 10: EE tests pass with this new sink implementation as well. -- To view, visi

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#10). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 9: After some discussion, moved the result materialization into Send(). The log

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#9). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 8: End-to-end tests passed: http://sandbox.jenkins.cloudera.com/job/impala-umb

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#8). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) Will wait for rebase to continue. http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 7: (28 comments) This patch passes EE tests. I haven't completely addressed t

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#7). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-p

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pul

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: I took a look at NLJ-builder. It seems to do much the same thing as this pat

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: Marcel, the current accumulation of row batches is wrong, so don't think it make

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: before we go too far down that path, i think it would be a good idea that

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pul

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-s

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (24 comments) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#6). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i